Skip to content
Success

Changes

Summary

  1. StatsD_Checker: Abort on expectancy failure with clear status message (details)
  2. msc: Fix TC_stat_bsc_sctp_disconnected expectancies (details)
  3. bts: create all components alive (details)
  4. bts: fix unbound variable in as_rsl_fail_err() (details)
  5. fixup: bts: create all components alive (details)
Commit af6ce893eb4fecce025d285a132e0d0fc3a4042c by Pau Espin Pedrol
StatsD_Checker: Abort on expectancy failure with clear status message

Before this commit, a statsd expect failure would let the test continue
the test for a while and then finally log a rellay generic timeout
message, which makes really difficult to understand what's going on and
why is the test failing.

Let's terminate the test early if a test expectation fails, so it's a
lot easier to debug.
Add an extra param to be able to use the API for test logic to check the
state without failing/aborting. This is not really used anywhere so far
but the API was built this way and I indeed think it may be handy in the
future.

Change-Id: Ibc3d079c2a45aa22f9e2e42d75109cae66530f86
The file was modifiedlibrary/StatsD_Checker.ttcnpp
Commit 29fce5d2c8af5dde04becfb738f10662b8177f89 by Pau Espin Pedrol
msc: Fix TC_stat_bsc_sctp_disconnected expectancies

The test was passing when run alone, but was failing when run after
other tests using other BSCs/RNCs, since osmo-msc learned about them and
hence ran_peers.total was >1.

Change-Id: I22da7ae5c282a30e933f2f29b671ece8b6147ce9
The file was modifiedmsc/MSC_Tests.ttcn
Commit 713e7a86effa70e0aa1749c03ac1a5b687397fd8 by Vadim Yanitskiy
bts: create all components alive

This mitigates sporadic dynamic-testcase errors triggered by messages
being sent to components that have terminated before receiving them.

Change-Id: I68929b45d66d60617079a4f92d40ffea439bf4be
The file was modifiedbts/BTS_Tests_LAPDm.ttcn
The file was modifiedbts/BTS_Tests.ttcn
Commit 6741c21fe3065feab705f6ef22685e49052585c9 by Vadim Yanitskiy
bts: fix unbound variable in as_rsl_fail_err()

Change-Id: Ifcbdfb8b5a0e08ca3f8e610ca4940a2bdafa3cac
The file was modifiedbts/BTS_Tests_LAPDm.ttcn
Commit c50937d6371a7b203a52ec6c2daf52fe443f398f by Vadim Yanitskiy
fixup: bts: create all components alive

Making the ConnHdlr and lapdm_CT components alive resulted in
massive regressions.  Specifically, trxcon started rejecting L1CTL
connections with the following message:

  L1CTL server cannot accept more than 1 connection(s)

Apparently, alive components do not close the L1CTL connection
automatially, unless the L1CTL port is unmap()ped from the system
explicitly.  Thus, testcases spawning multiple alive components
end up creating multiple L1CTL connections, which get rejected.

Let's revert those components that speak L1CTL back to normal
(non-alive), while keeping the emulation components alive.

Change-Id: Id5edfa2514024d1fe83f6c4082e096044ce8e6fd
Fixes: 713e7a86 ("bts: create all components alive")
The file was modifiedbts/BTS_Tests_LAPDm.ttcn
The file was modifiedbts/BTS_Tests.ttcn