Skip to content
Success

Changes

Summary

  1. library/gsup: improve GSUP_IE templates (details)
  2. library/gsup: rework f_gen_{tr,ts}_ss_ies() and SS templates (details)
  3. library/gsup: add src/dst name IEs to all SS templates (details)
  4. library/rsl: rename t_RSL_IE_ActType_* -> c_RSL_IE_ActType_* (details)
Commit 514904197e217615c725db54ffd49b3cd509f68c by Vadim Yanitskiy
library/gsup: improve GSUP_IE templates

* Turn template params into templates
* Use proper template restrictions
* Remove unnecessary valueof()s
* Improve formatting

Change-Id: I67cc555a54113dccb11d0cc05cee66f5c2d795fe
The file was modifiedlibrary/GSUP_Templates.ttcn
Commit b62ea71137bdeb7ffd10de1cd88ad6bb55d47d89 by Vadim Yanitskiy
library/gsup: rework f_gen_{tr,ts}_ss_ies() and SS templates

* Add missing param restrictions to SS related templates.
* f_gen_{tr,ts}_ss_ies(): proper template param restrictions.
* f_gen_ts_ss_ies(): return a template, not a value.
* f_gen_ts_ss_ies(): append IEs using list index.
* f_gen_ts_ss_ies(): isvalue() -> istemplatekind()
                     to allow passing template lists.
* f_gen_tr_ss_ies(): istemplatekind() -> ispresent()
                     to allow passing template lists.
* f_gen_tr_ss_ies(): 'omit' -> '*' for optional params.

Change-Id: Ia611ffa3845d48c5553c70f10981aa029d00d873
The file was modifiedlibrary/GSUP_Templates.ttcn
Commit 1e61e9a7700debb508b1ab80db58fdeb936aadfd by Vadim Yanitskiy
library/gsup: add src/dst name IEs to all SS templates

This enables us to send/match OSMO_GSUP_{SOURCE,DESTINATION}_NAME
IEs (if needed) and brings consistency to all SS related templates.

This patch makes the following testcases pass [again]:

* TC_mt_ussd_for_unknown_subscr,
* TC_proc_ss_for_unknown_session.

At some point osmo-msc started including the Source Name IE in
OSMO_GSUP_MSGT_PROC_SS_ERROR messages, which we didn't expect.

Change-Id: I8d947313a99491d2e4790bc06db863fe09d8b5cf
The file was modifiedlibrary/GSUP_Templates.ttcn
Commit 17f0da1ea64d37624e63a3aa66586b834f2e8c1d by Vadim Yanitskiy
library/rsl: rename t_RSL_IE_ActType_* -> c_RSL_IE_ActType_*

We use prefix 't_' for templates and prefix 'c_' for constants.

Change-Id: I4ae8f6c35f6f823060833f24a0cad41cc9894750
The file was modifiedlibrary/RSL_Types.ttcn
The file was modifiedbts/BTS_Tests.ttcn