Skip to content
Success

Changes

Summary

  1. testenv: osmo_dev: remove unused limit_section arg (details)
  2. testenv/osmo-dev: split get_targets to own func (details)
  3. testenv: pass targets to osmo-dev's gen_makefile (details)
Commit 9cf4619d33570fa62fd7b8d3165f8ab558f79692 by Oliver Smith
testenv: osmo_dev: remove unused limit_section arg

Remove the unused limit_section argument in testenv.osmo_dev.make(). The
idea was to use osmo-dev to build programs where no packages are
available when using --binary-packages, but this didn't work because
when using --binary-packages, we must install all package dependencies
from the binary repository (so testing nightly / latest use the expected
library versions). Nowadays this use case is handled by
podman_install.from_source_* functions without using osmo-dev.

Change-Id: Ib09ffd0e269c58acd431bdbb5cc7cdcec2d36359
The file was modified_testenv/testenv/osmo_dev.py
Commit e226ed9c05da377d551227a0a10cbd5ef0d30213 by Oliver Smith
testenv/osmo-dev: split get_targets to own func

Split the code for getting osmo-dev targets into a separate function, so
this can be reused in the next patch.

Change-Id: I2bd7c05102ca472614289870957cdca335c01eaf
The file was modified_testenv/testenv/osmo_dev.py
Commit 34d9429b2bd5836ddcd35f60ed0a3000e38438ae by Oliver Smith
testenv: pass targets to osmo-dev's gen_makefile

Pass the targets we are about to build to osmo-dev's gen_makefile
script. This has two advantages:

1) Check early if a target isn't known by the current osmo-dev version,
   displaying a useful error to the user instead of just failing during
   make later on:

     ERROR: filter_projects_deps_targets: can't find project osmo-new-project in projects_deps!

     [testenv] gen_makefile.py from osmo-dev failed!
     [testenv] Your osmo-dev.git clone might be outdated, try:
     [testenv] $ git -C /home/user/code/osmo-dev pull

2) Parsing the generated Makefile when running "make" after generating
   it doesn't cause a noticable delay anymore. On my machine (with many
   Osmocom git repos cloned in osmo-dev's src dir) it went from several
   seconds to instantly.

Depends: osmo-dev I89bb60e94dd03606dbba5a3609d5e1a95993af5b
Change-Id: Ib2d8802b305f145d27aab3c1cc3129709b93d93d
The file was modified_testenv/testenv/osmo_dev.py
The file was modified_testenv/testenv.py