Skip to content
Unstable

Changes

Summary

  1. stp: Introduce tests TC_dyn_(2)asp_as_rkm_permitted (details)
  2. stp: Fix expectancies of TC_clnt_quirk_snm_inactive (details)
  3. stp: Fix brokeness in STP_Tests_M3UA.TC_tmt_loadshare (details)
  4. stp: Fix brokeness in STP_Tests_IPA.TC_tmt_loadshare (details)
  5. stp: STP_Tests.ttcn: Use M3UA PC and RCTX from config (details)
Commit 1f3865fd7e7d81c41eeb61cc9574a9c931de69ce by Pau Espin Pedrol
stp: Introduce tests TC_dyn_(2)asp_as_rkm_permitted

These tests allows testing behavior of scenarios related to dynamic
ASP/AS/RKM improved/fixed in libosmo-sigtran.git Change-Ids:
I986044944282cea9a13ed59424f2220fee6fe567
I85948ab98623a8a53521eb2d2e84244011b39a93
I3dffa2e9c554f03c7c721b757ff33a89961665b5

Change-Id: Ic3116cbe63832003876ae19b31491275aebb41a9
The file was modifiedstp/STP_Tests_M3UA.ttcn
The file was modifiedstp/expected-results.xml
Commit bb2d39ff2d79d437edab8783d778fa83434913ff by Pau Espin Pedrol
stp: Fix expectancies of TC_clnt_quirk_snm_inactive

The test STP_Tests_M3UA.TC_clnt_quirk_snm_inactive validates the
snm_inactive quirk by sending a DAUD before the link being activated,
and expecting a DAVA to make sure osmo-stp did indeed process the SNM
message.
However, osmo-stp used to lack proper route validation based on link
state, which means it would incorrectly assumed the link for the
affected PC (55) in the test was active and hence would answer with a
DAVA. After libosmo-sigtran.git Change-Id
I928fb1ef5db6922f1386a188e3fbf9e70780f25d this wrong behavior is fixed,
and hence osmo-stp starts answering with a DUNA instead of a DAVA, since
AS "as-client" has not yet been activated during the test.
Fix the test expectancies by expecting a DUNA instead of a DAVA.

Change-Id: I907981c1487b299df852c405bae1fefff4bf5191
Depends: libosmo-sigtran.git Change-Id I928fb1ef5db6922f1386a188e3fbf9e70780f25d
Related: SYS#7112
The file was modifiedstp/STP_Tests_M3UA.ttcn
Commit 009199c9d571c26f52a18e55bd5a6f6b314ad649 by Pau Espin Pedrol
stp: Fix brokeness in STP_Tests_M3UA.TC_tmt_loadshare

The test was not even setting the traffic-mode in the IUT.
Furthermore, it was expecting pure round-robin behavior, which was the
older behavior of osmo-stp when loadshare traffic-mode was selected.

Actually split the test into 2, naming them properly (since round robin
is not a AS traffic mode in itself, but a possible implementation of the
loadshare traffic-mode.

The new test validates the usual loadshare traffic-mode based on SLS
distribution.

Related: SYS#7112
Depends: libosmo-sigtran.git Change-Id I61340549c596f1c04bc2269dbc165c327bf72037
Change-Id: I16d81cb2f88bb2927f248182ad4f8f27c8c24859
The file was modifiedstp/STP_Tests_M3UA.ttcn
The file was modifiedstp/expected-results.xml
Commit 8d0f1a96b3802364a07585684565c233fdb6c0fc by Pau Espin Pedrol
stp: Fix brokeness in STP_Tests_IPA.TC_tmt_loadshare

Similar to previous commit for M3UA, this time for IPA.
Since in IPA so far the SLS is fixed per ASP, we need to add an extra
sender ASP which will get a new asp_id (and hence SLS) so that we can
also test traffic being sent/distributed to the 2nd receiver.

Change-Id: I61c3efbf8e30533d051e2de506f7c8eaae7e297b
The file was modifiedstp/osmo-stp.cfg
The file was modifiedstp/STP_Tests_IPA.ttcn
The file was modifiedstp/expected-results.xml
The file was modifiedstp/STP_Tests.ttcn
Commit 03b3bff502a10538544da996574b7d5e61672eb2 by Pau Espin Pedrol
stp: STP_Tests.ttcn: Use M3UA PC and RCTX from config

Change-Id: I81c8402d5ccd6e59f2a6869927c637fff30cb952
The file was modifiedstp/STP_Tests_M3UA.ttcn
The file was modifiedstp/STP_Tests.ttcn