Skip to content
[Jenkins]Jenkins
log insign up
Success

Changes

Summary

  1. RUA_Emulation: Support passing no RANAP PDU in RUA_Disc_Req (details)
  2. hnbgw: Add missing timer stop after use (details)
  3. hnbgw: Get rid of pars param in void_fn (details)
  4. testenv: run podman command with logfile (details)
  5. library/s1ap: fix wrong IE criticality in templates (details)
  6. library/s1ap: rework {ts,tr}_S1AP_RABSetupRsp templates (details)
  7. s1gw: add TC_e_rab_setup_failure (details)
  8. hnbgw: test for RUA Disconnect when there is no CN (details)
  9. hnbgw: Send meaningful RANAP messages in f_tc_ranap_mo_disconnect() (details)
  10. hnbgw: Introduce test TC_cs_iu_release_req_rua_disconnect (details)
  11. hnbgw: fixup for expect_compl_l3_success (details)
  12. hnbgw: Rename RAB helper functions to be CS specific (details)
  13. hnbgw: Use g_pars.mgcp_pars directly during RAB CS setup (details)
  14. hnbgw/expected-results: update (details)
  15. testenv: make podman stop more robust (details)
Commit 9c3d5b9beb5033c0491469093df1e865689e6e46 by Pau Espin Pedrol
RUA_Emulation: Support passing no RANAP PDU in RUA_Disc_Req

Change-Id: Id9c3d5a1e45aa6ca58a71b61e142dc041a335cc9
The file was modifiedlibrary/rua/RUA_Templates.ttcn
The file was modifiedlibrary/rua/RUA_Emulation.ttcn
The file was modifiedhnbgw/ConnHdlr.ttcn
Commit 17329a909a62e3c055780b0ac6470bbf560a5b89 by Pau Espin Pedrol
hnbgw: Add missing timer stop after use

Change-Id: I2c722f524de603b75f2b7c6ba85d074518d1f51c
The file was modifiedhnbgw/HNBGW_Tests.ttcn
Commit 0135d187401d3a40dd81706b922de8823d9bab14 by Pau Espin Pedrol
hnbgw: Get rid of pars param in void_fn

Store pars into component field "g_pars" before caling void_fn.
This simplifies ConnHdlr test functions and also avoids potential
problems modifying pars vs g_pars.
This is the same as we do in lots of other testsuites.

Change-Id: I674b2a6a6a0e39f2904f9125783180da8ade5f44
The file was modifiedhnbgw/ConnHdlr.ttcn
The file was modifiedhnbgw/HNBGW_Tests.ttcn
Commit 00f332eca58e81ae366deaf21e6ce8d2cfc79d97 by Oliver Smith
testenv: run podman command with logfile

In very rare cases it seems podman is just crashing with no reason in
jenkins. Add logging to the main script we run inside podman, and run
podman with a logfile attached to figure out why.

Related: OS#6607
Change-Id: Ife3c0ae559c94f7df8b5912bb0e338ae6283cb7f
The file was modified_testenv/data/scripts/testenv-podman-main.sh
The file was modified_testenv/testenv/podman.py
Commit 2978fad2273fc8f0db4b2eba315f52bbba5db777 by Vadim Yanitskiy
library/s1ap: fix wrong IE criticality in templates

Related sections in 3GPP TS 36.413:

* 9.1.3.2 E-RAB SETUP RESPONSE
* 9.1.3.6 E-RAB RELEASE RESPONSE

Change-Id: I3fd9efc4c504037758b3d97e920776123f2141e9
Related: SYS#6772
The file was modifiedlibrary/s1ap/S1AP_Templates.ttcn
Commit ce2c44c1e2e941caa7a69ebbb660ef9e904fcf66 by Vadim Yanitskiy
library/s1ap: rework {ts,tr}_S1AP_RABSetupRsp templates

3GPP TS 36.413, section 9.1.3.2 "E-RAB SETUP RESPONSE" defines
the following two IEs as optional:

* E-RAB Setup List IE: 0..1 in the Range column means that
  it can either be omitted (0) or included only once (1);
* E-RAB Failed to Setup List: 'O' in the Presence column.

Our templates for this S1AP PDU require the former to be a value
(as if it was mandatory) and do not allow passing the later.

Change-Id: Ic369ae720179483a19383af2bddf56186965eae3
Related: SYS#6772
The file was modifiedlibrary/s1ap/S1AP_Templates.ttcn
Commit 47544443bde2e01750bc03e9622ec8f61f91881e by Vadim Yanitskiy
s1gw: add TC_e_rab_setup_failure

Change-Id: I97102292678e732265dcae04d60f7a708a5246dc
Related: osmo-s1gw.git I242e84fb09b00f4794b6e1aa770f348a0e60aea4
Related: SYS#6772
The file was modifieds1gw/expected-results.xml
The file was modifieds1gw/S1GW_Tests.ttcn
Commit 25fc127c9fd1dafea51db1f8d617ef6cf0db870d by Oliver Smith
hnbgw: test for RUA Disconnect when there is no CN

Related: OS#6283
Related: osmo-hnbgw Iafb30c31a4c5db53ecdda99a0e0b5937b71e362c
Tweaked-by: Oliver Smith <osmith@sysmocom.de>
Change-Id: I2b5c024a395e736538c0c37db40d34f3b8d99991
The file was modifiedhnbgw/HNBGW_Tests.ttcn
The file was modifiedhnbgw/ConnHdlr.ttcn
Commit aeb0a0c236854129fe8b71f4d8e492251a36d234 by Pau Espin Pedrol
hnbgw: Send meaningful RANAP messages in f_tc_ranap_mo_disconnect()

Fix the code to send the messages that were fore sure intended, where an
MO disconnect is triggered.
This allows attaching more to reality, plus making it easier to follow
up the test in wireshark and in the code.

Change-Id: I9a2bb35d58c6cdda312638103ef5c3c2f5661e62
The file was modifiedhnbgw/HNBGW_Tests.ttcn
Commit ffec46faf1559b498eb4fb2a27a520be276fd94d by Pau Espin Pedrol
hnbgw: Introduce test TC_cs_iu_release_req_rua_disconnect

Related: SYS#6602
Change-Id: I6782920c4a86d3311eb54239ab13a18e393c1ec0
The file was modifiedhnbgw/expected-results.xml
The file was modifiedlibrary/ranap/RANAP_Templates.ttcn
The file was modifiedhnbgw/HNBGW_Tests.ttcn
Commit cd30b5380cfc6f0400989852fea35d74ce7c9ec6 by Oliver Smith
hnbgw: fixup for expect_compl_l3_success

During my rebase of Neels patch, I've missed setting
expect_compl_l3_success in t_pars(), leading to:

  HNBGW_Tests.ttcn:571 Dynamic test case error: Text encoder: Encoding an unbound boolean value.

For a lot of tests. Also add the parameter to f_TestHdlrParams() for
consistency.

Fixes: 25fc127c ("hnbgw: test for RUA Disconnect when there is no CN")
Change-Id: Idbfcb77a80d74f7715ef1f84ba4cbfdb08483a5c
The file was modifiedhnbgw/ConnHdlr.ttcn
The file was modifiedhnbgw/HNBGW_Tests.ttcn
Commit 2f6d1bb9be96a48414bf402201b949c75e0e13bb by Pau Espin Pedrol
hnbgw: Rename RAB helper functions to be CS specific

Change-Id: If8a97fe847083e95a480006d147ff59be695b713
The file was modifiedhnbgw/HNBGW_Tests.ttcn
The file was modifiedhnbgw/ConnHdlr.ttcn
Commit ab24560830c80b1f676b33ba8c8beeec636ea394 by Pau Espin Pedrol
hnbgw: Use g_pars.mgcp_pars directly during RAB CS setup

Change-Id: I1f699e197e29f912ad06378f10563063aa291af3
The file was modifiedhnbgw/HNBGW_Tests.ttcn
The file was modifiedhnbgw/ConnHdlr.ttcn
Commit a487d2b0e8c349d50f68e7f5c43c0ef939b07736 by Oliver Smith
hnbgw/expected-results: update

Add:
* TC_hnb_disconnected_timeout
* TC_mscpool_L3Compl_no_cn
* TC_sgsnpool_L3Compl_no_cn

Fixes: 25fc127c ("hnbgw: test for RUA Disconnect when there is no CN")
Change-Id: Ib126ff53aa9edfeb94f5e7e058145bd4fbe7b604
The file was modifiedhnbgw/expected-results.xml
Commit 9eb5e696a0997e0de8db0248ba8be31ebb2cdac9 by Oliver Smith
testenv: make podman stop more robust

Terminate the watchdog process before killing the podman container. This
avoids bogus errors from a race condition where the container gets
killed first, and then the watchdog process tries to feed the watchdog
and fails:

  [testenv] Stopping podman container
  [testenv] + ['podman', 'kill', 'testenv-hnbgw-all-osmocom-latest-20241031-1222-f34534a5-1']
  e41700779a8ca5daf18ac5daa27d59a84d8442196e352f2756a19baf0592cf89
  Error: no container with name or ID testenv-hnbgw-all-osmocom-latest-20241031-1222-f34534a5-1 found: no such container
  [testenv] podman container crashed!

While at it, use "check=False" with the "podman kill" command, so we
avoid additional error messages if the container was already killed at
that point (could happen through a bug). If we fail to kill it here, it
is not a problem because the watchdog will ensure it terminates shortly
after the watchdog process was stopped.

Related: OS#6607
Change-Id: I6c67273af5b6a80ae0c94e14cb92e3784807c21d
The file was modified_testenv/testenv/podman.py