Skip to content

Changes

Summary

  1. libgtp: move includes to osmocom/include/gtp (details)
  2. gtp/gsn_internal.h: new file (details)
  3. gtp/gtp.c: move gtp_create_context_resp down (details)
  4. gtp: remove unused conversion functions (details)
  5. gtp: move conversion functions up (details)
  6. gtp/gtp_internal.h: new file (details)
Commit 1dd16fa12fd29cb35b4e1b381229a2456fa98901 by Oliver Smith
libgtp: move includes to osmocom/include/gtp

Move all includes from /usr/include/….h to
/usr/include/osmocom/gtp/….h to be more consistent with other Osmocom
projects, and to not "pollute" the top include directory if we add more
header files.

Also the new directory structure makes more obvious, which headers are
public and which ones aren't.

Adjust libgtp.pc.in so both #include <gtp.h> (legacy)
and #include <osmocom/gtp/gtp.h> can be used.

Related: OS#6373
Change-Id: If7e01c61168819bf7120667344e40c857da5490b
The file was modified gtp/gtp.c
The file was addedinclude/osmocom/gtp/Makefile.am
The file was modified sgsnemu/Makefile.am
The file was addedinclude/osmocom/gtp/gsn.h
The file was modified lib/util.c
The file was modified configure.ac
The file was modified gtp/gsn.c
The file was modified gtp/queue.c
The file was modified lib/ippool.h
The file was modified lib/gtp-kernel.c
The file was modified gtp/pdp.c
The file was modified lib/Makefile.am
The file was modified lib/icmpv6.h
The file was modified lib/icmpv6.c
The file was addedinclude/osmocom/Makefile.am
The file was removedgtp/pdp.h
The file was modified gtp/Makefile.am
The file was modified sgsnemu/sgsnemu.c
The file was addedinclude/osmocom/gtp/gtp.h
The file was modified ggsn/Makefile.am
The file was modified tests/gtp/gtpie_test.c
The file was modified ggsn/ggsn.h
The file was modified Makefile.am
The file was modified gtp/queue.h
The file was removedgtp/gsn.h
The file was modified ggsn/ggsn.c
The file was modified ggsn/ggsn_vty.c
The file was modified ggsn/sgsn.h
The file was removedgtp/gtpie.h
The file was modified ggsn/pco.h
The file was addedinclude/osmocom/gtp/gtpie.h
The file was modified lib/in46_addr.h
The file was addedinclude/osmocom/gtp/pdp.h
The file was modified gtp/gtpie.c
The file was modified libgtp.pc.in
The file was removedgtp/gtp.h
The file was addedinclude/Makefile.am
The file was modified lib/in46_addr.c
Commit bad5eeba0fb4c9e203f57bf253a371cb7c0c6345 by Oliver Smith
gtp/gsn_internal.h: new file

Change-Id: I999462e39411fc4ec7e50bd0212e870006fbc4f1
The file was addedgtp/gsn_internal.h
The file was modified gtp/gsn.c
The file was modified gtp/Makefile.am
The file was modified gtp/gtp.c
The file was modified include/osmocom/gtp/gsn.h
Commit 3cb3423a59584bb90f41fcabfc4700eb110c0a5f by Oliver Smith
gtp/gtp.c: move gtp_create_context_resp down

Move gtp_create_context_resp below gtp_create_pdp_resp, which it calls.
In a follow-up commit, we can make gtp_create_pdp_resp static and
remove the additional declaration.

Change-Id: I34efe7592013a8423f4f280758272d81f24b65fa
The file was modified gtp/gtp.c
Commit 68f5b086ad6d86a04fcb9caccd73d16cfa9ce033 by Oliver Smith
gtp: remove unused conversion functions

Remove ipv42eua and eua2ipv4, which are in the "internal functions"
section of gtp.h, but are not used anywhere in the code anymore. This is
in preparation of moving the internal functions that are used in
multiple .c files into a separate header file, and to make the other
internal functions static. (Compiler complains about unused static
functions.)

Change-Id: I90e2750f6a6e3e6122e9c562103fda77d7326932
The file was modified include/osmocom/gtp/gtp.h
The file was modified gtp/gtp.c
The file was modified TODO-RELEASE
Commit fbef52722243a2f455a6ee2fefb33475a6b915db by Oliver Smith
gtp: move conversion functions up

Move the conversion functions above the first user, so we can make
in_addr2gsna static in a follow-up commit and remove the extra
declaration.

Change-Id: I51e6a7c1161320fc54b0e8197ae57e4327976eb1
The file was modified gtp/gtp.c
Commit 519a2e401d521fabef2d814dbf4e5b1e470ecf76 by Oliver Smith
gtp/gtp_internal.h: new file

While at it, move internal functions of gtp.h to a separate file too.
Make all functions that are only used inside gtp.c static.

The following APIs are unexpectedly public:
* imsi_gtp2str gets used by pdp.h
* gsna2in_addr, gtp_echo_req gets used by osmo-sgsn

Change-Id: I72c40cbdec33449ca8104fb3cad8df1a9e07dfd7
The file was modified ggsn/ggsn_vty.c
The file was modified ggsn/ggsn.c
The file was modified gtp/Makefile.am
The file was modified gtp/gtp.c
The file was modified sgsnemu/sgsnemu.c
The file was modified ggsn/sgsn.c
The file was addedgtp/gtp_internal.h
The file was modified include/osmocom/gtp/gtp.h