Skip to content

Changes

Summary

  1. mobile: cosmetic: fix -Wswitch in tch_voice_state_init() (details)
  2. mobile: fix -Wmaybe-uninitialized in gsm48_rr_tx_meas_rep() (details)
Commit c310fcfef7f10d026fbfb9569c2a2b46c6984186 by Vadim Yanitskiy
mobile: cosmetic: fix -Wswitch in tch_voice_state_init()

Not really critical, just make gcc happy:

tch_voice.c: In function ‘tch_voice_state_init’:
tch_voice.c:117:9: warning: enumeration value ‘TCH_VOICE_IOH_GAPK’ not handled in switch [-Wswitch]
  117 |         switch (state->handler) {
      |         ^~~~~~

Change-Id: I46afce396f730de26f21e0e4ec71e144aafd6beb
The file was modified src/host/layer23/src/mobile/tch_voice.c
Commit 04ea6f9cab3d9d5120c77f88b500bad526564c0a by Vadim Yanitskiy
mobile: fix -Wmaybe-uninitialized in gsm48_rr_tx_meas_rep()

This is very unlikely to happen, because we set strongest to 127,
but anyway we don't want to see those warnings:

gsm48_rr.c: In function ‘gsm48_rr_tx_meas_rep.isra’:
gsm48_rr.c:3714:74: warning: ‘strongest_i’ may be used uninitialized [-Wmaybe-uninitialized]
3714 |                                 if (rrmeas->nc_rxlev_dbm[i] == strongest && i <= strongest_i)
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
gsm48_rr.c:3696:31: note: ‘strongest_i’ was declared here
3696 |                 int i, index, strongest_i;
      |                               ^~~~~~~~~~~

Change-Id: I111438633ed48e16f7c43fc1b7a23ae6753a404d
The file was modified src/host/layer23/src/mobile/gsm48_rr.c