Skip to content

Changes

Summary

  1. tests: do not copy *.cfg files to the build directory (details)
  2. tests: rename logging_test_gsmtap -> logging_gsmtap_test (details)
  3. vty: fix memleak in host_config_set() (details)
Commit 225fd1b24878a175cecc0784315cca6cf6356fe7 by Vadim Yanitskiy
tests: do not copy *.cfg files to the build directory

When running 'make check' in-tree ($builddir == $srcdir), those
*.cfg files end up in tests/ and show up as git-add candidates.
Instead of copying them, just let the test binaries know where
to find those files via the cmdline parameters.

Change-Id: I74e428f0548418fdecada3d25049d6e110e790fe
The file was modified tests/msgfile/msgfile_test.c
The file was modified tests/vty/vty_test.c
The file was modified tests/testsuite.at
The file was modified tests/Makefile.am
Commit 2557bd244c5cdc05f761326e40c7cdb586220b88 by Vadim Yanitskiy
tests: rename logging_test_gsmtap -> logging_gsmtap_test

This way the naming is consistent with existing tests and
matches the 'tests/*/*_test' pattern in .gitignore.

Change-Id: I280fc0cc1bda9ba445af71f00bc8f1ccfd2b2091
The file was removedtests/logging/logging_test_gsmtap.err
The file was addedtests/logging/logging_gsmtap_test.c
The file was modified tests/Makefile.am
The file was removedtests/logging/logging_test_gsmtap.c
The file was addedtests/logging/logging_gsmtap_test.err
The file was modified tests/testsuite.at
Commit dafdb1181b9f64848caa2265a563444ffcf5e370 by Vadim Yanitskiy
vty: fix memleak in host_config_set()

Not only we call this function from vty_read_config_file(), but
also from config_write_file_cmd.  Thus we leak memory when doing
'write file FILE' in the VTY.

Change-Id: I356818aae3addab6db39de9a625453b7435b7cc1
The file was modified src/vty/command.c