Nokia InSite gets a different config than the larger Nokia BTS models, and make_bts_config() function checks the BTS type to decide which config to send. Change the BTS type check from a long 'if' line that compares against 3 different InSite BTS type codes to bts_is_insite() helper function that encapsulates a switch statement.
Upcoming code additions will need to check for Flexi Multiradio BTS family in a similar manner - so be consistent.
nokia cosmetic: factor out BTS_CONF_COMPL handling
When the BTS accepts the config sent to it via BTS_CONF_DATA, it responds with BTS_CONF_COMPL. Upon receiving the latter message, we have to send TRX unlock and TRX reset commands, and we have to start LAPD for RSL. Factor out this logic into a helper function, to reduce the level of indentation and make it easier to extend.
In the case of MetroSite and UltraSite BTS, it has been determined empirically that TRX reset needs to be skipped for non-BCCH TRX. However, the opposite situation holds on Flexi MR: non-BCCH TRX do need to be reset, or they fail to come up. Solution: conditionalize reset of non-BCCH TRX on Nokia BTS type.