Skip to content
Success

Changes

Summary

  1. test: move S1AP PDU samples (blobs) into their own file (details)
  2. osmo_s1gw: add set_log_prefix/1 (details)
  3. sctp_proxy: add _from_{enb,mme} variants of sctp_send/2 (details)
  4. sctp_proxy: fix wrong operator in connecting/3 (details)
Commit f797f9a465beef67e73a16b64e72815eb860b47d by Vadim Yanitskiy
test: move S1AP PDU samples (blobs) into their own file

This allows using these samples from other (upcoming) tests.

Change-Id: I4b1d3f3a009009ab7620656a3b906e60481e47a1
The file was modifiedtest/s1ap_proxy_test.erl
The file was addedtest/s1ap_samples.erl
Commit c8e419995bfe6e31f74d1145f722d1c6f6967bc2 by Vadim Yanitskiy
osmo_s1gw: add set_log_prefix/1

Let's have a common API that can be used by all other modules.

Change-Id: I77ee96f195067ef0137f2cb8af5d455b24ccdd54
The file was modifiedsrc/s1ap_proxy.erl
The file was modifiedsrc/osmo_s1gw.erl
The file was modifiedsrc/erab_fsm.erl
Commit aeb94b3746fce84b1f9b3e39b1a59c6979ed2a95 by Vadim Yanitskiy
sctp_proxy: add _from_{enb,mme} variants of sctp_send/2

The existing sctp_send/2 is sending data from an eNB towards
the MME.  Sending data in the opposite direction is done in-place.

For the sake of readability, let's add the counterpart of sctp_send/2
and clarify the direction by adding _from_{enb,mme} to function names.

Change-Id: I388137e27ea5000f22e7a5b58d1ffcfd9caa1475
The file was modifiedsrc/sctp_proxy.erl
Commit 0f5467fb42e92964ad5f535168ecf75447e4032f by Vadim Yanitskiy
sctp_proxy: fix wrong operator in connecting/3

We need to update the map, thus the update operation (`=>`) needs
to be used, not the matching (`:=`).  We're lucky that eNBs usually
do not send anything before the MME responds to the S1Setup request;
otherwise the S1GW would crash here due to a mismatch.

Change-Id: I26d8a8da5cce89324a9e1150e4ecdf2084d097c8
The file was modifiedsrc/sctp_proxy.erl