Changes

library/s1ap: add E-RAB RELEASE templates

Change-Id: I2e9305da80934ea68e3eca8215a9c16de48b37fd

s1gw: derive functions from f_TC_e_rab_setup()

... to avoid code duplication when adding more E-RAB related TCs.

While at it, allow establishing multiple E-RABs.

Change-Id: I1bff371da6337ecd7710219d1c86f0fff82ad17f

s1gw: fix TC_e_rab_setup: handle PFCP Session related PDUs

S1GW_Tests.TC_e_rab_setup is failing since we introduced the PFCP
support to osmo-s1gw.  The IUT now requires co-located UPF, which
we need to emulate in the testsuite.

This patch patch adds the following API:

* S1GW_ConnHdlr.f_ConnHdlr_rx_session_establish_req(),
* S1GW_ConnHdlr.f_ConnHdlr_tx_session_establish_resp(),
* S1GW_ConnHdlr.f_ConnHdlr_rx_session_modify_req(),
* S1GW_ConnHdlr.f_ConnHdlr_tx_session_modify_resp(),

and makes use of it in S1GW_Tests.TC_e_rab_setup.

Change-Id: Ibbb326badaa1e3df968c137f3e4b576ca5c6f94d

s1gw: TC_e_rab_setup: also test E-RAB release

* s1ap: add E-RAB RELEASE API
* pfcp: add PFCP Session Deletion API
* s1gw: make use of this API in TC_e_rab_setup

Change-Id: Id995c51d8ac76316f41ef49d35380a2521d5ae19

s1gw: add TC_e_rab_setup3 (3 E-RABs at a time)

The idea is to verify setup and release of 3 E-RABs at a time.

Change-Id: I6a0a10f826309d8a952c77c23170df3d201e7640

deps/update.sh: split update cmds from Makefile

Move the inline shell commands from the Makefile to a separate script,
so they are easier to edit and maintain. Proper syntax highlighting, no
need for all the backslashes + &&, etc.

Change-Id: Ifab1158000ccb39f0b384bbd81841e417ed24f37

deps/update: don't fetch repos where COMMIT exists

Instead of unconditionally fetching each git repository, check if the
commit we want to checkout already exists in the git repository. If that
is the case, then don't fetch it.

Related: OS#6572
Change-Id: I342957668892e7d29666fada82362cb4a6c7aac5

deps: make output readable

Instead of having a silent fetch and commits printed to stdout without
information about the repository they belong to, change the output to
have one line per git action and to include the repository name in each
of them.

Example output:

[titan.ProtocolEmulations.M3UA] Checking out b58f92046e48a7b1ed531e243a2319ebca53bf4c
[titan.ProtocolModules.IP] Checking out 1be86705f39ae38f3c04b2109806ee20d25e91d0
[titan.ProtocolModules.GTP_v13.5.0] Checking out 6b769f985eb91bf5a4332f29faa4a043b23ce62e
[titan.ProtocolModules.ICMP] Checking out e49d9fb9f7de637b4bf4803dc6b6e911a8661640
[osmo-uecups] Initial git clone
[titan.ProtocolModules.DIAMETER_ProtocolModule_Generator] Checking out ffd939595a08da1b8c8176aaa1f8578bfe02a912
[titan.ProtocolModules.L2TP] Checking out 17e76d3662bd0bb815158e8a9de1ec413f21b530
[titan.ProtocolModules.ICMPv6] Checking out 46f4d9b6e1e3c794294a92588401a81e4881dd27
[titan.ProtocolModules.LLC_v7.1.0] Checking out 09817f113255d7fb56f1d45d3dd629a093d9248d
[titan.ProtocolModules.M3UA] Checking out c496d298876fed55c2b730278b7ee77982555563
[titan.ProtocolModules.PFCP_v15.1.0] Checking out d550ad9ddb6f9c823c9a555254cd76cf0e738d18
[titan.ProtocolModules.MobileL3_v13.4.0] Checking out b6602eb357673f097ea1a1d22edd568ecd239da1
[titan.TestPorts.TELNETasp] Checking out 873fe539642542cd9a901c208f1ec11c6d2f5387
[titan.TestPorts.SIPmsg] Checking out 78bf0daf8c599d374089d97a054914d8439d133a
[titan.TestPorts.UDPasp] Checking out 54176e95850654e5e8b0ffa2f1b5f35c412b949c
[titan.ProtocolModules.BSSGP_v13.0.0] Checking out e97d92a8b66bec399babea52f593771b76cb175a
[titan.ProtocolModules.BSSMAP] Checking out 4acb6ab5f058477f0b90c2da182d52054e3614b0
[osmo-uecups] Updating URL to https://gerrit.osmocom.org/osmo-uecups
[osmo-uecups] Checking out 8362efef7c6fa341eb947a75786878e0685767b7

Change-Id: I0231488b02fdb5aa19b864e51864682ebbb3b0c6

deps/update: skip checkout if nothing to do

Let the user see what changes when running "make deps" instead of
having unrelated lines for checking out the commits that are already
checked out.

Change-Id: I572ab11afd56e34d9d0d04cd1372af749caa7d48

Makefile: avoid fetching deps if not needed

Running `make deps` for the first time fetches all the dependencies.
Running `make deps` again currently results in unnecessary git-fetch
and get-checkout operations for each dependency.

This is not as bad as cloning dependencies from scratch every time,
but still takes time and triggers unnecessary requests to the servers.
It's also creating problems when building testsuites offline.

This patch makes the build system a bit smarter in a way that it would
only try to update dependencies if the 'deps/Makefile' was changed.

Change-Id: Iae98585f0a83b17596857eba8c2f51a785198580
Related: OS#6572

.gitignore: ignore '.make.*' files (like .make.deps)

Change-Id: I79dfa38bc874a48cb09a6e6fb3f06405ba869491
Related: c7e40d6a "Makefile: avoid fetching deps if not needed"

.gitignore: ignore ctags

Change-Id: I90f468049189d919aa0cbc3c1da1ac6f8422bc36
Related: 600ebb235 "Makefile: add target for generating tags"

Remove dead links and generated code in bin/*

Change-Id: I60929c5d4acba4d0d8df3696fade370d7e0100f8

{bsc-nat,selftest,sysinfo}/gen_links.sh: use bash, not sh

This fixes the following error:

  ./gen_links.sh: 40: shopt: not found

which is printed when compiling the above-mentioned testsuites.

Change-Id: I994e241efb73f6f8b78803cf4ecdfb057b210a3b

gen_links.sh.inc: 'set -e' to abort on error

We should not tolerate errors in '*/gen_links.sh' files.

Change-Id: Id9367e4c45c84dcbf1c308581360be73242c0d38

testenv: testsuite: use rsync with --archive

When running in podman, the source files from the testsuite get copied
to a temporary directory to build the testsuites out-of-tree (avoiding
conflicts with possibly incompatible binary objects that may exist from
previously building the testsuites on the host).

This also copies additional scripts for preparation / clean up that may
be used in testenv.cfg. Use the --archive flag with rsync to ensure
that the executability is the same. I could have also used
--executability, but --archive contains two other existing flags and
more flags which may help us from running into unexpected situations
such as this one.

Without this patch, there was a bug when:
* first creating a shell script but not making it executable
* running testenv with podman (where rsync runs and creates the file
  initially without executable permissions)
* making the script executable
* running testenv with podman again, rsync will not adjust the
  permissions for the copy of the file
* user wonders why there is a "sh: 1: script.sh: Permission denied"
  error

Change-Id: Ia9737bd8ba22a555615862bf5e14dbdf0dea19b4

testenv/README: consistency fix

Add = after the vty_* keys too, like the others.

Change-Id: Ic9828b67f5a81498d0e951dd71b80b36cdd36173

testenv: podman.exec_cmd: better error if stopped

Testenv may try to run a comand in podman after the container was
stopped, if there is a bug in the shutdown logic. Give a meaningful
error in that case, instead of failing later on with a cryptic error in
subprocess.run() because None was passed inside cmd (for the container
name) instead of a string.

Change-Id: I29ebe200258a9a9ffb127ec8fa1260b7e2124c38

testenv/README: deduplicate clean= description

Change-Id: I12dc9adb508a409a6156f9682c9db5684f551b06

testenv/README: document current working dir

Change-Id: I218507bcbec94a36976fbf57d12ffd083fd2acfb

testenv: clean_run_scripts: skip if podman stopped

Do not attempt to run the clean_run_scripts, if podman is being used and
the container has already been shutdown.

Change-Id: I3cc05aabd97b73b65c3089e8806f7a9b32e5975c

testenv: copy=: support copying directories too

In preparation for adding the inital testenv.cfgs for ggsn, allow
copying full directories with copy= too. This will make the ggsn
testenv.cfg files easier to maintain.

Change-Id: I8e680fbd93516030614c015d7c3b5bdb153ec487

ggsn: sync GGSN_Tests.cfg with docker-playground

Add parameters that are missing from the config.

Change-Id: I16a8cbd77f52a1ca5c52c045b8d0932e681cc380

ggsn: add testenv.cfgs for osmo-ggsn

Change-Id: I941b859261c1fbf27360673f14f8a79f0cf6f509

ggsn: add testenv.cfg for open5gs

Change-Id: If11c0fcba84122d2398cb50208f161b9a3961df6

pcap-client: initial testenv.cfg

Change-Id: I44479dfa19390e325e42fa3416cf93260f74aea6

ruff.toml: new file

Add a file in the root dir of the repository to allow running
"ruff format" in order to auto-format the code with expected max line
length, PEP-8, etc.

Replace _testenv/pyproject.toml with .ruff.toml in the root directory of
the repository, so we can exclude "compare-results.py" which doesn't
follow that code style. Otherwise it would get formatted too when
running "ruff format" in the root dir of the repository.

Change-Id: I97ed1ececba85008ca754cf91bf46522e168a894

Cosmetic: testenv: fix line length

Run "ruff format", so there isn't a diff anymore when running it on
future patches.

Change-Id: I766a07c6d54d0da11ad47acce1fc07b4b3a4801b

testenv: improve --config argument parsing

* Support using wildcards for the config names via fnmatch as that makes
  it much easier to run the ggsn tests against all osmo-ggsn config
  variations, and update the examples in "testenv.py -h" to illustrate
  this.
* Fix that it didn't complain about an invalid --config argument, as
  long as there was a valid --config argument before it.
* Let raise_error_config_arg only output the invalid --config argument
  instead of all of them.
* Complain if "--config all" is used in combination with another
  --config argument.
* Sort testenv*.cfg files found alphabetically, so they are always
  executed in the same order.

Change-Id: I66b976b0332be523c084a6b5d38d0f62134b495d

ggsn: testenv: fix paths in copy= and clean=

I had moved osmo-ggsn related files to the osmo-ggsn directory and
forgot to adjust testenv_osmo_ggsn_{v4,v6,v4v6}_only.cfg. Fix it by
changing it like it is in testenv_osmo_ggsn_all.cfg

Change-Id: Ibc8aeb43ff594a6b26699f81b29abc31b9b5b71f

ggsn: testenv: add libosmocore-utils to package=

Add libosmocore-utils, so osmo-config-merge is installed when running
with --binary-repo too. The osmo-config-merge program is used in
osmo-ggsn/testenv.sh to merge the configs.

Change-Id: I7d97e0f923d928e9b51ff41d50b28706e0e6790b

library: add generic Mutex API for parallel components

In certain scenarios, it's required to ensure that only one of multiple
parallel components executes a specific code block at any given time.

This, for example, is the case for the S1GW testsuite, where we want to
simulate multiple eNBs establishing E-RABs.  Each new E-RAB triggers the
IUT (osmo-s1gw) to send a PFCP Session Establishment Request, and there
is no way for the PFCPEM to correlate which session belongs to which eNB.
This problem can be solved by ensuring that only one eNB is triggering
the PFCP Session Establishment Request(s) at a time.

This patch implements a generic Mutex API, which can also be used
by other testsuites that orchestrate multiple parallel components.

Change-Id: Id71f43bd5fc78d4bb4417d6c01fcff8112ea6032

library/PFCP_Emulation: a better PDU routing concept

In recently merged 2962d170 I wrongly assumed, that SEID of outgoing
PFCP PDUs can be used to correlate and route the incoming PDUs.  In
fact, the PFCP peers use two different SEID values, negotiating them
using the F-SEID IE.

We could have implemented a logic to look for F-SEID in the outgoing
PDUs, store and then use it for routing.  However, a more flexible
approach is to allow the the PFCP_ConnHdlr components to subscribe
and unsubscribe to/from specific SEID values explicitly.

In this spirit, let's allow the PFCP_ConnHdlr components to subscribe
and unsubscribe to/from broadcast PDUs (i.e. those, for which the
PFCPEM component could not find a single recipient) explicitly.

Implicit routing using the SeqNr remains unchanged and will be
performed by the PFCPEM component automatically like before.

Change-Id: I25802471519fa297ad4cb2b056adaa6748b00af2
Related: 2962d170 "library/PFCP_Emulation: fix routing of incoming PDUs"

library: as_pfcp_ignore(): log SeqNr of received PDUs

Printing the PFCP PDU template ('?' by default) is not very informative
when reading logs.  Printing the message type of the received PDU is
not informative either, because message types are defined as numbers
in PFCP_Types.ttcn.  Printing the whole PDU is way too verbose, and
would be redundant given that the PFCPEM component already does print
all received PDUs.  Let's print the sequence number.

Change-Id: I803ff46def4ae0182310bc01e753fe0c05112836

s1gw: f_init_pfcp(): use 'PFCPEM' as the prefix

Make it clear that it's the PFCP EMulation component.

Change-Id: Ia5413313cffb265f83ea0850e31dfb35274c28ba

s1gw: make number of eNBs configurable via module params

... so that we can scale the number of eNBs simulated in the
*_multi TCs without having to touch and compile code.

Change-Id: Ia80b9118e66a5d6721b89d3ba068227d30dcc01f

Revert "s1gw: cache PFCP Recovery Timestamp in ConnHdlr"

This reverts commit 7ad95e1cfb00d269069bd052c44a9cae9027f763.

A follow-up commit will remove the need for each ConnHdlr to call
f_ConnHdlr_register_pfcp(), that among with handling the PFCP
association retrieves a PFCP Recovery Timestamp from the PFCPEM.

Caching the PFCP Recovery Timestamp value is not really worth it,
since it's rarely used and can always be retrieved on demand.

Change-Id: I3b1c488e3ec251c7659cd9bc3197cca2f9d03144

s1gw: move PFCP association handling into a dedicated ConnHdlr

Previously, the PFCP association request from the IUT was handled by
the first ConnHdlr component (idx := 0).  While this approach has
worked, it fails when multiple ConnHdlr instances (idx > 0) are spawned.

The problem arises when other ConnHdlr (idx > 0) instances initiate
PFCP procedures before the first ConnHdlr (idx := 0) has established
the association, so we end up playing races.

This patch introduces a dedicated ConnHdlr component to handle the
PFCP association independently.  Once the association is established,
the actual test ConnHdlr instances are spawned, ensuring a more
reliable and orderly process.

Change-Id: I5e1a14105a35b785bf598dc2a8c436ea6fb6b0f1

s1gw: add multi-eNB variants of TC_e_rab_setup

The idea is to simulate multiple eNBs establishing one or more
E-RAB(s) simultaneously.  In order to achieve that, use the new
Mutex API to ensure that only one ConnHdlr component is triggering
PFCP session establishment at any given time.

The problem is that there is no way for the PFCPEM component to
correlate which PFCP session belongs to which eNB when multiple
ConnHdlr instances establish E-RAB(s) in parallel.  This can be
solved by making a part of the test scenario synchronous.

Change-Id: I9e2eb25a7ae78ff623b94802d881af4894d0cacd

s1gw: add f_ConnHdlrList_all_done()

Change-Id: I20c472dd8ce7f5a25c349cc079bd5bd873be2950

s1gw: f_ConnHdlr_rx_erab_release_cmd(): fix wrong template

Change-Id: Ib6b9f346216aaa9587025e1c580876611e6fa7bc

s1gw: add TC_e_rab_release_ind

Change-Id: Icc28a596b7646441761cc3f56653c5f7b3ddaaca

s1gw: f_ConnHdlr_erab_release_cmd(): add missing logging

Change-Id: I6e4574ebda2459f0a5f23ee51a21a883d079c54a

library/s1ap: fix wrong IE ID in E-RABReleaseListBearerRelComp

Change-Id: I22e80f418787c10ccd002e30a329c0271cdd1b8a
Fixes: e59e681c "library/s1ap: add E-RAB RELEASE templates"

library/s1ap: fix wrong field in S1AP-RABReleaseInd

Change-Id: I7a24b6401a19a6e37392083b26657bcb45b35cbe
Fixes: e59e681c "library/s1ap: add E-RAB RELEASE templates"

library/s1ap: add templates for INITIAL CONTEXT SETUP

Change-Id: I249e34ce91c874d4b6628d367672b58a77da041e

library/s1ap: fix wrong IDs in {ts,tr}_S1AP_InitialCtxSetupResp

Change-Id: I752f202e891f7f6ff4f8f33b56de90c99c4ab456
Fixes: ce818da5b "library: Add S1AP Templates"

library/s1ap: comment out optional IE in tr_S1AP_InitialCtxSetupResp

Change-Id: I4765036be69ff10adb8c510d4092834c4e923229

library/pfcp: fix template restriction in PFCP_Session_Est_Resp

Change-Id: Icf070443ffb7cfff84559db40459d0e9629ad024

library/pfcp: make Cause IE configurable in all templates

Change-Id: I76e52d3450cca87f5fead0f834fa58ce4902ddd8

s1gw: TC_e_rab_setup: complete E-RAB release

The MME originated E-RAB RELEASE procedure includes both:

* [ENB <- MME] E-RAB RELEASE COMMAND, and
* [ENB -> MME] E-RAB RELEASE RESPONSE.

The later was overlooked in a99224c9, so add it.

Change-Id: I856248d825b6ecf0635590b7bf02593cfae893d3
Fixes: a99224c9 "s1gw: TC_e_rab_setup: also test E-RAB release"

s1gw: separate f_ConnHdlr_session_{establish,modify}()

Change-Id: I95dc3be975a8f51f7535b96d1580ef70b85fa2e0

s1gw: add testcases for INITIAL CONTEXT SETUP

Change-Id: I72e3ab932fee1de0fce8ddf4041b8f2174416bc1

testenv: podman: disable send_redirects

When starting podman, set the following sysctls to avoid ICMP redirects.
ICMP redirects lead to test failures (TC_pdp4_clients_interact in the
GGSN testsuite), and should not be sent in the test environment in
general.

  net.ipv4.conf.all.send_redirects=0
  net.ipv4.conf.default.send_redirects=0

It is really needed to set both "all" and "default", or otherwise ICMP
redirects still show up. I've seen setting both in this patch:
https://patchwork.kernel.org/project/linux-kselftest/patch/1570719055-25110-4-git-send-email-yanhaishuang@cmss.chinamobile.com/

Fixes: OS#6575
Change-Id: Ie27668f38b80c52ffef4e17b3fe64f0c9109bdea

s1gw: add TC_initial_ctx_setup_failure

Change-Id: I969ea6813c9b805d116a974c70ab5f6e6e721e48

s1gw: move MME_UE_S1AP_ID to ConnHdlrPars

Change-Id: Idac24c54529073855f75bef7bcec87fc68b66e1e

testenv: requirements: find programs in /usr/sbin

Fix that testenv complains about a missing setcap program, if it is in
/usr/sbin/setcap and /usr/sbin is not in PATH as it is the case with
Debian. We actually run setcap with sudo when it is needed, and in that
case /usr/sbin gets added to PATH in Debian.

Fix for:
  [testenv] Missing program: setcap

Change-Id: Ibbccba013ac38415ef46467f97bef846b848cf39

testenv: podman: remove mongodb-org.list

Remove mongodb-org.list at the end of building the podman image, as we
only need to install mongodb once in the container but won't use the
repository afterwards. This avoids checking the mongodb repository in
"apt update".

Change-Id: I5a0455a4dbf8a31366bff65fd011fd5494b64ea7

testenv: podman: don't install GUI packages

Install erlang-nox and use the pre-built rebar3 as linked from
rebar3.org, instead of using the Debian package to avoid pulling in
~600 MB of GUI dependencies.

Related: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1083096
Change-Id: I27f58d1f102cf85ff7ff301c52696b65150e2898

ggsn: osmo-ggsn.src.cfg: tweak log output

* Print log levels.
* Don't print categories as hex.
* Print the basename at the end of the line.
* Remove "logging level lgtp debug", there already is
  "logging level lgtp info" further above, and this is a more sensible
  setting. With "debug" there are way too many log messages in e.g.
  TC_lots_of_concurrent_pdp_ctx.

Change-Id: I771d07645ea6da91f2c93f0954d99a37c866629a

ggsn: testenv: replace dummy netdev with bridge

Replace the dummy netdev that was used as network device reachable
through the GTP tunnel that can answer ICMP, with a bridge device. The
bridge device fulfils the same purpose, plus it can be used in a future
patch to connect osmo-ggsn when it is running in QEMU with the
testsuite.

Change-Id: I102d5b9ed0b3cafc263ad489ed4d4652f5e6dac8

testenv: osmo-dev: build with gtp_linux.opts

Run the osmo-ggsn ./configure with --enable-gtp-linux, in preparation
for testing kernel gtp-u with testenv too.

Related: https://gitea.osmocom.org/osmocom/osmo-dev/src/branch/master/gtp_linux.opts
Change-Id: Ia8ea5494597e0fedae93f501c8bc7d6115543f36

testenv: bridge: change default IPs 201 -> 1

During code review it was decided that we want to keep the 127.0.0.1
(and other 127.0.0.x) IPs in the configs, so one can start the testsuite
with osmo-ggsn directly on the host without using testenv scripts too,
with the same config.

The testenv script for osmo-ggsn will replace 127.0.0.x with 172.18.3.x
on the fly before the testsuite starts, so we can run osmo-ggsn
optionally in QEMU on 172.18.3.2, which will be bridged to the host.

172.18.3.1 will be used by the GGSN testsuite now, instead of
172.18.3.201 as previously planned, so change the default IP of the
bridge. The bridge is not used for another testsuite yet.

Add the 201 IPs as EXTRA_IPS for the non-QEMU case, as they are
configured as DNS IPs and tests need to be able to reach them.

Change-Id: Ied055e6e4d6214fd5247694e697a35a1e8ff1966

ggsn: testenv: run SUT on bridge instead of lo

Replace IPs in testenv.sh so the SUT runs on 172.18.3.2 (testenv0
bridge) instead of 127.0.0.2 (lo). Later on when we can optionally use
QEMU with osmo-ggsn to test kernel GTP-U. It will then run on this IP as
well. So with this change we can use the same IP for both the QEMU and
non-QEMU case.

Change-Id: Ib768603b0050fe62baff39cab982a850eb91f49a

ggsn: testenv: change VTY IP

Access the VTY of osmo-ggsn via 172.18.3.2 (127.0.0.2 if running without
testenv), so the testsuite can access the VTY when osmo-ggsn optionally
runs in QEMU too (through the bridge).

Change-Id: I054c19041b3027e7f66d925f031002fefe011c58

testenv: support running SUT in QEMU

Add two new arguments -C|--custom-kernel and -D|--debian-kernel. If any
of these is set, pass an environment variable TESTENV_QEMU_KERNEL with
the path to the kernel when running commands from testenv.cfg.

These commands can then source the new qemu_functions.sh and use it to
build an initramfs with the SUT and depending libraries on the fly, and
start up QEMU to boot right to starting the SUT. All of that takes about
~1s on my system with kvm. Without kvm ~5s.

A follow-up patch will adjust the ggsn testenv configs to optionally run
osmo-ggsn in QEMU for testing kernel GTP-U.

These scripts are based on scripts/kernel-tests from docker-playground.

Related: osmo-ci Id64a1a778fa38eec20498c36b390332f75d7d3f5
Change-Id: Ic9cb7092fd029b7ba530fc755b5d4d73a9d86350

ggsn: testenv: support running osmo-ggsn in QEMU

Run osmo-ggsn optionally in QEMU, to test the kernel GTP-U feature
with different kernels.

Related: OS#3208
Change-Id: I3f9db4325d5928c809cc99bc82d9cb82bf9e71eb

Cosmetic: ggsn: fix copy paste error

Change-Id: Iad2424036ff3dd45a9cd67f28249fbb06e657e62

L3_Templates: GMM: fix off-by-one error in ServiceType IE

The ServiceType IE is used in the GMM Service Request.

Change-Id: I79337fa31ffa82f766c6a1f238739c5e10773823

update osmo-stp.cfg to make STP_Tests work at all again

This syncs osmo-stp.cfg with changes introduced to docker-playground
in Change-Id I210b7d62845075dcfe147f2f77603625cc1e64f9 on March 4th.

I'm really getting tired at fixing up those kind of issues. It's
well-known that config changes must be made first here and then in
docker-playground.

Change-Id: I7f0cef55a9a54f1cc4b23df781dab2afd52aae78

Replace libosmo-sccp references with libosmo-sigtran

Change-Id: I8556a9eb4e111340e2415c5adf0ad91927ce53ec

_testenv: Avoid running make check when building IUT

In here we want to build stuff to run ttcn3 tests, not unit tests.

Change-Id: I1b5dd0947a1bd937775a74bceb88dcf3bbcf914b

stp: Support running with testenv

The osmo-stp.cfg was not up to date with the one further updated in
docker-playground.git.

Change-Id: I43fefc206fbc7f3a4fba9e4d4ba4386e5ca748f7

library/GTPv1U_Templates: support sending ext hdrs

Replace the seq (sequenceNumber) parameter in ts_GTP1U_PDU with
opt_part (GTPU_Header_optional_part). opt_part contains seq:

  type record GTPU_Header_optional_part {
    OCT2                       sequenceNumber,
    OCT1                       npduNumber,
    OCT1                       nextExtHeader,
    GTPU_ExtensionHeader_List  gTPU_extensionHeader_List optional
  }

With this change it is possible to set the extension headers too when
sending GTPU packets. This is in preparation for a GGSN test case with
extension headers.

Related: OS#6223
Change-Id: I5b1668d45f4454f92c234054678e17145bd4fe49

testenv: podman: restart_count in container_name

When running testsuites with multiple configurations in a row, as it is
the case with the ttcn3-ggsn jobs in jenkins, the podman container gets
restarted whenever switching to the next config.

Use a different name for each container by appending a restart count.
This should fix that podman sometimes didn't fully shutdown the
container yet and complains that the container name is already in use.
This happens even though we use "podman kill" and "podman wait" on the
previous container. When checking later, the container is really gone
and the same name can be used, it seems that it just needs some more
time to shutdown in some cases.

Fix for:
> Error: error creating container storage: the container name
> "testenv-ggsn_tests-osmo_ggsn_-osmocom-nightly-20241012-0752-2eb85125" is
> already in use by "8b7ea42371a922ffbf4e966b853124b98cd25c9905ae443fefb4115a103d7779".
> You have to remove that container to be able to reuse that name.: that name is already in use

Related: https://github.com/containers/podman/issues/2553
Related: https://jenkins.osmocom.org/jenkins/job/ttcn3-ggsn-test/2674/console
Change-Id: Ia791be2fee69765293ce7a7a058319c92bb92714

sgsn: Validate TLI received in RAB Ass Req

Related: OS#6508
Change-Id: I3a3699cea981caa89b30742c031d5f232418b0ee

sgsn: Test tx Rab Ass Resp with ITU X.213 IPv4 address format

Related: OS#6508
Related: SYS#7119
Change-Id: I38dd85f617600a974cbe8fd17597282eaf950a78

sgsn: Introduce test TC_attach_pdp_act_user_addr_itu_x213_ipv4toolarge

Related: OS#6508
Related: SYS#7119
Change-Id: Id2501e38565db491a6248552e754f03f7b973997

sgsn: Improve validation of TLA encoded in RAB Ass Req

Validate received TLA in RAB Ass Req according to confguration and test
expectancies.

Related: OS#6508
Related: SYS#7119
Change-Id: I725bf39c5564fb320954fc9e387ac569fc1a0136

cosmetic: sgsn: Fix indenation whitespace

Use tabs as done in all the file.

Change-Id: I8cb9283fee9d5a4ff5c34b9cde4d8fcce400343a

ggsn: README: document how to run with testenv

It is possible to run the GGSN testsuite in a lot of ways (as it was
ported from docker-playground, which had the same variations but with a
less consistent way of running them).

Document how it is typically run for development / in jenkins. This
should make it easier for users, in addition to testenv already telling
which configs are available if trying to run the ggsn testsuite without
the -c argument, and to the general help output in "./testenv.py run -h".

$ ./testenv.py run ggsn
[testenv] Using testsuite ggsn_tests (via alias ggsn)
[testenv] Found multiple testenv.cfg files:
[testenv]  * testenv_open5gs.cfg
[testenv]  * testenv_osmo_ggsn_all.cfg
[testenv]  * testenv_osmo_ggsn_v4_only.cfg
[testenv]  * testenv_osmo_ggsn_v4v6_only.cfg
[testenv]  * testenv_osmo_ggsn_v6_only.cfg
[testenv] Select a specific config (e.g. '-c open5gs') or all ('-c all')

Change-Id: I49421151b199fa6536da784b6c412b03f3fdbd05

library/GTPv1C_Templates: Lots of improvements in template declarations

Also most the compiler warnings are fixed, only some which require
special more complex attention are left as is.

Change-Id: I38a4b1c5874fda173a7b89122c84cb83ac71a036

cosmetic: library/GTPv1C_Templates: remove extra indentation level

The extra first indentation level around 99% of the file just loses
space which makes it difficult to keep templates at an acceptable width.
Do similarly to what we already do in lots of other template files which
were added later than this one.

Change-Id: I87755ec0a9023e79fb5f7a40c6c1734dca44696b

library/GTPv1C_Templates: Clean up PCO templates

* Define a generic ProtoElem template and use it everywhere.
* User superset instead of "*, tr_..., *" construct.

Change-Id: I005a6dea0606bcb677260f85b24396b55a150153

mgw: Remove unneeded dep IPCP_Types.ttcn

Change-Id: I318f4ba78adf778820e8d65d5932e454bc5da670

s1gw: Remove unneeded dep IPCP_Types.ttcn

Change-Id: Iad81c8d76efa2618ca7e354d2b73617a54a8d5ee

library: Move IPCP templates GTPv1C_Templates.ttcn -> IPCP_Templates.ttcn

We already have an IPCP_Types.ttcn, and the GTPv1C_Types from
ProtocolModules dep we use doesn't actually specify any record for IPCP,
so those are totally protocol independent.

Change-Id: I233292ea886e1b69a2f9aa1a159c816791b47136

library/PCO_Types: Drop unused nonsense enum

That enum is PAP related, plus it doesn't really match the section
describing, plus it's not used anywhere.
Looks like a development artifact which was not dropped during submit.

Change-Id: Ic791d20dd600b039daa2abef7fa25aaa6780a448

library/PCO_Types.ttcn: Drop unsued IPCP_OPT enum

It is unused, plus IPCP_Types.ttcn already defines a more complete enum
in IpcpConfigOptCode.

Change-Id: I867ab36063db262b46fc4546c17a902699a6e37c

ggsn: Introduce test TC_pdp4(6)_act_deact_mtu

This tests so far only test retrieval of MTU over PCO, which is only
used for IPv4 APNs.
When IPv6 is in used, it is expected to be retrieved over IPv6 SLAAC RA.
Such tests will be done in a follow-up patch once the related procedure
is implemented in osmo-ggsn.

Related: OS#6298
Related: SYS#7122
Change-Id: I2ceb76a3a07b44f69937c9f5a040482320bca377

ggsn: Validate MTU sent during ICMPv6 RA

Related: OS#6298
Related: SYS#7122
Change-Id: Ia5bbc5f9e42b02d1b9bd6c4190a2bd439663deeb

ggsn: Request osmo-ggsn to apply the MTU on the tundev

Depends: osmo-ggsn.git Change-Id Ifae556169d895860812c9ea5633292d7e3fab338
Related: OS#6298
Related: SYS#7122
Change-Id: Ie55c8b41f5a4a128f999474c3fad1926099b3624

ctrl: tweak errmsg for counter mismatch

- instead of "-1", print "not present", so humans know what is
  happening.
- the comma separated args in setverdict() create a lot of weird quotes.
  Use string concatenation to have only one set of quotes around the
  entire error message.

Related: OS#6545
Tweaked-by: Oliver Smith <osmith@sysmocom.de>
Change-Id: I672fcef819a6542a5b3bcfa0a6d9c84d34b468f3

testenv: qemu: get coredump and show backtrace

If the SUT crashes inside QEMU, copy the coredump via 9p to the outer
system (either host or podman) where we have the same binaries and also
debug symbols, and run gdb there to show the backtrace.

Related: OS#6600
Change-Id: Ia08ac58c43388b5ea4d3712c5ef83f54b538b10a

pcu: add testenv.cfg

Change-Id: I57956a0bb5d5e164c3f840815573164e52300459

bsc/osmo-bsc-sccplite.cfg: add trx1, trx2

Synchronize with the config in docker-playground.

Change-Id: Ia959c725b9efee5ccf6a67e22e740a60b4fd28b9

bsc/osmo-bsc{,-vamos}.cfg: add no missing-msc-text

Copy this option from the config in docker-playground to have less
cluttered output.

Change-Id: I0735e5bce207961ab960294c9f39404ab64a3fb1

bsc/osmo-stp.cfg: sync with docker-playground

Change-Id: I32fc1374d92405d642027e0c61fdd6a297cd7807

bsc: add testenv.cfg

Change-Id: Ib2e92a9ebd78f5553161bcca433f39c7c39f3adf

testenv: improve output for missing -c argument

When a testsuite has multiple testenv.cfg files, the user needs to
explicitly choose a config, or "-c all" for all configs. Improve the
help output to directly print the arguments that need to be passed,
instead of printing the config file names. Mention that wildcards can be
used too.

Old:
  [testenv] Found multiple testenv.cfg files:
  [testenv]  * testenv_generic.cfg
  [testenv]  * testenv_sccplite.cfg
  [testenv]  * testenv_vamos.cfg
  [testenv] Select a specific config (e.g. '-c generic') or all ('-c all')

New:
  [testenv] Found multiple testenv.cfg files, use one of:
  [testenv]  -c generic
  [testenv]  -c sccplite
  [testenv]  -c vamos
  [testenv] You can also select all of them (-c all) or use the * character as wildcard.

Related: OS#6494
Change-Id: I3f273caff702b33d3d74a9e5c8d77b22f27d7cfc

testenv: osmo-dev: add hint for gen_makefile fail

When gen_makefile.py from osmo-dev fails, it is likely that the osmo-dev
git clone is outdated, for example if a new file with configure options
was added to osmo-dev.git and is now being used by testenv. Display a
hint for pulling this repository to the user.

Change-Id: Ia9ed23fa910876252093054f5f389865632c7593

hnbgw: Support testenv

Change-Id: Id2bcc4e13881db01b8e4d9f1738355b8d779fa63

testenv: remove dead code for [testsuite] prepare=

Remove some WIP code that I intended to use for enabling the mongodb
repository before installing binary packages, to be able to dynamically
install mongodb from there. I solved it differently by just always
having mongodb in the podman image.

This was a dead code path because configs with prepare= in [testsuite]
are currently not valid, and therefore testenv refuses to use these
configs (see keys_valid_testsuite in testenv_cfg.py's verify()).

I have a different use case for running prepare= before running the
testsuite, to replace a module parameter in the testsuite's config. This
will be done in the next patch.

Change-Id: I9bed48612fad690f86017c298372dc6cea22b94b

testenv: add proper [testsuite] prepare= support

Support using prepare= in the [testsuite] section to e.g. change module
parameters:

  [testsuite]
  prepare=sed -i 's/mp_my_parameter := false/mp_my_parameter := true/' Testsuite.cfg

Move the execution time of prepare and clean scripts in
testdir.prepare() after the testsuite config has been copied to the
testdir, so it can be modified by the prepare script.

Change-Id: Ia78a4eba061e5e070f156f75eae1dfa4cede1ee3

hnbgw: Split ConnHdlr component code to its own file

Similar to what we do in most of the testsuites, split Component generic
code from test specific code.

Change-Id: I3a58c27a7472eea2421a45c31ac0145eb57a1f7e

RAN_Emulation: Introduce field ranap_connect_ind_auto_res

This field allows skipping automatic response of the connect_ind, hence
allowing ConnHdlr to totally skip it, delay it, or generate a CREF by
means of sending RAN_Conn_Prim:MSC_CONN_PRIM_DISC_REQ to RAN_Emulation,
as per ITU Q.711 Figure 8.

Change-Id: I5a69990e3a0839dd3c25c7dc66e6bcf66123fbff

hnbgw: Allow modifying RanOps during test startup

This will be used by a test to skip response to CONNECT.ind, allowing
transmission of DISCONNECT.req and hence transmitting CREF over the
wire.

Change-Id: Ib9462ba41b16375348b086d7ffe9f5755ae26f84

Convert RAN_Conn_Prim from enum to union

This will allow passing parameters in each primitive.
This is needed eg. to pass the reason in DISCONNECT.req.

Change-Id: I17994795b51efc7e6700238ddcf45594af653e42

RAN_Emulation: Allow setting reason in primitive MSC_CONN_PRIM_DISC_REQ

This allows setting a specific reason in the CREF transmitted on the
wire, other than "End user originted (0)".
A follow-up commit will add a test in HNBGW_Tests where an emulated MSC
answers with CREF reason "End user failure (0x02)".

Change-Id: I1fa1148135625d840426b52450bf52da10448471

hnbgw: Fix TC_ranap_ps_mo_disconnect testing CS instead of PS

Change-Id: I16a446a9de0a40f37a4af0bf54bcf0bd49b2d47f

hnbgw: Drop unused template

Change-Id: I7dfce4485a6eaeabcdf1755619509b4b0f2bff65

hnbgw: Introduce test TC_ranap_{cs,ps}_creq_cref

Related: SYS#6602
Change-Id: I0313ea741feca90492e25f0adc1c04844a860e41

hnbgw: Set sccp_addr parameters during init

Those will be needed by other tests using UNITDATA primitives to send
RANAP ResetResourceAck.

Change-Id: I53f7e2e0a4622bb25667053b0b80e743e5f493bd

hbngw: Store IuSigConid in ConnHdlr params

A follow-up patch will want to use the value to register it in order to
get RANAP ResetResource messages.

Change-Id: I7eb5716debcad8427c15341612d37152ca894e5a

RANAP_Templates: Add templates for ResetResource(Ack)

Change-Id: If6357c19b39ef63057a2d8d471975185f0161b22

RAN_Emulation: Support registering IuSigConId for connectionless RANAP messages

This allows dispatching received RANAP connectionless (UNITDATA)
messages which target potentially existing connections identified by
IuSigConId, like RANAP Reset Resource (Ack) messages.
Dispatching it to relevant ConnHdlrs allows explicitly waiting to
receive the message and answer from there.

Change-Id: I6a00a425ce52cb0c71b03b545207f27befa11a71

s1gw: use the new counter name (out_pkt.forward.unmodified)

Change-Id: I037fea187bb78ba0d4b82d30915c5270d4cd28bb
Related: osmo-s1gw.git I952e198238384dca4be94f91a01d7cfff0a1471f

RUA_Emulation: Support passing no RANAP PDU in RUA_Disc_Req

Change-Id: Id9c3d5a1e45aa6ca58a71b61e142dc041a335cc9

hnbgw: Add missing timer stop after use

Change-Id: I2c722f524de603b75f2b7c6ba85d074518d1f51c

hnbgw: Get rid of pars param in void_fn

Store pars into component field "g_pars" before caling void_fn.
This simplifies ConnHdlr test functions and also avoids potential
problems modifying pars vs g_pars.
This is the same as we do in lots of other testsuites.

Change-Id: I674b2a6a6a0e39f2904f9125783180da8ade5f44

testenv: run podman command with logfile

In very rare cases it seems podman is just crashing with no reason in
jenkins. Add logging to the main script we run inside podman, and run
podman with a logfile attached to figure out why.

Related: OS#6607
Change-Id: Ife3c0ae559c94f7df8b5912bb0e338ae6283cb7f

library/s1ap: fix wrong IE criticality in templates

Related sections in 3GPP TS 36.413:

* 9.1.3.2 E-RAB SETUP RESPONSE
* 9.1.3.6 E-RAB RELEASE RESPONSE

Change-Id: I3fd9efc4c504037758b3d97e920776123f2141e9
Related: SYS#6772

library/s1ap: rework {ts,tr}_S1AP_RABSetupRsp templates

3GPP TS 36.413, section 9.1.3.2 "E-RAB SETUP RESPONSE" defines
the following two IEs as optional:

* E-RAB Setup List IE: 0..1 in the Range column means that
  it can either be omitted (0) or included only once (1);
* E-RAB Failed to Setup List: 'O' in the Presence column.

Our templates for this S1AP PDU require the former to be a value
(as if it was mandatory) and do not allow passing the later.

Change-Id: Ic369ae720179483a19383af2bddf56186965eae3
Related: SYS#6772

s1gw: add TC_e_rab_setup_failure

Change-Id: I97102292678e732265dcae04d60f7a708a5246dc
Related: osmo-s1gw.git I242e84fb09b00f4794b6e1aa770f348a0e60aea4
Related: SYS#6772

hnbgw: test for RUA Disconnect when there is no CN

Related: OS#6283
Related: osmo-hnbgw Iafb30c31a4c5db53ecdda99a0e0b5937b71e362c
Tweaked-by: Oliver Smith <osmith@sysmocom.de>
Change-Id: I2b5c024a395e736538c0c37db40d34f3b8d99991

hnbgw: Send meaningful RANAP messages in f_tc_ranap_mo_disconnect()

Fix the code to send the messages that were fore sure intended, where an
MO disconnect is triggered.
This allows attaching more to reality, plus making it easier to follow
up the test in wireshark and in the code.

Change-Id: I9a2bb35d58c6cdda312638103ef5c3c2f5661e62

hnbgw: Introduce test TC_cs_iu_release_req_rua_disconnect

Related: SYS#6602
Change-Id: I6782920c4a86d3311eb54239ab13a18e393c1ec0

hnbgw: fixup for expect_compl_l3_success

During my rebase of Neels patch, I've missed setting
expect_compl_l3_success in t_pars(), leading to:

  HNBGW_Tests.ttcn:571 Dynamic test case error: Text encoder: Encoding an unbound boolean value.

For a lot of tests. Also add the parameter to f_TestHdlrParams() for
consistency.

Fixes: 25fc127c ("hnbgw: test for RUA Disconnect when there is no CN")
Change-Id: Idbfcb77a80d74f7715ef1f84ba4cbfdb08483a5c

hnbgw: Rename RAB helper functions to be CS specific

Change-Id: If8a97fe847083e95a480006d147ff59be695b713

hnbgw: Use g_pars.mgcp_pars directly during RAB CS setup

Change-Id: I1f699e197e29f912ad06378f10563063aa291af3

hnbgw/expected-results: update

Add:
* TC_hnb_disconnected_timeout
* TC_mscpool_L3Compl_no_cn
* TC_sgsnpool_L3Compl_no_cn

Fixes: 25fc127c ("hnbgw: test for RUA Disconnect when there is no CN")
Change-Id: Ib126ff53aa9edfeb94f5e7e058145bd4fbe7b604

testenv: make podman stop more robust

Terminate the watchdog process before killing the podman container. This
avoids bogus errors from a race condition where the container gets
killed first, and then the watchdog process tries to feed the watchdog
and fails:

  [testenv] Stopping podman container
  [testenv] + ['podman', 'kill', 'testenv-hnbgw-all-osmocom-latest-20241031-1222-f34534a5-1']
  e41700779a8ca5daf18ac5daa27d59a84d8442196e352f2756a19baf0592cf89
  Error: no container with name or ID testenv-hnbgw-all-osmocom-latest-20241031-1222-f34534a5-1 found: no such container
  [testenv] podman container crashed!

While at it, use "check=False" with the "podman kill" command, so we
avoid additional error messages if the container was already killed at
that point (could happen through a bug). If we fail to kill it here, it
is not a problem because the watchdog will ensure it terminates shortly
after the watchdog process was stopped.

Related: OS#6607
Change-Id: I6c67273af5b6a80ae0c94e14cb92e3784807c21d

hnbgw: Move gtp_pars to Connhdlr

Change-Id: I40f723256b592d0d9141dfd192a1623a4804b4ea

hnbgw: Introduce PfcpParameters in TestHdlrParameters

This allows creating generic functions to establish PS RABs based on
test setup configuration.

Change-Id: I5de50bb7032891a073e4e4e25b2dc86bc84e3d60

bsc: testenv: set MTU=1500 for lo

Two tests are failing if the MTU is 65536 instead of 1500. This is an
upstream bug in titan.TestPorts.SCTPasp:
https://gitlab.eclipse.org/eclipse/titan/titan.TestPorts.SCTPasp/-/issues/3

Add a workaround so the behavior of the test environment is the same as
with docker-playground and the tests can pass again.

Related: OS#6602
Change-Id: Ifeda66954263fe8d2637377d0701a2208a19c332

hnbgw: Merge TC_ps_rab_assignment_* testcases

Change-Id: Ibfc3a7d74494bd78d8cfb4efa535ab4cd1b07cae

hnbgw: Move normal condition Iu Release procedure to helper function

Change-Id: I5dc7923b78d1b98fea1f71aa6e39c41f70b1f3e6

hnbgw: Tear down SCCP conn from CN under normal conditions

Specs mention that under normal conditions the CN is the one expected to
tear down the SCCP underlaying connection upon recieving
Iu-ReleaseComplete.

Change-Id: I920cabcb63ca352db0ed06e4c35dade52bae5399

testenv: fix 'container crashed' detection

* When the testsuite stopped and using podman, check if it stopped
  because the container crashed and raise an exception.

* Even after 9eb5e696 ("testenv: make podman stop more robust") it
  happens sometimes in jenkins that the container gets stopped on
  purpose because the testsuite is done, but then the watchdog process
  prints an error saying it crashed (without actually stopping testenv
  at this point). Change the message to a debug message that just says
  it stopped, this should not be an error.

Related: OS#6607
Change-Id: I3c116719cdc00a99e27e5237ba3d57d5258b0919

testenv: podman-main: set watchdog timer to 60s

Increase the timer from 10s to 60s, as with 10s I see jobs failing with:

  ERROR: /tmp/watchdog was not created, exiting

In theory 10s should already be enough, my guess is that if a jenkins
node is currently under a lot of load then the feed command may take
several seconds and so we hit the previous timer. Even if this is not
the cause, I think it is good to rule it out.

Exiting after 60s if the jenkins job was (manually / with connection
loss) aborted is still relatively quick.

Related: OS#6607
Change-Id: Ide7a9d5bc395106cdaa47cec3aa746a978674c9e

statsd: Support f_statsd_snapshot() API when using VTY-triggered stats report

Until now that API was only used in testsuites which relied on
time-trigerred reports. This commit also supports getting a given
snapshots if the IUT is configured to only trigger a report based on VTY
request.

Change-Id: I87d34e2f365d3b71ce328c08999be43d482326ad

hnbgw: Introduce module parameter mp_statsd_prefix

The value in that parameter depends on IUT configuration.

Change-Id: I007d45b8323831e8f3708d22c6a9bc6e9badd896

hnbgw: Introduce module parameter mp_pfcp_upf_node_id

This will allow using it later in HNBGW_Tests.ttcn file when waiting for
PFCP Assoc Req.

Change-Id: I2142289965adba0b457e865e10f0cfc9908b0bb2

hnbgw: Handle PFCP Assoc Setup procedure in test_CT

Handle PFCP Assoc Setup Req during PFCP initialization in main test_CT.
This simplifies test logic.

Depends: osmo-hnbgw.git Change-Id Ic71df8df83e97f4015077677e426c803f84d31ea
Change-Id: Ic5edecea86b9465c60f008e245a44cfce64c8ddb

hnbgw: Introduce test TC_ps_iu_release_req_rua_disconnect

Change-Id: Id24a5aed5255af77fbbd30521be70700a9bff1c9

testenv: show testsuite results at the end

Show the testsuite results from junit-*.log not after each testenv*.cfg
file is through, but for all of them at the end. This way the results
are in one place when running with multiple configs, we don't need to
scroll to the middle of the huge log to find out what tests passed with
a previous config.

Adjust the podman container stop and restart logic, so the last
container is still running until we use it for showing the results.

Change-Id: Ie4b70724a33932cd98ba0972db37bf72dc8affb8

testenv: more tweaks for container shutdown logic

* Don't do "podman wait" when restarting the container. The idea was to
  really wait before the current container was shutdown before
  restarting one with the same name. But even with the wait we got "the
  container name ... is already in use" errors and so we use different
  names when restarting the container since 6fe837de ("testenv: podman:
  restart_count in container_name"). This means "podman wait" is not
  needed anymore.

* feed_watchdog_loop: change sleep from 5s to 2s, as we wait up to that
  long after the container was shutdown, before testenv stops. 5s is
  quite noticable compared to 2s when running the script locally.

* feed_watchdog_loop: hide stderr of "podman exec" since it will print
  "Error: container ... does not exist in database: no such container"
  during shutdown. This is expected as we stop the container, but it
  looks like an actual error. We already have a more userfriendly
  message "feed_watchdog_loop: podman container has stopped" that will
  appear when the "podman exec" fails during shutdown.

Change-Id: I71721fd41f044817e4021aea045a288f88506f76

hnbgw: Parametrize UPF F-SEID

This is needed if we want to support several concurrent PFCP sessions.

Change-Id: I8c32998c839f75ed93de639e48d08e1458a8032c

hlr: use :memory: (volatile in-memory database)

This eliminates hlr.db* files and reduces chances of failures
due to unclean state database when running TCs more than once.

Change-Id: Ibb34a555e999693f00d12b49f936a20105f21c43

hlr: refactor f_SS_expect()

Prepare for follow-up patches reworking SS related GSUP templates.
Avoid passing "omit" for parameter 'ss' of the receive templates
because this will no longer work as expected.  Clean up code flow.

Change-Id: I162a79e3c7ff9dafb031e3da8a78af313534cac7

library/gsup: improve formatting of SS templates

Change-Id: I27aa67ded044a4a5362795bb791d883c4af55cd9

library/gsup: improve generic GSUP_PDU templates

* Fix tr_GSUP: 'ies' cannot be omitted, so use '?' (not '*')
* Add missing template restrictions ('value' / 'present')
* Move GSUP_PDU templates after GSUP_IE templates

Change-Id: If4ceaf60311f9e4ed57153e2f6d7cb793c637f89

hnbgw: with-pfcp: Support running ConnHdlr concurrently

Use Mutex to serialize PFCP session establishment to workaround the
"Req with SEID=0" dispatching problem.
This same system is used in S1GW_Tests.

Change-Id: Ie19ee0bd1b811e9381e3c245a4b1208de8afcbce

RAN_Emulation: Increase ExpecTable size to 16

Use same size as other tables.
This allow running HNBGW_Tests with 16 ConnHdlrs instead of 8.

Change-Id: I0748da523d886a8097b9f35991b9044e6ca33f95

hnbgw: Add test TC_ps_rab_assignment_concurrent

Related: SYS#6602
Change-Id: I053950373cec93ed8dbdfd6b8a71ffe31de3806f

hnbgw: Parametrize MgcpParameters MGCP endpoint

This will be needed if we want to run several CS RAB ConnHdlrs in
parallel.

Change-Id: I4bb28dea22a6ea5b415d6ca16bde61b835d435bc

hnbgw: mgcp: Support running CS RAB ConnHdlr concurrently

Use Mutex to serialize CRCX wildcard endpoint, in order to be able
to properly steer the message to the good ConnHdlr.

Change-Id: Ibd97a37d98abfa746b58db0ea8bb591e7c8dc638

hnbgw: Introduce test TC_rab_assignment_concurrent

Related: SYS#6602
Change-Id: I1f717edbe4a758288d017861c4b77836c5811040

RUA_Emulation: Add missing msg component destination

Seen while running lots of components concurrently:
"RUA_Emulation.ttcn:315 Dynamic test case error: Port CLIENT has more
than one active connections. Message can be sent on it only with
explicit addressing."

Change-Id: Ief257969a451f2d11ad7619fb97af16d7dd7e199

hnbgw: Small fixes in f_tc_rab_assignment()

Change-Id: I2f21d3ed59f6b8d26cfee3bd8e75c63cc9d710a3

deps: Update titan.ProtocolEmulations.SCCP to upstream master

Until now we were using our own fork with an extra patch with a fix for
SCCP conn id 0.
This patch, together with other patches was merged upstream today.
Hence, update our dependency to point to current upstream master.

Related: OS#6185
Change-Id: I8ba6cec24205337f19bac951d9a8d4f5d4d476ad

osmo-*.cfg: enable gsmtap log

Now that jenkins uses the osmo-*.cfg files from osmo-ttcn3-hacks for the
testsuites that were ported to testenv, make sure that these configs
enable logging to gsmtap log as it was the case in docker-playground.
This gives useful additional context in the pcap files.

Change-Id: I8a1c734c0d34b81e70707b0ac6732a366b867bbe

library/gsup: improve GSUP_IE templates

* Turn template params into templates
* Use proper template restrictions
* Remove unnecessary valueof()s
* Improve formatting

Change-Id: I67cc555a54113dccb11d0cc05cee66f5c2d795fe

library/gsup: rework f_gen_{tr,ts}_ss_ies() and SS templates

* Add missing param restrictions to SS related templates.
* f_gen_{tr,ts}_ss_ies(): proper template param restrictions.
* f_gen_ts_ss_ies(): return a template, not a value.
* f_gen_ts_ss_ies(): append IEs using list index.
* f_gen_ts_ss_ies(): isvalue() -> istemplatekind()
                     to allow passing template lists.
* f_gen_tr_ss_ies(): istemplatekind() -> ispresent()
                     to allow passing template lists.
* f_gen_tr_ss_ies(): 'omit' -> '*' for optional params.

Change-Id: Ia611ffa3845d48c5553c70f10981aa029d00d873

library/gsup: add src/dst name IEs to all SS templates

This enables us to send/match OSMO_GSUP_{SOURCE,DESTINATION}_NAME
IEs (if needed) and brings consistency to all SS related templates.

This patch makes the following testcases pass [again]:

* TC_mt_ussd_for_unknown_subscr,
* TC_proc_ss_for_unknown_session.

At some point osmo-msc started including the Source Name IE in
OSMO_GSUP_MSGT_PROC_SS_ERROR messages, which we didn't expect.

Change-Id: I8d947313a99491d2e4790bc06db863fe09d8b5cf

library/rsl: rename t_RSL_IE_ActType_* -> c_RSL_IE_ActType_*

We use prefix 't_' for templates and prefix 'c_' for constants.

Change-Id: I4ae8f6c35f6f823060833f24a0cad41cc9894750

msc: use :memory: for SMS (volatile in-memory database)

This eliminates sms.db* files and reduces chances of failures
due to unclean state database when running TCs more than once.

Change-Id: I0361284e41f84f43d96b9ce10da88fc9a089cdd4

hlr: expected-results.xml: expect TC_MSLookup_* to pass

These TCs are passing on Jenkins for quite some time.

Change-Id: I254f3a8a97d0602d46c3975315e21f87850bfa05

{epdg,msc,pgw}/expected-results.xml: sync with Jenkins

Change-Id: Id00d9f95f81c1fdd181e56ed838f4b450accca58

bts: use proper ActType in f_TC_data_rtp_loopback()

For the sake of correctness, use c_RSL_IE_ActType_ASS (assignment)
when activating TCH/[FH] channels in TC_data_rtp_*.  This is the
kind of ActType that would normally be used by the BSC.

Change-Id: Ide773c3fcfdab881756d5fe5b6c314b0c0335043

bts: TC_data_rtp_tchh*: fix timeslot number in comments

Change-Id: I771e616d52315a26679acb1be17cd4f36eaa52b2

bts: add TC_data_facch_*: test FACCH/[FH] on data channels

So far we have been testing the actual traffic on TCH/[FH] in data
mode (CSD), but not FACCH/[FH].  Add separate testcases for that.

Half-rate variants of the new testcases crash osmo-bts-trx, so
comment them out in the control section until the problem is fixed.

Change-Id: I2098ccd651fc2a81f62e70be64af386ab0ca6148
Related: OS#6618

bsc: Fix sporadic failure in .TC_ho_in_fail_ipa_crcx_timeout

The code path was not waiting to receive DLCX if parameter
ignore_mgw_mdcx was set to false. It should wait for DLCX in any case.

Since it didn't wait, te ConnHdlr would finish earlier than expected and
MGCP_Emulation would fail when forwarding the DLCX to ConnHdlr:
"""
MGCP_Emulation.ttcn:257 Dynamic test case error: Sending data on the connection of port MGCP_CLIENT to 2023:MGCP failed. (Broken pipe)
"""

Change-Id: I322b070c369500979e3cc13814de1e4bf067726f

epdg: fix a DTE in as_GSUP_rx_CL_REQ

Recent commit 51490419 uncovered a problem of passing 'dom := *'
to tr_GSUP_CL_REQ, which calls f_gen_tr_ies(), which in its turn
does not properly handle the '*' template kind:

'''
  Dynamic test case error: Restriction `present' on template
                           of type @GSUP_Types.GSUP_CnDomain violated.
'''

The old code was basically equivalent of passing 'dom := ?',
i.e. expecting the OSMO_GSUP_CN_DOMAIN_IE to be present.

Work the problem around by having two alternatives:

* GSUP.receive(tr_GSUP_CL_REQ(dom := omit)
* GSUP.receive(tr_GSUP_CL_REQ(dom := ?)

This patch makes TC_hss_initiated_deregister_permanent_termination pass.

Change-Id: I26738c8c2a0a4b9066bfb619149cbdbaf3e3b5e1
Related: 51490419 ("library/gsup: improve GSUP_IE templates")

testenv: add run --until-nok

Add an argument to run a specific test (if using --test) or a whole
testsuite until it fails with "failure" or "error". This helped me in
reproducing a race condition in the mgw testsuite (related issue).

Related: OS#3849
Change-Id: I17e1ebcc5d6ff1b6a087c4d4c9405a02798212f1

mgw: fix RTP packets received while RX disabled

Fix the race condition causing tests to abort with:
  1 RTP packets received while RX was disabled

Fixes: OS#3849
Change-Id: Ieaf5440a693448cdeeaac7f47e6110cb480bff5f

testenv: make it pass 'ruff check' linter

I've added 'ruff check' to my pre-commit script. Make it pass initially,
so it can detect future bugs. The missing f-string is a bug that causes
ggsn testsuites with a custom kernel path to not work.

Change-Id: I3e5cd05ce0aa241509d77391c5ed64e618f385ba

testenv: install dbg pkgs with --binary-repo too

When using --binary-repo, figure out the -dbg and -dbgsym packages for
all dependencies of packages to be installed, and install them as well.

This will make debug symbols available in jenkins, useful for the
related issue. Before this patch debug symbols were only available when
building locally without --binary-repo.

Related: OS#6630
Change-Id: I4dc57257b944126fed2c7b031c92c77a3d4286e0

testenv: pass env var for --binary-repo

Pass TESTENV_BINARY_REPO=1 to the podman container if the --binary-repo
argument is set. This will be used for the BTS testsuite to figure out
from where we need to run fake-trx.

Change-Id: Ia88906147e2e579145e3c8d04090c58f533febd5

bts/run_fake_trx.sh: tweak cd logic

Don't test if FAKE_TRX_DIR is empty, because it is never empty at that
point. If it was empty, then the line above would assign a default
value.

Change-Id: I63f9720487b564de5c5609eb52a6bb9d5a8aa74f

testenv: respawn.sh: don't respawn on segfault

Do not respawn the process if it segfaulted or aborted abnormally in
another way (exit code >= 128).

Change-Id: I6f3f6218095643609a8b8869b57dde6b6bdb77a0

testenv: print backtrace on startup fail too

When a program fails to start up, look for the coredump and print a
backtrace if it was found (instead of only doing it if a program
crashes later on).

Change-Id: I66a55dcfdab17d035ce6425220763a85b5b6dc90

testenv: build virtphy from src with --binary-repo

Add logic to build virtphy from source when running with --binary-repo.
This extra code path is needed because we currently don't have virtphy
packaged (like trxcon and sccp_demo_user), and we need to build the
libosmocore binary package instead of building completely from source as
we would do it with osmo-dev.

Use ".split(" ", 1)[0]" on the program= value to only look at its first
word, so we can later on use it in testenv.cfg file as follows:

  [virtphy]
  program=virtphy -s /tmp/osmocom_l2

Change-Id: I37bac8509b2601286e4feab099782f82c8338dca

bts: add initial testenv.cfg

As usually, imported from docker-playground and adjusted to run on the
loopback device.

Related: OS#6638
Change-Id: Id9ed3780d166c5f6736a006f466dc5f0dded6279

L3_Templates: GMM: Attach Req/RAU Req: add TLVs required for 4G -> 2G mobility tests

Change-Id: I0a37b75f6b1a522868cdbff43d99d4b953a4e952

L3_Templates: RAU Request: add support for MS Network Capability

The MS Network Capability is important to determine the UMTS auth capability
as well the R99 support.

Change-Id: Id750c84ae1673ac33c98cecea035805e8cb92bcb

L3_Templates: set R99 indicator

To support UMTS AKA auth, set the R99 indicator

Change-Id: I80035c68bd43fac336ef74ca9377a21f1061167f

L3_Templates: Add required TLVs for RA Request when moving from 4G to 2G

Add ts_PtmsiTypeTV and ts_RoutingAreaIdentification2TLV

Change-Id: I6d735be76aab0b5228502e3e19804bcc98864829

L3_Templates: correct set a5 bits to A1 + A5

The MS Radio Capabilities must include A5 bits to inform the network
of supported encryption capabilities. The a5bits of the first access network
must be present, later ones can be omited, meaning the ones of the first one
also applies.

Change-Id: I5256c1a2c57761589ec51de4fba47fa48b1f3fbb

Osmocom_CTRL_Functions.ttcn: Use Misc_Helpers.f_shutdown() everywhere

Change-Id: I3b11a4dee35da89b2fec0cc66021dd57db04beb4

deps/Makefile: update titan.ProtocolModules.RTP

The module titan.ProtocolModules.RTP received a fix that avoids crashing
(segfault) on the reception of short RTP packets. Let's make sure that
this fix is included in our builds as well.

Related: OS#4005
Change-Id: Ica445c1058f3afa1e0615986ca5240eeacb02e8c

hnbgw: TC_rab_release: Fix race condition stats checked too early

It could happen sometimes that the stats report was requested before the
hnbgw received the message increasing the counter.

Change-Id: Ica53d956ee8aed760854d3148af170144234e6b2

bsc: Fix missing teardown in TC_ho_in_fail_msc_clears_after_ho_detect

Missing handling of teardown messages made the test fail sporadically
due to ttcn3 side already closing the SCCP connection when it was still
expected to receive messages.

Change-Id: I492607aca0e42a823836f4a714ea818c5a897855

msc: fix a race condition in f_mt_call_establish()

It can happen that the MSC sends a paging request quicker than
function f_ran_register_imsi() returns (e.g. when a node executing
the testsuite is under significant load).  In this case the
BSSMAP PAGING message is dropped by the RAN_Emulation CT:

  CommonBssmapUnitdataCallback: IMSI/TMSI not found in table

This can be avoided by calling f_ran_register_imsi() *before*
sending the MNCC SETUP.req, which is triggering paging.

This patch fixes sporadic failures of:

* TC_lu_and_mt_call
* TC_lu_and_mt_call_ipv6
* TC_lu_and_mt_call_no_dlcx_resp

Change-Id: Ie8b69c3b59ea61e01adb24c71c1376335a5ddde6

bsc: osmo-bsc.cfg: Listen IPA Abis and CTRL interfaces on 127.0.0.1

CTRL seems to bind to 127.0.0.1 by default, but IPA Abis listents to
0.0.0.0 by default, which is not needed and may create problems with
concurrent instances.

Change-Id: I56c8c6af16502e8f98b28902a251e190da0c0490

bsc: Add missing testcase in expected-results.xml

Change-Id: I6416e5cf4c12912f5094841d3738302bbd6228bb

PCU_Tests_SNS: del/change weight: don't fail on NS

When doing a SNS procedure, ignore NS Alive which are already in the queue or happen direct after.

Related: OS#6611
Change-Id: I8088bd8f3b3e37ee79f61e73d2a3e4f73d00c5c1

tr_GTPC_SGSNContextReq: use the same template as MsgType

Change-Id: Idd546c3ec387e9c3ea8f1b1a61cf8ca8230db46a

SGSN: BSSGP_ConnHdlr: GMM Service Request: handle PMM IDLE UE correct

24.008: 4.7.13.3: explicitly mention the completion of the low layer security to be an implicit
Security Command Accept if the UE is in PMM Idle.
Extend the as_service_request() to handle both cases when UE is in PMM-IDLE as well in
PMM-CONNECTED.

Change-Id: I29237997e414aea80f254247da54f909410a4b36

SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect authentication

On a Service Request, the authentication is optional.
Either an authentication must happen or the key material from the previous authentication
has to be used.
The default behavior is still the same.

Change-Id: I9ed08160bf5413e3a30d6e90eb947d4d799e1058

SGSN: BSSGP_ConnHdlr: f_gmm_attach(): allow the SGSN to request the IMEI

The IMEI might be requested when the GMM Attach happen.

Change-Id: Id49c9e6ef7517a6a831315ac1f9915c50b88beb6

SGSN: f_TC_attach_timeout_after_pdp_act: allow authentication

While testing, allow the SGSN to authenticate the UE.
The new VLR code will authenticate the UE, while
the old code doesn't.

Change-Id: I11c628ecebbe7c4c1b2c28e63133a33cfc171e12

SGSN: f_TC_attach_rau: do a periodic RA update instead of RA change

After an attach, the periodic RA would be the correct.

Change-Id: Ic33687c55915d883b6d9a9a0d640a11588e1d1a0

SGSN: TC_attach_auth_id_timeout: set TMSI to provoke a ID Request

This test case simulates a MS which ignores Identity Requests. To ensure
the SGSN will ask for the IMSI, do an Attach Request with id TMSI.
Later this ID Request (type IMSI) will be ignored and the test case
expect a Attach Reject.

Change-Id: I5a860582aa57ebc073e4c33f3f2f8884e360edef

SGSN: f_TC_hlr_location_cancel_request_withdraw: drop incorrect Update Location response

This PDU was a Copy/Paste mistake and never been expected or used. The SGSN ignored
this message.

Change-Id: Ib8265416c650b0983d7e85786b334f84191331b2

SGSN: f_TC_paging_ps: call f_gmm_attach() direct

Instead of using the TC function, call f_gmm_attach() direct.
Also set explicit the verdict at the end.

Change-Id: I68c75f84b01a0cd673ffd8c19ab5f0a8517c5738

SGSN: f_TC_cell_change_different_*: always expect the auth

The new SGSN will always ask for authentication when receiving Attach or RA
which is the correct behaviour as long the LLC layer doesn't indicate
integrity or encryption protection.

Change-Id: I24579b5fc843caf68e035e106cee4e4ec0a3c735

SGSN: fix encoding of IMEISV in Auth and Ciphering Response

According to 24.008 the IMEISV field is exact 11 bytes long and
must contain a IMEI + SV which is exact 16 digits long, not 15.

Change-Id: I79dd79840de58f450c1a05e704fd9bd831455716

SGSN: TC_attach_pdp_act_pmm_idle: use correct Service Request type

When the UE requests data service, it must use the data service request type.

Change-Id: I9301e7a37d96c3f93e77f7618d6c13dfa1fbe46b

SGSN: Context Req In: use correct TEID-C

For a MS/UE moving from 2G to 4G, the Ctx Acks need to transmit
with the correct TEID-C which the SGSN chose in the Context Response.

Change-Id: I84dc7dda8ee1227edd68d1482a4c5bf267c16418

SGSN: assign random TEID-C to Context Req/Resp/Ack messages

Change-Id: Icac28280a810e8d24eeeaaae1fb1a15278fde8da

SGSN: Remove mm context triplets

Only triplets which hasn't been used should be included.
The MME will only request and sent back a single set of tuples.
There shouldn't any left overs.

Change-Id: I60a3331396cb9905ec9a4df9b1e65a3291a51058

testenv: use new osmocom-bb binary packages

When using --binary-packages, use the osmocom-bb-trxcon etc. binary
packages that are now available, instead of only installing the
dependencies as binary packages and building these components from
source.

Change-Id: I072ea55d12060b4ef04ee9775ef116d553090e9a

SGSN_Tests: f_TC_attach_usim_resync: fix IMEISV value

IMEISV is IMEI + 2 digit software version.

Change-Id: I044eeccd02e2d3f891879516f5a9c003ac8f849a

PCU_Tests_SNS: SNS Add: handle NS_Alive while waiting for SNS_Ack

Similiar to 61ccea9ecadc ("PCU_Tests_SNS: del/change weight: don't fail on NS"),
the SNS Add procedure might have to handle a NS Alive PDU in the receiving queue while waiting
for a SNS ACK.

Related: OS#6611
Change-Id: I10646d9acfe280ddfb8852a4d5c37882aae99874

testenv: make copy= more intuitive

Currently copy= in testenv.cfg creates copies of files under the full
source file name under the target directory: copy=dir/file.cfg creates
dir/file.cfg (like "cp -a --parents"). This is not very intuitive,
change it to create a "file.cfg" instead without subdirectory. With
this change, it behaves the same as "cp -a".

Suggested-by: Pau Espin Pedrol <pespin@sysmocom.de>
Change-Id: Id9e4ea066d0a0e72ccd83e4f6f887f382bf61e46

remsim: Add initial testenv

"server" testsuite is working as goos as in docker-playground.git
"bankd" testsuite is currently failing due to bankd exiting early after
starting.
"client" is not currently working/running in docker-playground, initial
config copied here for completeness.

This commit hence allows already quickly running "server" testsuite.

Change-Id: Ic69a04342a4cdfced90cf8ffbe7e5cdede8d4b8e

RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack

When adding a new NS-VC via SNS Add, the SNS Ack should
only contains the IEs "List of IP4/6 elements" if the cause code is
Unknown IP endpoint.

However the libosmocore/ns2 code isn't following this behavior yet.

Change-Id: I18c659e43db79400c1b428ed745267a5e6e59102

RAW_NS: SNS Changeweight: remove IPv4/IPv6 element in SNS Ack

When changweights of a NS-VC via SNS, the SNS Ack should
only contains the IEs "List of IP4/6 elements" if the cause code is
Unknown IP endpoint.

However the libosmocore/ns2 code isn't following this behavior yet.

Change-Id: Ibf00cbab0c6691cdb72fe592ee30e122dd8f4783

PCUIF: fix usage of bts number in PCUIF_TXT_IND

When we receive the PCU_VERSION using tr_PCUIF_TXT_IND we must ignore the
included BTS number because the PCU_VERSION is not addressed to a specific
BTS. When we send a PCU_VERSION using ts_PCUIF_TXT_IND, we should always
use the bts number 0 to be consistent (the BSC/BTS will ignore this number
anyway).

Let's fix the usage of tr_PCUIF_TXT_IND and put comments, to make clear why
the above applies.

Change-Id: I93de261fc77806b2f817e0d30cb1b0d377ed0dbb
related: OS#6507

RAN_Emulation: Allow client to trigger SCCP CC if automatic CC was disabled

This allows users of RAN_Emulation to trigger events in between CR
transmited and CC being receied at the IUT.

Change-Id: I117c8fde118b488b011e381d51eed378d2f3ff0e

hnbgw: Introduce test TC_{cs,ps}_rua_disconnect_during_sccp_cr_cc

Related: SYS#7208
Change-Id: Ie4fe4aaf77017f7191cf000331e452cded56cf25

hnbgw: Fix template restriction in template param

Change-Id: I946f21f6d662d889095199c268d2586aea55c821

testenv: Log return code of unexpected end of process

This providing further information, for instance if the process actually
exited due to a signal (rc < 0) or due to exiting on its own (rc >= 0).

While at it, rewrite the log line since a process exiting doesn't
necessarily mean it crashed.

Change-Id: I7bbee6ad8e114eeb1ef348184158230b53d0f3cf

remsim: Enable debug output of bankd

Change-Id: Idc1ed4b9419735170cac92916073757da01691ed

remsim: bankd: Install vsmartcard-vpcd

This is needed for test RemsimBankd_Tests.TC_createMapping_exchangeTPDU
to work. Add require_vsmartcard_vpcd.sh to give a meaningful error
message when running without --podman, if the user doesn't have it
installed.

Co-authored-by: Oliver Smith <osmith@sysmocom.de>
Change-Id: Ib5ba5075eff4955354fa25d1c605f277e8a6962a

sccp: Initial testenv

Change-Id: I616425d729dda342e78537c6b7256d5dddebaa88

sccp: Let some time for SCCP RLC to reach IUT before finishing test

Otherwise tear down of the test component immediatelly afterwards
creates a race condition where sometimes the RLC message is not sent
before closing the socket.
As a result, the SCCP-SCOC stays in DISCONN_PEND until T(rel) fires a
while afterwards, generating a new RLSD in a follow-up test, disrupting
expectancies of that unrelated test.

Since sccp_demo_user doesn't implement a Layer Manager, the recv() 0
from the socket doesn't automatically tear down the SCCP conn, since it
could have several ASPs:
"""
0: asp-asp-srv-client: ss7_asp_xua_srv_conn_rx_cb(): sctp_recvmsg() returned 0 (flags=0x80)
...
asp-srv-client: connection closed
XUA_ASP(asp-srv-client){ASP_ACTIVE}: Received Event SCTP-COMM_DOWN.ind
XUA_ASP(asp-srv-client){ASP_ACTIVE}: state_chg to ASP_DOWN
XUA_AS(as-srv-client){AS_ACTIVE}: Received Event ASPAS-ASP_DOWN.ind
XUA_AS(as-srv-client){AS_ACTIVE}: state_chg to AS_PENDING
Delivering N-PCSTATE.indication to SCCP User 'SCCP Management'
Ignoring SCCP user primitive N-PCSTATE.indication
[Here same 2 lines for SCCP User 'refuser', 'echo', 'callback', 'test_client_vty']
XUA_ASP(asp-srv-client){ASP_DOWN}: No Layer Manager, dropping M-ASP_DOWN.indication
XUA_ASP(asp-srv-client){ASP_DOWN}: No Layer Manager, dropping M-SCTP_RELEASE.indication
"""

Change-Id: Id7d5970bb0fe0e42fedcb56fe4a738a92ddd5bbf

library/s1ap: f_tr_S1AP_RABSetupRsp(): use ispresent()

Change-Id: I6ee1246ef9f32ac7d5ce107d3ba9ea11ed87af20

library/s1ap: add E-RAB MODIFY REQ/RSP templates

Change-Id: Id38cd51698c1388311a41f045ff08ec7f8a85146

library/s1ap: add E-RAB MODIFY IND/CNF templates

Change-Id: I2dd3d420ebfaf37fefa1d33a40176ec57fee5619

s1gw: make f_ConnHdlr_rx_session_modify_req() more flexible

Allow the caller to pass FAR ID, SEID, and E-RAB parameters (F-TEID),
so that it can also be used for testing the E-RAB MODIFY procedure.

Change-Id: I52317e79ac02cb4e321b49c2cd824de28e25a1c6

s1gw: add constants for PFCP FAR IDs

Change-Id: Ib25e5cc9ca21047f9884e1c13d0861bf4f7251a1

mgw: Improve log and teardown upon unexpected mgcp resp received

Change-Id: I233075f5a88ed7f1f7de496664cdc7281aefa900

PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits

After removing a NS-VC via SNS-DEL, the NS-VC shouldn't receive
any further NS PDUs.

Related: OS#6611
Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f

GSUP_Templates: Purge MS Request: allow the Message class IE to be present

Change-Id: I367f63fe5286e39ba51de94729455d2638f19c6f

SGSN: f_cellid_to_RAI: fix spaces vs tabs

Change-Id: Ic1927729dd0d205f1bd866423c8dfdf91caf597d

msc: add testenv.cfg

Change-Id: Ia93115e3a27ac43b6530f2669e210f59169d75b9

stp: Improve failure teardown using Misc_Helpers.f_shutdown

Change-Id: I776bc32b1bdb52d7e90102c4ab6ff7b0ef7a12c6

stp: set up all M3UA ports in array in steps

This way we have all ports in more or less the same state when handling
messages.
It should also speed up tests and mitigate sporadic failures  under some
scenarios where we already accept the SCTP conn instead of rejecting it
and waiting for reconnect from client.

Change-Id: I585d9c768301bfd9ba849876923787137fc35981

gbproxy: Don't log the payload size for every DL/UL-UNITDATA

This just wastes memory. We can check the pcaps if a test does fail.

Change-Id: I862d67a48f1d694262cf39a1e939033bde0c6eab
Related: OS#6704

testenv: run: add --autoreconf-in-src-copy arg

Add a new argument that avoids the problem that ./configure refuses to
run if it has already been executed in the source dir. (It aborts and
asks the user to run "make distclean" first, which is especially
annoying if it has to be done in multiple source dirs before being able
to build successfully.)

Put the new logic behind an "experimental argument" for now. I think it
improves usability greatly and plan to make it the default later when
it has been well tested.

I have also considered making the source dir read-only when mounted into
podman and this argument is set. This was the original goal of Lynxis'
related patch, on which idea this one is based. But osmo-dev still
needs to write into the source dir in case it clones a new repository,
so making the sources dir read-only with this trade-off should be a
separate flag and could be added in another patch later.

Related: osmo-ttcn3-hacks I0f1ac8852218f158ece14c176f05574f60d9d1f7
Depends: osmo-dev I18ac50e3441df81e1fe7d8d5321df7e80ab9c650
Change-Id: I5c38ce69dc39823d12be574c74a654d2fa6ed8fb

library/s1ap: fix criticality in UE CONTEXT RELEASE PDUs

Change-Id: I6c63b3ecb428b54705aea0c14610c00223651d8f
Related: SYS#7310

s1gw: add f_TC_exec()

The idea is to reduce the amount of boilerplate code.

Change-Id: I0df4ad15bc2dca2afb2c598c1b053f45b69c181b

s1gw: add TCs for UE CONTEXT RELEASE procedures

Change-Id: I065692f311e9d03630ab3ca2f6a03465418f0e71
Related: osmo-s1gw.git Ic94489e3d3052221b49431da3a95e5c1eb0e0ba0
Related: SYS#7310

hnbgw: Use Misc_Helpers.f_shutdown upon rx of unexpected msg

Otherwise the test continues for a while and ends up with a DTE which
makes it harder to figure out the original test failure.

Change-Id: I7f07cff2ce93e8b11338ba4e39e1d49662323f58

MGCP_Emulation: Make sure peer is running before Tx

This avoid DTE with "Broken pipe" if messages are being transmitted
while tear down process has already started, even if components are
created as "alive".

Change-Id: I8724870b9b967ffa49c3da03e1cdb2941f81653a

hnbgw: Submit proper L3 PDUs during CR

Generating random PDU values makes hnbgw act on it, since it looks up
higher layers to figure out NRI steering.

Change-Id: I725c35a3584b7d2d162c24ab2b662cfb80e539d7
Related: OS#6717

Mutex: Create component alive

Change-Id: Ie2980705dd0d2d8ed11a6c13349fb85e6f254748

RAN_Adapter: Create components alive

HNBGW_Tests.TC_hnb_disconnected_timeout needs modification since it
expects the component to drop the underlaying conn towards the IUT when
the component is stopped. This is not longer the case when the component
is created as "alive". In order to make sure its resources are
destroyed, one needs to kill it.

Change-Id: Ice4d93b42552f1c5d621582b1fc3a38b4e1ae837

hnbgw: Create all components alive

This makes it easier to figure out errors due to getting rid of DTEs
changing the result output of the test.

Change-Id: If7ef1897adf3ef819314aa094ba78c526d77770f

pcu: Fix wrong BSN uint size

3GPP TS 44.060 9.1.4.2, BSN is 11 bit long.

Change-Id: Id1ef8b58dc61ab91de2c781a2fd1e8da5eba83a7

pcu: Fix TC_dl_cs1_to_cs4 sporadic fail

The test TC_dl_cs1_to_cs4 failed sporadically in ttcn3-pcu-test-asan.
Due to how the DL data arriving at Gb is split in chunks over RLC/MAC
(also based on how CS changes over time), it may happen that the full
PDU content doesn't finish at the exact block number where PCU expects
the DL ACK/NACK. As a result, since PCU delays finishing the DL TBF and
some data for that DL TBF has already not been ACKed (and since there's
no more active DL TBFs), it will decide to retransmit some of the
RLC/MAC blocks which haven't been yet ACKed, instead of transmitting
nothing.
This is an optimization to increase the probabilities the MS has
received all the data.
We need to account for this possibility in f_dl_data_exp_cs(), used in
the mentioned test. In there, it needs to be checked whether the
received DL data block is a retransmission, and use that knowledge to
resolve that all data has been transmitted and hence the final condition
can be checked.

Change-Id: I7fb40689547645adf1d54f43c263161be1d7a440

pcu: Fix dummy DL block received due to timer race conditions

Timer X2002, which manages delay at PCU between sending DL TBF Ass over
CCCH and start transmitting for it over PDCH, is clock-time based.
As a result, timer at PCU process and ttcn3 process may time out
slightly differently. Hence, it can happen that we request a DL block
immediatelly *before* the timer triggers at the PCU. In that scenario,
PCU transmits a dummy block instead of a data block.
Account for this race condition in several tests; some tests already
used this formula.

Change-Id: Ic2bb953483cd1f678cbe32c7a94e177f79ecb4e4

s1gw: f_ConnHdlr_session_delete(): invalidate peer's SEID

Change-Id: If8027e2bdb5822eb7555cd02a72be900a1f18880

s1gw: f_ConnHdlr_session_delete(): respect any order

It's not guranteed (nor required) that PFCP Session Deletion Request
PDUs are sent in the same order as their respective ERab records are
organized in the given ERabList.  They can be emitted in any order.

Make f_ConnHdlr_session_delete() more flexible:

* Expect to receive N PFCP Session Deletion Request PDUs;
* For each received PFCP PDU, find the matching E-RAB;
* Make sure that an E-RAB is never released twice;
* Send PFCP Session Deletion Response.

This patch fixes the following TCs:

* TC_ue_ctx_release_req3
* TC_ue_ctx_release_cmd_compl3

Change-Id: I93d3d38829b1f425d18d59464894da239e3511eb
Related: 75cb01b7 ("s1gw: add TCs for UE CONTEXT RELEASE procedures")
Related: SYS#7310

s1gw: add TC_e_rab_modify_req_rsp[_multi]

Test the E-RAB Modify procedure (MME initiated), which is defined
in 3GPP TS 36.413 section 8.2.2.

Change-Id: I58b9964bae24b5aac526ee0c0c8ac8798f351e05
Related: osmo-s1gw.git I24d57ea390d71b640cb42046a8658e9d30670682
Related: osmo-s1gw.git I057a1c58d0c6ad04c00ad3ea4c68230d8632a07e
Related: SYS#7308