Skip to content
[Jenkins]Jenkins
log insign up
Success

Changes

Summary

  1. ES2Plus_Tests: fix typo (details)
  2. smdpp_Tests: move module parameter up (details)
  3. ES2Plus_Tests: remove unused module parameter (details)
  4. ES2Plus_Tests: remove obvious comment (details)
  5. ES2Plus_Tests: move [TESTPORT_PARAMETERS] up (details)
  6. smdpp_Tests.cfg: remove unused testport parameters (details)
  7. ES2Plus_Tests: improve error messages when setting verdict in (details)
  8. ES2Plus_Tests: add "es2plus" prefix to module parameter (details)
  9. ES2Plus_Tests: rename mp_es2plus_server_host to _fqdn (details)
  10. ES2Plus_Tests.cfg: remove unhelpful comment (details)
  11. ES2Plus_Tests.cfg: comment out parameters in config file. (details)
  12. smdpp_Tests.cfg: comment out parameters in config file. (details)
Commit 69b97580ad341325c7fc9b7f56e021716e85b4bc by pmaier@sysmocom.de
ES2Plus_Tests: fix typo

Related: SYS#7339
Change-Id: I510a879042977b6ef1cd19e5a66fceeefa42e0c1
The file was modifiedsmdpp/ES2Plus_Tests.ttcn
Commit 69436b686e2b44b32a123b7e178a6cfbf5d810b0 by pmaier@sysmocom.de
smdpp_Tests: move module parameter up

The module parameters are somewhere in the middle of the module
code. Let's put them to the top to make it easier to find them.

Change-Id: I8d0fae934e48eb55d78bfa904be064c2613930a8
Related: SYS#7339
The file was modifiedsmdpp/smdpp_Tests.ttcn
Commit ee64f2b2e9a992d9abb815a4b33ffbbd2b53689b by pmaier@sysmocom.de
ES2Plus_Tests: remove unused module parameter

Change-Id: I98921155d74209ffe97d6981a1d65a4424ef918c
Related: SYS#7339
The file was modifiedsmdpp/ES2Plus_Tests.ttcn
Commit f51ac6c9bf722e27c441874ceb3f412662eb4f9d by pmaier@sysmocom.de
ES2Plus_Tests: remove obvious comment

Change-Id: I30564ecd89f32ea1830ef1f3bbfcddc4b3f585c4
Related: SYS#7339
The file was modifiedsmdpp/ES2Plus_Tests.cfg
Commit 0d18b1474cd9035c51311a27555d7e35b6c1c5eb by pmaier@sysmocom.de
ES2Plus_Tests: move [TESTPORT_PARAMETERS] up

We normally have the [TESTPORT_PARAMETERS] right below [LOGGING]

Change-Id: If0d5ba0dc8d5b1f07215d6ac8c02a36253c200f6
Related: SYS#7339
The file was modifiedsmdpp/ES2Plus_Tests.cfg
Commit 2192ca5739b12f3c4ab8706879c365384a7b64c1 by pmaier@sysmocom.de
smdpp_Tests.cfg: remove unused testport parameters

The testsuite uses a custom libcurl based sublayer that handles all
the HTTP related tasks. Let's remove the HTTP_server_port related
testport parameters.

Change-Id: If58675f4243250381d407722c52e8e2384aa4f22
Related: SYS#7339
The file was modifiedsmdpp/smdpp_Tests.cfg
Commit 306b3fe83db32cb39d05b5705ea87425738d76a0 by pmaier@sysmocom.de
ES2Plus_Tests: improve error messages when setting verdict in f_init_es2plus

It is not enough to say something has failed, it is also important
to say what exactly and what for.

Related: SYS#7339
Change-Id: I1a4aa85e3b1950eae0f910a14a95afa8e16c9cf6
The file was modifiedsmdpp/ES2Plus_Tests.ttcn
Commit ba646adb63590612af4483b056433ff688b54f0e by pmaier@sysmocom.de
ES2Plus_Tests: add "es2plus" prefix to module parameter

Let's prefix the module parameters to make it easier to understand
their purpose.

Related: SYS#7339
Change-Id: Idda9f287177cb1dce66bbef410bb1b7085f55b4d
The file was modifiedsmdpp/ES2Plus_Tests.ttcn
The file was modifiedsmdpp/ES2Plus_Tests.cfg
Commit f57ff17f118e54b8bf3dd6c0476af102ecbb245e by pmaier@sysmocom.de
ES2Plus_Tests: rename mp_es2plus_server_host to _fqdn

Let's rename the module parameter mp_es2plus_server_host to
mp_es2plus_server_fqdn. The reason for this is that the suffix "host"
suggests that one may use an arbitrary hostname or IP address. In
this case this is in fact not true. The FQDN must match the hostname
of the SSL server certificate. Apart from that GSMA SGP.22 always
uses the word "FQDN" in their specs.

Change-Id: Idedfcce4d013c32f43307e159c45854a1e6a049b
Related: SYS#7339
The file was modifiedsmdpp/ES2Plus_Tests.ttcn
The file was modifiedsmdpp/ES2Plus_Tests.cfg
Commit d5eaa025010141a2cea6b6d991b8cbf4630e87b0 by pmaier@sysmocom.de
ES2Plus_Tests.cfg: remove unhelpful comment

There is no benefit for the user from this comment. The port number
also is often a custom parameter that depends on the actual setup.

Change-Id: Ic7b2d9d665feee211d6dedcf9068a6ce3c993aaf
Related: SYS#7339
The file was modifiedsmdpp/ES2Plus_Tests.cfg
Commit 3c9e73f7f5199170acbeb1144f2536634b4ca53e by pmaier@sysmocom.de
ES2Plus_Tests.cfg: comment out parameters in config file.

The code in ES2Plus_Tests.ttcn already provides safe defaults, so we
do not have to repeat those defaults again in ES2Plus_Tests.cfg.

So let's comment out the parameters. This way we kenn keep them for
illustrative purposes, so that users can use the config file as a
helpful template for the most basic settings.

Related: SYS#7339
Change-Id: I5677222305d847ba3ac1cdafecdc942ece80aa8c
The file was modifiedsmdpp/ES2Plus_Tests.cfg
Commit 4393e61dd0d37ebfd279f5ca10fbcdf16286bfcb by pmaier@sysmocom.de
smdpp_Tests.cfg: comment out parameters in config file.

The code in smdpp_Tests.ttcn already provides safe defaults, so we
do not have to repeat those defaults again in smdpp_Tests.cfg.

So let's comment out the parameters. This way we kenn keep them for
illustrative purposes, so that users can use the config file as a
helpful template for the most basic settings.

Related: SYS#7339
Change-Id: I981b683da0312799c2e5b24ac57cd838b071f955
The file was modifiedsmdpp/smdpp_Tests.cfg