Commit
7e04d7535551bd5f8445b8af78fab60c941e5d4b
by Oliver Smith
scripts/osmotestconfig: fail with trace on 1st err
Make it easier to figure out why osmotestconfig failed, by failing on the first error instead of running multiple tests and displaying a failed error count at the end. Raise an error on failure, so we get a python trace.
Commit
6c6254aaa0a26c89bda0a810b47ccf34ee6cef85
by Oliver Smith
scripts/osmotestconfig: rmtree: no ignore_errors
Do not ignore errors with shutil.rmtree(). The script expects to be able to delete the directory, otherwise it will fail later on. So this hides the original error and leads to a more confusing error later on.
Commit
ecabb5d1597b9646433e4e946b3543e2846949f1
by Oliver Smith
scripts/osmotestconfig: copy_config: no copytree
In Osmocom git repositories, we have doc/example directories (possibly with subdirectories), which contain nothing but *.cfg files.
For these directories, the code I'm removing had no effect: it would copy the whole directory tree of a directory containaing *.cfg files, but for some reason ignore the *.cfg files. I guess we had a previous directory structure before, where this made more sense. So essential it is a mkdir, but this is also not needed since we do a mkdir just below this.
Furthermore this code caused problems for the related osmo-sgsn patch, where a *.cfg file is stored in the tests/ dir, because it has to be slightly different than the file from doc/example. In this case, the code would actually copy various files, such as Makefile.am, from the tests directory. This causes problems in "make distcheck", because then the file permissions are set so that these files cannot removed without first changing the permissions again. So osmotestconfig.py fails when it runs copy_config for the second time, trying to remove the temporary directory.