Skip to content
[Jenkins]Jenkins
log insign up
Success

Changes

Summary

  1. Drop internal use of osmocom/abis/ipaccess.h (details)
  2. ipaccess: Assert explicitly about non-null ptr (details)
  3. ipaccess: Assert fd is positive (details)
Commit 0a1d912f1a957292b7dc1763503d5594c2c6d8e1 by Pau Espin Pedrol
Drop internal use of osmocom/abis/ipaccess.h

That header is only really used to provide an old hack for
ipaccess-proxy tool in openbsc.h/osmo-bsc.h, and will be deprecated
soon.

Take the chance to organize a bit better the includes based on dependency
chain.

Change-Id: Ifc9759b17a9b966cb713f7533a13f6223161a4cd
The file was modifiedsrc/input/ipaccess.c
The file was modifiedtests/e1inp_ipa_bts_test.c
The file was modifiedsrc/input/ipa.c
The file was modifiedsrc/ipa_proxy.c
Commit c0d1ec98a37e4a5ddbd067a6c978810a951e62a2 by Pau Espin Pedrol
ipaccess: Assert explicitly about non-null ptr

Make coverity happy. Those pointers can never be NULL due to related
logic of e1i_ts_has_pending_tx_msgs() and e1inp_tx_ts().

Closes: Coverity CID#435269
Change-Id: Ifc79899bba787f08cc83206b0a53b04b66861c7b
The file was modifiedsrc/input/ipaccess.c
Commit 5c5fce84ee36f7ff8ee5a22bbbcc586ae4e75d08 by Pau Espin Pedrol
ipaccess: Assert fd is positive

Make coverity happy. We are in a rx path from socket, so socket should
be fine at that point.

Closes: Coverity CID#435266
Change-Id: I09004040107fb72b6170618a6253a6225f4351c2
The file was modifiedsrc/input/ipaccess.c