Skip to content
Success

Changes

Summary

  1. cosmetic: tcap: Fix wrong msgb ownership documentation (details)
  2. tcap: Forbid tcap-routing in ASP mode (details)
  3. vty: Forbid deleting ASP currently configured in an AS (details)
  4. tests/vty: Run ss7_asp_test.vty (details)
Commit cb6f1d65989ff5cb7bb733a1b9b732cf0cd64fef by Pau Espin Pedrol
cosmetic: tcap: Fix wrong msgb ownership documentation

Caller of the function, ipa_rx_msg(), already specifies the ownesrship
is kept by its callers, ss7_asp_ipa_srv_conn_rx_cb() and ipa_cli_read_cb().

Change-Id: Idfda2c2eda8a8490d8306a364eccf96ebc15b7a4
The file was modifiedsrc/tcap_as_loadshare.c
Commit 8c8f72910aefb31ae1aa3f72d9ead4e82cafda65 by Pau Espin Pedrol
tcap: Forbid tcap-routing in ASP mode

The tcap-routing feature is only expected to be used so far by osmo-stp,
which runs in SG role. Disable it for programs running under ASP role.

Change-Id: I4ccfa9ae06c756dd6626045a8e9f14ae79bcfa34
The file was modifiedsrc/ss7_as_vty.c
The file was modifiedsrc/tcap_as_loadshare.c
Commit 314cfc3c93c878a5208b1e669f1fc21fc0679aa8 by Pau Espin Pedrol
vty: Forbid deleting ASP currently configured in an AS

Make the user first remove the ASP from the AS manually.

Change-Id: I3eed65b4a33b786e7dde6e86774c56655523aea2
The file was modifiedtests/vty/osmo_stp_test.vty
The file was modifiedsrc/ss7_asp_vty.c
Commit 74d074b31df5e3ddcc595fa95aa0eb1f8ffe12be by Pau Espin Pedrol
tests/vty: Run ss7_asp_test.vty

Old commit enabled running vty tests for libosmo-sigtran in SG mode, but
prevented running the existing ones in ASP mode. Re-enable them (and
update the vty output to up to date expectations).

Fixes: d3e69b874971441071663a2457773dac77b579ae
Change-Id: Ibcb0c589e6bdf692fa82361deedeb82169c09270
The file was modifiedtests/vty/ss7_asp_test.vty
The file was modifiedtests/vty/Makefile.am