Skip to content

Changes

Summary

  1. esim.saip: Add ProfileElementSequence.remove_naas_of_type (details)
  2. pySim.tlv: Correctly parse COMPREHENSION-TLV without comprehension bit (details)
  3. pySim.cat: Make sure to always set comprehension bit in COMPR_TLV_IE (details)
  4. pySim.tlv.COMPR_TLV_IE: Patch comprehension bit if derived class misses (details)
  5. jenkins.sh: Include es9p_client in pylint (details)
  6. add contrib/saip-tool.py (details)
  7. pySim.cat: Add more alredy-defined IEs to ProactiveCmd classes (details)
  8. pySim/ota: Don't modify input argument in OtaDialectSms.encode_cmd (details)
  9. pySim.ota.OtaDialectSms: Move SMS header construct up to class level (details)
  10. pySim.ota.OtaDialectSms: Implement command decoding (details)
  11. tests/ota_test.py: Allow stand-alone execution (details)
  12. osmo-smdpp: use NIST-P256 by default (details)
  13. unber.py: work-around pylint reporting (possibly-used-before-assignment) (details)
  14. contrib/jenkins.sh: Execute pylint also on all contrib python scripts (details)
Commit 4680503acccab89531d014adb498f2865d30afa0 by laforge
esim.saip: Add ProfileElementSequence.remove_naas_of_type

This method allows the caller to remove all NAAs of a certain type,
for example to remove all CSIM instances from a given profile.

Change-Id: I64438bf0be58bad7a561c3744b7e9b1338a7857c
The file was modified pySim/esim/saip/__init__.py
The file was modified pySim/esim/saip/oid.py
Commit 144bae3f37333cd30f1479d67d7e10641f76f46e by laforge
pySim.tlv: Correctly parse COMPREHENSION-TLV without comprehension bit

The uppermost bit of COMPREHENSION-TLV tags indicates whether the
recipient is required to "comprehend" that IE or not. So every IE
actually has two tag values: one with and one without that bit set.

As all our existing TLV definitions of COMPR_TLV_IE have that bit set,
let's assume this is the default, but use the same definition also for
the situation where that bit is not set.

Change-Id: I58d04ec13be0c12d9fb8cb3d5a0480d0defb6c95
The file was modified pySim/tlv.py
Commit 05349a0c65d571eeaf7dca84e394ed9c2ee01265 by laforge
pySim.cat: Make sure to always set comprehension bit in COMPR_TLV_IE

our implementation currently assumes that all derived classes are
created with a tag value that has the comprehension bit set.

Change-Id: I6e5f2a69c960c03015c3f233f8fbc2a7a802f07e
The file was modified pySim/cat.py
Commit cdf661b24cfebb63b57405c2b55b3c42a8f277c8 by laforge
pySim.tlv.COMPR_TLV_IE: Patch comprehension bit if derived class misses it

Our current implementation assumes that all COMPR_TLV_IE are created
with a raw tag value that has the comprehension bit set.  Check for this
during the class __new__ method and print a warning if we have to fix it up

Change-Id: I299cd65f32dffda9040d18c17a374e8dc9ebe7da
The file was modified pySim/tlv.py
Commit a5634c248b3415d95b4a4cfc6caf54a1de20d5d7 by laforge
jenkins.sh: Include es9p_client in pylint

Change-Id: I06f6773b8b5d3dfa588617d5af81c2fddb474a3d
The file was modified contrib/jenkins.sh
Commit 3b4a673de4f79f5a5be0bd413b8991c1b12697cb by laforge
add contrib/saip-tool.py

This is a tool to work with eSIM profiles in SAIP format.  It allows
to dump the contents, run constraint checkers as well as splitting
of the PE-Sequence into the individual PEs.

Change-Id: I396bcd594e0628dfc26bd90233317a77e2f91b20
The file was addedpySim/pprint.py
The file was modified contrib/jenkins.sh
The file was addedcontrib/saip-tool.py
Commit 4a191089dc02747115e0d299147ba430d2309456 by laforge
pySim.cat: Add more alredy-defined IEs to ProactiveCmd classes

... also add some spec references

Change-Id: If071abdc61c7c881bdea5292d12c74a1024f6784
The file was modified pySim/cat.py
Commit 1a9cabbbf008ad919294d815ade3e44cb96c441d by laforge
pySim/ota: Don't modify input argument in OtaDialectSms.encode_cmd

Change-Id: I4c4c44002762696b931ed3580ffe54daf62ffa61
The file was modified pySim/ota.py
Commit 8bd551af321af3ca3e73a48def87b303e91333fc by laforge
pySim.ota.OtaDialectSms: Move SMS header construct up to class level

this way we can use it in other [future] methods.

Change-Id: If296f823c18864fddcfb9cb1b82a087bac8875d4
The file was modified pySim/ota.py
Commit 32401a54e627494e5bf3749559be133739f2da7b by laforge
pySim.ota.OtaDialectSms: Implement command decoding

So far we only implemented command encoding and response decoding.
Let's also add command decoding, which is useful for example when
decoding protocol traces.

Change-Id: Id666cea8a91a854209f3c19c1f09b512bb493c85
The file was modified pySim/ota.py
The file was modified tests/test_ota.py
Commit 1aa77c5d7457fdb2313d9824c1cced08517427e1 by laforge
tests/ota_test.py: Allow stand-alone execution

Let's add a __main__ section to allow stand-alone execution via
python3 ./tests/test_ota.py

Change-Id: Ic3940ac23c7ddc1013e21f41eae6076a11dfd4f4
The file was modified tests/test_ota.py
Commit 5964bdd5a495461816807eba8b6de601405dd132 by laforge
osmo-smdpp: use NIST-P256 by default

The eSIM specs allow for both brainpool and nist; in reality the
deployments use the NIST P256 curve.

osmo-smdpp currently only supports a single certificate; let's use the
NIST one by default.

Change-Id: Idc7809f320505279c8a75e9b667be0a2af802f6b
The file was modified osmo-smdpp.py
Commit 5341bf902f1e6d1d08d35a541b25332b99104519 by laforge
unber.py: work-around pylint reporting (possibly-used-before-assignment)

contrib/unber.py:39:22: E0606: Possibly using variable 'content' before assignment (possibly-used-before-assignment)

Change-Id: I725cd5e05e3121c853669eb4bbfe5ba51b79eb75
The file was modified contrib/unber.py
Commit 36276e7b2aeeccb6d71acd90341033a5a96e2eb0 by laforge
contrib/jenkins.sh: Execute pylint also on all contrib python scripts

This way we get linting coverage for sim-rest-{server,client}, eidtool,
unber and others.

Change-Id: I2d6271d493d0f6765e6a184f8ae32f8325317be2
The file was modified contrib/jenkins.sh