Skip to content
Success

Changes

Summary

  1. xua_rkm: Fix dynamic AS destroyed when multiple ASPs are associated (details)
  2. asp: Log close&reconnect triggered from stream (details)
  3. asp: Make sure asp->fi is set to NULL when freeing the object (details)
  4. asp: Refactor osmo_ss7_asp_restart() into smaller chunks (details)
Commit cde32db154f4ad0fce5b2daa7f15635eb8c2dc8b by Pau Espin Pedrol
xua_rkm: Fix dynamic AS destroyed when multiple ASPs are associated

If more than 1 ASP was assigned to a dynamic ASP, when one of the ASP
would go down it would incorrectly tear down the associated dynamic AS.
This is wrong and should only happen when the last of the ASPs
associated to the AS is destroyed.

Change-Id: I986044944282cea9a13ed59424f2220fee6fe567
The file was modifiedsrc/ss7_as.h
The file was modifiedsrc/xua_rkm.c
The file was modifiedsrc/osmo_ss7_as.c
Commit 821335bd144ff3b1e90431f04199fa9a8201f8b6 by Pau Espin Pedrol
asp: Log close&reconnect triggered from stream

This helps a lot in debugging the cascade of events happening when
something goes wrong, since the xua_cli_close_and_reconnect() is called
from several places.

Change-Id: I05ffa0b21ad7b694899982901d9b94bdcf4e7999
The file was modifiedsrc/osmo_ss7_asp.c
Commit 2c8544f7bcdaedb38668daae1e3edeec8825f0ce by Pau Espin Pedrol
asp: Make sure asp->fi is set to NULL when freeing the object

The asp->fi is freed in lots of places through osmo_fsm_inst_term().
Make sure the pointer is actually set to NULL to catch potential
accesses to it after being freed.

Change-Id: I1e6a25f6db695a16bd05ae4ec481df6e14cf65b5
The file was modifiedsrc/osmo_ss7_asp.c
The file was modifiedsrc/xua_asp_fsm.c
The file was modifiedsrc/xua_asp_fsm.h
Commit c5bb2bf5398aea56a45bafb3eb18907efdb74db4 by Pau Espin Pedrol
asp: Refactor osmo_ss7_asp_restart() into smaller chunks

This is a preparation patch towards fixing osmo_ss7_asp_restart() doing
too many things at the same time, like tearing down the stream, FSMs,
recreating them etc, not always in the best order.
This function split steps into functions, better ordering the steps in
the process.
For instance, when reopening the stream_cli, make sure to close it
beforehand. This would anyway be done inside osmo_stream_cli_open() but
then all events (and hence logging) even weird, due to disconnect_cb
triggering in the middle of the creation and then calling
osmo_ss7_asp_restart() again while it is being called.
The later will be fixed in a follow-up commit.

Change-Id: I5c3461b724924f528b46f7fe815f017a5b4a1ff5
The file was modifiedsrc/ss7_asp.h
The file was modifiedsrc/osmo_ss7_asp.c