Skip to content
Success

Changes

Summary

  1. ipa: Clarify msgb_free in ipa_rx_msg() (details)
  2. xua,tcp-m3ua: Unify Rx code paths to deduplicate code (details)
Commit b98f0b8d9e3a4a634ed288b6d448db2c8185ec5a by Pau Espin Pedrol
ipa: Clarify msgb_free in ipa_rx_msg()

First of all, clean up and clarify the handling of msgb in
ipa_rx_msg_sccp() by always freeing the patched msgb copy, and letting
parent function free the original received msgb.

This in turn allows moving the msgb_free() of the received msg to
ipa_cli_read_cb() and ss7_asp_ipa_srv_conn_rx_cb(), which is where the
msgb is allocated, and makes the msgb lifecycle far more easy to
understand.
This is also what's already done in the
xua_cli_read_cb()/ss7_asp_xua_srv_conn_rx_cb(). This way we have similar
code paths in xua and ipa.

Related: OS#6876
Change-Id: Id29955182d9da47165ee9a2d7777b92fb87844b9
The file was modifiedsrc/ipa.c
The file was modifiedsrc/ss7_asp.c
Commit 180a0e6f3bc9dc433948f8f30f88a16fb69cccc9 by Pau Espin Pedrol
xua,tcp-m3ua: Unify Rx code paths to deduplicate code

This also makes those protocol paths resembles more the one of IPA,
where we call rx_ipa_msg() to handle the msgb.

m3ua_tcp_cli_read_cb() is also modified to avoid going through the SCTP
read_cb, which doesn't make much sense.

Change-Id: I54cf6c9b8c27fd67bae74d7931745f140e0575c0
The file was modifiedsrc/ss7_asp.c