Skip to content

Changes

Started 1 hr 3 min ago
Queued 8.7 sec
Took 1 min 46 sec on built-in

Summary

  1. vty: Allow configuring xua timers in ASP mode (details)
  2. vty: Allow configuring xua server in ASP mode (details)
  3. Move osmo_xua_layer_manager definition to ss7_asp.h (details)
  4. Document osmo_xua_layer_manager prim_cb (details)
  5. ss7_asp: remove lm during ASP destroy (details)
  6. Move osmo_xlm_sap_down to ss7_asp.c (details)
  7. Refactor xua_layer_manager object (details)
  8. xua_default_lm_fsm: Move timer_cb further below (details)
  9. lm: Use layer manager also on transport-role=server (details)
  10. lm: Initialize layer manager also on role=SG (details)
  11. IPSP: don't route any incoming M3UA messages in IPSP case (details)
  12. IPSP: Add a comment that it's intentional to drop all M3UA SNM for IPSP (details)
  13. IPSP: Allow vty-configuration of IPSP role "ASPs" (details)
  14. vty: Prohibit configuring an ASP as IPSP in an SG node (details)
Commit 411201410799b37345764d123221822d95df5d3c by Pau Espin Pedrol
vty: Allow configuring xua timers in ASP mode

non-STP users of the API may also want to configure per-ASP timers, like
the Heartbeat timer.

Change-Id: I3801d10175f42c13e6f7994e1e4da8e7c99e8e16
The file was modifiedsrc/ss7_vty.c
The file was modifiedtests/vty/ss7_asp_test.vty
Commit ca40fb4e1bbd57019ffe1f4ce0a33a511bea6503 by Pau Espin Pedrol
vty: Allow configuring xua server in ASP mode

The xua server has nothing to do with a node being an ASP or an SG,
it used to allow transport server features (SCTP/TCP server).
One may want to configure an ASP role with a SCTCP server.

Change-Id: I9b07d2c96404b7b86c51fd9c7bab5e52a2343ade
The file was modifiedtests/vty/osmo_stp_test.vty
The file was modifiedsrc/ss7_vty.c
The file was modifiedtests/vty/ss7_asp_test.vty
Commit 374b170ce2583c11ee3ed53f3ba44180169fb8ad by Pau Espin Pedrol
Move osmo_xua_layer_manager definition to ss7_asp.h

The struct osmo_xua_layer_manager has no relation to a xua_server, hence
move it to ss7_asp.h, where it is used.

Change-Id: If7efb8996de0c407f5a466ff959095c8872ddc76
The file was modifiedsrc/ss7_asp.h
The file was modifiedsrc/ss7_xua_srv.h
Commit 4bfe21313bb5c4267d515d669263d6dde23d63cb by Pau Espin Pedrol
Document osmo_xua_layer_manager prim_cb

Change-Id: I1347c3538435985836ee5fe1d9dd42996e32ff94
The file was modifiedsrc/ss7_asp.h
Commit 7c5b760db59cac189d9a39e86bd23fd9b9a78852 by Pau Espin Pedrol
ss7_asp: remove lm during ASP destroy

Otherwise the xua_default_lm_fsm instance is freed with talloc_free()
instead of osmo_fsm_inst_free().

Change-Id: Iee339b49d4b73a9afde60c4b8f6f5a03ad8a822d
The file was modifiedsrc/ss7_asp.c
Commit b7cf8be9640ff269e2770658b03c947e4388277e by Pau Espin Pedrol
Move osmo_xlm_sap_down to ss7_asp.c

That's a generic function to interact with the ASP from the LM.
Only some of the primitives are related to RKM.

Change-Id: I9a8d0e0fc1fd193db8dd3901911848ed8564616f
The file was modifiedsrc/xua_rkm.c
The file was modifiedsrc/ss7_asp.c
The file was modifiedsrc/xua_internal.h
Commit ea0763629d1ff9c74316b2244d71bfa2ab98cf5f by Pau Espin Pedrol
Refactor xua_layer_manager object

Several changes to improve separation of the LM object and its
lifecycle:
* Store in ss7_asp a pointer to a xua_layer_manager, which contains all
  implementation dependent information inside its priv pointer.
* Add a new free_func field to the xua_layer_manager struct in order to
  be able to free it without knowing how it was allocated.
* Get rid og the loglevel param, LOGL_DEBUG was always passed and that
  was actually an implementation specific detail of the default xua
  layer manager.
* Pass pointer to function to be called by LM to submit primitives to
  M3UA.

Change-Id: Ia96ebf40444f46ad718d61befbecb523f267fd6c
The file was modifiedsrc/xua_default_lm_fsm.c
The file was modifiedsrc/ss7_asp.c
The file was modifiedinclude/osmocom/sigtran/osmo_ss7.h
The file was modifiedsrc/ss7_asp.h
Commit 2adfaa6c5028493aaec0c0e030ceaf3ab353c468 by Pau Espin Pedrol
xua_default_lm_fsm: Move timer_cb further below

As usually done in osmo_fsm implemnetations.

Change-Id: Ibdc04d9ece0b3955da44849755a87ec28c17f140
The file was modifiedsrc/xua_default_lm_fsm.c
Commit 20a497bf5d48af51aacee7fd3b0021dd6df40d99 by Pau Espin Pedrol
lm: Use layer manager also on transport-role=server

The upper layers (M3UA) should behave similarly eg. on role ASP
independently of transport role being client or server.

Change-Id: I5f0109463323f214e15610b2c4fe253b828fce3b
The file was modifiedsrc/ss7_asp.c
Commit 401fb302bdfec62187dda36753ecc604b42ab491 by Pau Espin Pedrol
lm: Initialize layer manager also on role=SG

Right now the LM will stay in IDLE for role=SG, but it already provides
with an easier logic where all xUA ASPs (no matter their role) have an
associated FSM object, which can be extnded later on.
This way we already valdiate the FSM instance lifecycle wroks as
expected.
It also allows in the future more easily integrating the LM in role
IPSP, where it will need to be extended.

Change-Id: I1f25cf8371ba72d710796e01a9a967d3fafffb99
The file was modifiedsrc/xua_default_lm_fsm.c
The file was modifiedsrc/ss7_asp.c
Commit 944e7e59794afdcb2784086d612012c865f6de57 by Pau Espin Pedrol
IPSP: don't route any incoming M3UA messages in IPSP case

An IPSP is a point-to-point association, and we must not route any
such messages.

Change-Id: Iad7280619ec5814cda7a179418079048a5955976
The file was modifiedsrc/m3ua.c
Commit da31c4ce39a01693bc287287f8cf3e243f7ac286 by Pau Espin Pedrol
IPSP: Add a comment that it's intentional to drop all M3UA SNM for IPSP

An IPSP doesn't have MTP3 network management.

Change-Id: I7b87bf03964e7e9aac683ad860e511f83a685821
The file was modifiedsrc/m3ua.c
Commit ebdb08965edd16a0072be6beeb5c5cc99d6569c5 by Pau Espin Pedrol
IPSP: Allow vty-configuration of IPSP role "ASPs"

We should now have everything in place to support IPSP-SE, let's
accept enabling IPSP role via the VTY.

Change-Id: I0f0fa881471b87a4bb82a0211c6fb6e4c50b48ec
The file was modifiedsrc/ss7_asp_vty.c
Commit 88af8123bd13188192f5a3789ad6fb8e03ea3ff3 by Pau Espin Pedrol
vty: Prohibit configuring an ASP as IPSP in an SG node

The spec explicitly prohibits it.

Change-Id: I38bbd9226bad478f8068d02f7a4d7b3711596208
The file was modifiedsrc/ss7_asp_vty.c