Skip to content
Success

Changes

Summary

  1. ss7 vty: Fix insert order of routes with higher priority (details)
Commit a9e113232bdd5d78c3e271023983a08be299b557 by Pau Espin Pedrol
ss7 vty: Fix insert order of routes with higher priority

Route lookup ((hmrt_message_for_routing() => osmo_ss7_route_lookup() =>
osmo_ss7_route_find_dpc_mask())) iterates the list of routes assuming they are
ordered by mask length (so it doesn't need to iterate the full list every
time). Similary, it implicitly seems to assume that the entries are also
sorted by priority.

However, priority is not currently taken into account when being
inserted in the routing table, so the route ends up in the incorrect
place.

The VTY "update route" command used to first insert the route and only
*after* that tweak some of its fields, like priority or qos-class.

This commit adds a new set of osmo_ss7_route API which allows users to
*first* allocate a route and configure it completelly, and *second*
insert it once it contains all the information.
This way, the insert algorithm can take into account the configured
route priority and place the route entry in the routing table at the
proper place.

Related: SYS#7112
Change-Id: I6e7b5e3f06ae2c9468da58c55d2f42cbcd777218
The file was modifiedTODO-RELEASE
The file was modifiedsrc/osmo_ss7.c
The file was modifiedtests/vty/osmo_stp_route_prio.vty
The file was modifiedsrc/osmo_ss7_vty.c
The file was modifiedinclude/osmocom/sigtran/osmo_ss7.h