Skip to content
Success

Changes

Summary

  1. mgw: Rename and move code freeing endp connection (details)
  2. mgw: Rename and move several get_conn funcs acting on endp object (details)
  3. mgw: mgcp_network.c: Simplify use of conn_rtp ptr (details)
  4. mgw: Clean up access to conn_rtp from conn (details)
  5. mgw: Avoid 2nd lookup of conn in endp during CRCX (details)
  6. cosmetic: mgw: iuup: Update comment (details)
Commit 546983cdbc07821926a081f615b32d5a7f9c2d77 by Pau Espin Pedrol
mgw: Rename and move code freeing endp connection

All the code to free conns in an endpoint is really entanged, which also
makes it inefficient in several places because the list of conns is
iterated twice, or even ~N*2.

* Move code freeing the conn object to its own mgcp_conn_free()
  function.
* Rename functions acting on endp to be mgcp_endp_* prefix, and move
  them to mgcp_endp.{c,h}.
* Remove old mgcp_conn_free(endp, id) since it's not really needed
  anymore.

Change-Id: I9a87a07699dd8aa7856d5036e9b95a4ddf699a15
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
The file was modifiedinclude/osmocom/mgcp/mgcp_conn.h
The file was modifiedsrc/libosmo-mgcp/mgcp_endp.c
The file was modifiedsrc/libosmo-mgcp/mgcp_conn.c
The file was modifiedtests/mgcp/mgcp_test.c
The file was modifiedinclude/osmocom/mgcp/mgcp_endp.h
Commit 0f4be7699b94957ea55d8ecd4a3ff230f239b35d by Pau Espin Pedrol
mgw: Rename and move several get_conn funcs acting on endp object

These functions act on the endp object, hence prefix them with
mgcp_endp_* and move them to mgcp_endp.{c,h}.

Change-Id: Ifff01331db68998e9e23f99d8836d96022d550c2
The file was modifiedinclude/osmocom/mgcp/mgcp_endp.h
The file was modifiedsrc/libosmo-mgcp/mgcp_msg.c
The file was modifiedsrc/libosmo-mgcp/mgcp_e1.c
The file was modifiedtests/mgcp/mgcp_test.c
The file was modifiedsrc/libosmo-mgcp/mgcp_conn.c
The file was modifiedinclude/osmocom/mgcp/mgcp_conn.h
The file was modifiedsrc/libosmo-mgcp/mgcp_endp.c
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
The file was modifiedsrc/libosmo-mgcp/mgcp_vty.c
Commit 5d6931881af3d99e42e9c6d76346cb641d06ceee by Pau Espin Pedrol
mgw: mgcp_network.c: Simplify use of conn_rtp ptr

Change-Id: I5bab15fc793434173660769a8e60dae4ae4aa4c6
The file was modifiedsrc/libosmo-mgcp/mgcp_network.c
Commit cc97f58d963ab4aac181fa70db9092e72642e3b7 by Pau Espin Pedrol
mgw: Clean up access to conn_rtp from conn

Add a new mgcp_conn_get_conn_rtp() and use it everywhere instead of
accessing deep structure fields.

Change-Id: Iee2c19598e9570ea3b1ceba3cdfd2a5f5be2c954
The file was modifiedsrc/libosmo-mgcp/mgcp_vty.c
The file was modifiedsrc/libosmo-mgcp/mgcp_conn.c
The file was modifiedsrc/libosmo-mgcp/mgcp_endp.c
The file was modifiedsrc/libosmo-mgcp/mgcp_osmux.c
The file was modifiedinclude/osmocom/mgcp/mgcp_conn.h
The file was modifiedsrc/libosmo-mgcp/mgcp_msg.c
The file was modifiedsrc/libosmo-mgcp/mgcp_e1.c
The file was modifiedsrc/libosmo-mgcp/mgcp_stat.c
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
Commit 66952183a9116d40ed32a9a90da080b14ad72beb by Pau Espin Pedrol
mgw: Avoid 2nd lookup of conn in endp during CRCX

There's no need to lookup (iterate over conns) for rtp_conn in endp, we
have it accessible in constant time.

While at it, simplify some accesses to the pointer after it.

Change-Id: I8316e76a1789d4a8eaa1eb89bdaf86e25dc0a1e8
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
Commit 5469edc2788b64fd8e59cce228d722b1533852b1 by Pau Espin Pedrol
cosmetic: mgw: iuup: Update comment

Change-Id: I6e1448bf7e3bb7454754147e2b2e01844c157500
The file was modifiedsrc/libosmo-mgcp/mgcp_iuup.c