osmo-bts-trx: trx_provision_fsm: do not send *_CNF events on failure
The trx_provision_fsm currently does not check the event data (rc), causing failed operations (rc != 0) to be treated as successful confirmations. Avoid emitting *_CNF events when a command fails, ensuring that only successful operations generate confirmation events.
osmo-bts-trx: apply 'max-initial' value before POWERON
Not applying this value before powering the transceiver on results in transmission at full Tx power for a certain amount of time before the power ramping begins.
Depending on the power control interval (P_Con_INTERVAL), the MS power loop may delay the power control decision for a certain amount of SACCH block periods. In this case lchan_ms_pwr_ctrl() returns early and no logging is printed at all.
Let's always log the input values (reported level, UL measurements) early in lchan_ms_pwr_ctrl(). This is useful for debugging, and this is exactly what lchan_bs_pwr_ctrl() does.
Those fields are also part of the power control state, since they are modified through the lifecycle of the lchan eg. during rx of CHAN (RE)ACT, MS POWER CONTROL, etc. Those should also be reset together with other fields.
Moreover, with this patch we get rid of an extra indirection pointer which could be NULL (under static configuration) and hence create potential problems.