Skip to content
Success

Changes

Summary

  1. mgw: Split CRCX read-only validations into its own function (details)
  2. mgw: Increment rate_ctr MGCP_*_FAIL_UNHANDLED_PARAM during parsing (details)
  3. mgw: Split MDCX read-only validations into its own function (details)
  4. mgw: Split MDCX read-only validation on conn into its own function (details)
  5. mgw: Split DLCX read-only validations into its own function (details)
  6. mgw: CRCX: Handle codec information before initializing osmux (details)
  7. mgw: Drop rtp_processing transcoding stubs (details)
  8. mgw: Rearrange last steps of CRCX and MDCX (details)
  9. mgw: mdcx: Fix inc of non-existing ctr in mdcx counter group (details)
Commit c8b8106cb5337d0bb056e7d1300f1b539f4ff1c8 by Pau Espin Pedrol
mgw: Split CRCX read-only validations into its own function

The SDP parsing is moved to a step beforehand, so that validation of
full message can be done in a subsequent step. That validation step is
moved into a function to give some air to handle_create_con() and easily
spot the logic.

The logic based on force_realloc is split so that code modifying the
object is moved to the later update step.

Change-Id: I639ad0a25a0af4a4637045ca8bf61e436a789426
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
Commit 485e08514048e902eabb762ab4001c8763b5ca7d by Pau Espin Pedrol
mgw: Increment rate_ctr MGCP_*_FAIL_UNHANDLED_PARAM during parsing

We could not do it before because we had no easy access to the command
verb being parsed. Now that we have access to it, bettter increase it
where we have exact path where stuff happens.

Change-Id: I3ea45fc1d25284b253ac9b7f0c0a925c10c994ca
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
The file was modifiedsrc/libosmo-mgcp/mgcp_msg.c
Commit 2140c20a0bb149be66954f4f4253c93fbfe726b7 by Pau Espin Pedrol
mgw: Split MDCX read-only validations into its own function

The SDP parsing is moved to a step beforehand, so that validation of
full message can be done in a subsequent step. That validation step is
moved into a function to give some air to handle_modify_con() and easily
spot the logic.

Change-Id: I469413dbe89cc4795deb50d76b434655cba9b776
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
Commit ea4aa7d3c180fdeb1417821bff434365d7d244a9 by Pau Espin Pedrol
mgw: Split MDCX read-only validation on conn into its own function

Add a second read-only validation step once the conn to be modified is
found in the endpoint.

Change-Id: I025ca5352eff9ee35c977c69b71934513646b1f2
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
Commit 436f4dee1718d5686a3d0905cc3ac679089e68e8 by Pau Espin Pedrol
mgw: Split DLCX read-only validations into its own function

Similar to what's already done in CRCX and MDXC.

Change-Id: I3d86f0cbeacc7c0cd69809f898714a76d3b86ed0
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
Commit eeee783db2a112a4567ab6b9c0cb29843a9db5e5 by Pau Espin Pedrol
mgw: CRCX: Handle codec information before initializing osmux

Same order as done during MDCX. This way we can also eg. check
configured codec is AMR before successfully entering configuring osmux.

Change-Id: If291db0c048196e6e0eee2c38e648e5a25438078
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
Commit c3ff38ee4c2df1f431b822ac34fbfd7f3542bb69 by Pau Espin Pedrol
mgw: Drop rtp_processing transcoding stubs

This has never been used afaik, and it's only clogging the code and
adding extra indirect function pointer calls to hot paths for no good
reason.
Drop all of it, and re-ad whatever makes sense once someone really wants
to implement transcoding.

Change-Id: Id16af528d94612e771f94333ad5404e5cd1c3318
The file was modifiedinclude/osmocom/mgcp/mgcp_network.h
The file was modifiedsrc/libosmo-mgcp/mgcp_network.c
The file was modifiedinclude/osmocom/mgcp/mgcp.h
The file was modifiedinclude/osmocom/mgcp/mgcp_ratectr.h
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
The file was modifiedsrc/libosmo-mgcp/mgcp_ratectr.c
Commit 8b23fb916a3b56ee913df9cfada2e9b5ae948ef8 by Pau Espin Pedrol
mgw: Rearrange last steps of CRCX and MDCX

Make code in CRCX and MDCX look closer, since it is really doing the
same.
Move the dummy ping code after everything has been done correctly, since
the ping is just a side effect of the conn being created.

Change-Id: I42acda16cb2d59a9b7aae06b7584d4dfc1e91f9e
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
Commit a4ebbf7dbea7e25381bed866bbc85d312dd4b646 by Pau Espin Pedrol
mgw: mdcx: Fix inc of non-existing ctr in mdcx counter group

Change-Id: If849e3922c7ae864771c41ff7c0fac37ef0280de
The file was modifiedinclude/osmocom/mgcp/mgcp_ratectr.h
The file was modifiedsrc/libosmo-mgcp/mgcp_ratectr.c
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c