Skip to content
[Jenkins]Jenkins
log insign up
Success

Changes

Summary

  1. ATR: use lowercase hex strings without spaces as ATR constants (details)
  2. ATR: align get_atr() return value type (details)
  3. pySim/transport: add abstract get_atr method to LinkBase (details)
Commit d871e4696f70e747bc4a6a04f35fd0b0141ceb5b by pmaier@sysmocom.de
ATR: use lowercase hex strings without spaces as ATR constants

The ATR constants are the only hex string constants where the hex
bytes digits are separated with spaces. Also the hex digits are in
lowercase. Let's use a lowercase string without spaces here like
we do in many other code locations.

Related: OS#6322
Change-Id: I95118115b02523ed262a2fbe4369ace3996cd8f5
The file was modifiedpySim/legacy/cards.py
The file was modifiedpySim/sysmocom_sja2.py
Commit 08ba187fd446db422a2bebbd4a9b2564096cace2 by pmaier@sysmocom.de
ATR: align get_atr() return value type

type annotations claimed the return type was Hexstr, but in reality
it was a list of integers.  Let's fix that.

Change-Id: I01b247dad40ec986cf199302f8e92d16848bd499
Closes: OS#6322
The file was modifiedpySim/runtime.py
The file was modifiedpySim/transport/serial.py
The file was modifiedpySim/legacy/cards.py
The file was modifiedpySim/filesystem.py
The file was modifiedpySim/transport/pcsc.py
The file was modifiedpySim-shell.py
Commit edcd62435d0777ad798e44b4613eff8332030d14 by pmaier@sysmocom.de
pySim/transport: add abstract get_atr method to LinkBase

The implementations that inheret from the LinkBase class are expected to
implement a get_atr method. This method is mandatory, since it is one of
the most basic functionalities of pySim to display an ATR. Also the ATR
is sometimes needed to distinguish between different card models.

The modem_atcmd and calypso implementation completely lack the get_atr
method. Apparantly it is not possible to get an ATR in those
environments, so lets add a dummy method there.

Related: OS#6322
Change-Id: I4fc020ca45658af78e495a5c1b985213f83cbb50
The file was modifiedpySim/transport/__init__.py
The file was modifiedpySim/transport/calypso.py
The file was modifiedpySim/transport/modem_atcmd.py