Skip to content
Success

Changes

Summary

  1. server: Move conn->file_hdr release to osmo_pcap_conn_close() (details)
  2. server: Add osmo_pcap_server_free() for completeness (details)
  3. server: Split buffer read from full msg handling (details)
  4. server: Log unable to figure out pcap vs pcapng (details)
  5. server: Limit rx buffer size to UINT16_MAX (details)
  6. server: Use osmo_stream_srv_link on tcp listen socket (details)
Commit a48bb37b3ba6dbb934b0934296028ada935492b9 by Pau Espin Pedrol
server: Move conn->file_hdr release to osmo_pcap_conn_close()

We can always already release the file_hdr since we'll expect to receive
a new one next time a connection is created.

Change-Id: Ib822a0544b7a487614df28214813f31234eb6a0f
The file was modifiedsrc/osmo_server_network.c
The file was modifiedsrc/osmo_server_core.c
Commit cbea315315bb1b2c78d6d710353093d9dd28c8a6 by Pau Espin Pedrol
server: Add osmo_pcap_server_free() for completeness

It will never really be called, but helps in understanding the lifecycle
of objects and tricks my mind from thinking I'm missing something when
adding new fields.

Change-Id: I2606390fc9d9b8a2335c96688d83a038ba73f8ab
The file was modifiedsrc/osmo_server_main.c
The file was modifiedsrc/osmo_server_core.c
The file was modifiedinclude/osmo-pcap/osmo_pcap_server.h
Commit a4f751d29f23a6c817feaeeef84be0f6e05e8866 by Pau Espin Pedrol
server: Split buffer read from full msg handling

This also simplifies follow-up patches modifying the way we read
packets through osmo_stream.

Change-Id: Ie7b8af0edbccc83812a44c6bfd61c98fbc3df324
The file was modifiedsrc/osmo_server_network.c
Commit bc10faf88d33bf60251daba58fe6dbd99891ddc4 by Pau Espin Pedrol
server: Log unable to figure out pcap vs pcapng

Change-Id: I110456f142cab88ba9d51409b66d66cf093adb9f
The file was modifiedsrc/osmo_server_network.c
Commit 6d2f7c52661b534a576e3b4d1dc9f43d3f3d18ab by Pau Espin Pedrol
server: Limit rx buffer size to UINT16_MAX

We can't receive bigger buffers anyway as limited by protocol and msgb
itself, so trim it.

Change-Id: I96bfe1625510cca67f5781e2895caf2a3612ec62
The file was modifiedsrc/osmo_server_core.c
Commit 4bf57c2fe5cbf6622a19a2dd1764ebac178fc0c2 by Pau Espin Pedrol
server: Use osmo_stream_srv_link on tcp listen socket

Related: SYS#7080
Change-Id: I3562185f98685ea5a412273212e6dfbe55b360e2
The file was modifiedsrc/Makefile.am
The file was modifiedinclude/osmo-pcap/osmo_pcap_server.h
The file was modifiedcontrib/osmo-pcap.spec.in
The file was modifieddebian/control
The file was modifiedcontrib/jenkins.sh
The file was modifiedtests/rotate_localtime/Makefile.am
The file was modifiedconfigure.ac
The file was modifiedsrc/osmo_server_core.c
The file was modifiedsrc/osmo_server_network.c