Skip to content

Changes

Started 6 hr 7 min ago
Queued 5 sec
Took 3 min 6 sec on built-in
gsup: encode_pdp_info(): fix wrong pdp_address index

The `PDP_TYPE_N_IETF_IPv4v6` case encodes two addresses: IPv4 from
`pdp_address[0]` and IPv6 from `pdp_address[1]`.  The IPv4 part is
encoded correctly, but the IPv6 part checks the wrong index.

The decoder decode_pdp_address() correctly puts the IPv4 address in
`pdp_address[0]` and the IPv6 address in `pdp_address[1]`.  Because
`pdp_address[0].sa_family` is `AF_INET` (not `AF_INET6`), the second
condition is always false in a proper dual-stack context, so the IPv6
part is silently dropped from every outgoing dual-stack GSUP message.

Change-Id: Ibc4a438ee7b06346839e78dc14d9d5b11b1c5bbd
Vadim Yanitskiy at
socket: osmo_sockaddr_from_str_and_uint(): fix memleak

`addrinfo_helper()` internally calls `getaddrinfo()`, whose result
must be freed with `freeaddrinfo()`.  On the size-check error path
the function returns early without freeing.  Fix this.

Change-Id: Ib05e1b8f2465e0db79e7b45de151dc9945e27924
Vadim Yanitskiy at
stats: osmo_stats_reporter_udp_open(): fix unconditional jump

Change-Id: Ifb4842ea11e4df0cae8733438b3812a086396b99
Fixes: cc3694b65 ("Fix build for OSX")
Vadim Yanitskiy at
gsm48: fix missing/misspelled value-strings

Change-Id: I8d2333290c7715fd75ce7e7c759cb564a26b7461
Vadim Yanitskiy at
gsm48: remove duplicate GSM48_MT_RR_HANDO_INFO

Change-Id: Ic1cbba2b2a746667b9920ed2ed19b3848185977d
Vadim Yanitskiy at
gsmtap_util: gsmtap_gsm_channel_names[]: fix PTCCH string

Change-Id: Ic65668ae0363b991966bcf8ba4fb913940639964
Vadim Yanitskiy at