Changes

server: Simplify (store|no-store) feature

Having a bool variable with a negation in its name just makes everything
more complex for no good reason.

Change-Id: If0b76e7a922c26859d04d339bcc3bdccd66a6922

cosmetic: server: document functions

Change-Id: I6709b720e236514b8572fe60834a990558e67f5c

server: Simplify code paths in read_cb_*

Change-Id: Ib609af3b1788fe02d9d6957a08d85bc8bae821e8

server: Delay reopen of pcap only until necessary

If we are asked to reopen a pcap file (eg due to external SIGUSR1) while
in the middle of receiving a data packet (we already received the header
of the segment so data will arrive soon), code exists to delay reopening
so that we can include that last packet which arrived because the time
where we were asked to reopen.
However, the new pcap file was reopened only after next packet arrived.
Instead, we want to reopen it as soon as that last packet is received,
so that a new pcap file is created. This allows better tracking eg.
empty traffic during time in between last data packet before reopen and
the next data packet arriving.

While at it, rename the variable to make it more informative, and
convert it to a bool.

Change-Id: Id79500717a2e186aac979cded340a5af6ce3035b

server: Store read buf max len as conn field

This will be useful later on when adding pcapng support, since checks
will become more complex due to different data types to be checked,
based on information from pcap vs pcapng gathered from magic field
inside the received link_hdr buffer.

Change-Id: I8f62aa0bdb04e73223c0c6803a58241f83a5ebe9

server: Split osmo_pcap_conn alloc to its own function

Change-Id: I622c9662b0a451ca5466e053a046346b536ed0a6

server: Rename function osmo_pcap_server_delete -> osmo_pcap_conn_free

Change-Id: I72372b43eddc74e80c430c9a9e4337809c123ed6

cosmetic: server: Fix typo in comment

Change-Id: I03aa0137d5470717104f27cb55d4bde802d00a95

server: Rename func client_data() -> zmq_send_client_data()

Change-Id: I1b22046464cf969fb5d74b6c2580aaec1feffefa

Cleanup and reorder includes in header files

Put all includes in same order of dependencies.

Include stdint.h instead of inttypes.h since that's the file actually
containing the standard int types.

Change-Id: I0467d3c3a2687a7990c0db7371d0c89f97e8400a

Makefile.am: proper format and reorder source file lists

Change-Id: Ie39bd0348f4f329539c1d9dabc8fa87f3e4bbefe