Skip to content
Sign in

Changes

Started 1 day 2 hr ago
Queued 5.7 sec
Took 3 min 55 sec on built-in

Summary

  1. Implement log file target using osmo_io (details)
  2. Use same queue length for gsmtap_log and gsmtap_file (details)
  3. osmo_io: Remove outdated comment in API doc of (details)
  4. osmo_io: Allow fetching maximum value allowed by (details)
  5. logging_file: Request up to 8 iofd write buffers if available (details)
Commit 6e3a4a0214423125a66482350fa320efa5320d8d by Pau Espin Pedrol
Implement log file target using osmo_io

Reuse (struct log_target)->tgt_file->wqueue->except_cb to store the iofd
pointer internally, since we are not allowed to change the struct
log_target because it's public and we don't want to break the ABI.
Using the wqueue except_cb is fine since that field was never used.

Related: OS#6918
Change-Id: Ieb6420246454ef59442b1fd7b1d14e2c00fa69a5
The file was modifiedtests/logging/logging_test.err
The file was modifiedsrc/core/logging_file.c
The file was modifiedtests/logging/logging_test.c
Commit bf11fb7f3084f83515ca62c19a51b400af1d400a by Pau Espin Pedrol
Use same queue length for gsmtap_log and gsmtap_file

Take the chance to also deduplicate MAX_LOG_SIZE.

Change-Id: I3772d291f97626ee325731f3515a5110eda70d3d
The file was modifiedsrc/core/logging_file.c
The file was modifiedinclude/osmocom/core/logging_internal.h
The file was modifiedsrc/core/logging_gsmtap.c
Commit 957de96b0b9eb32afd50b1f9974cef904887e79b by Pau Espin Pedrol
osmo_io: Remove outdated comment in API doc of osmo_iofd_set_io_buffers()

Multiple iov buffers are supported in poll backend since
4272cd46b1e5b264e6f6b65d38bcb08e3a139a9e.

Related: OS#6705
Change-Id: I9b75f3597081c6cd7e24f75f0e289b93edb3aa86
The file was modifiedsrc/core/osmo_io.c
Commit 378cf564c8859311415aa70adeb220cedbe56eb3 by Pau Espin Pedrol
osmo_io: Allow fetching maximum value allowed by osmo_iofd_set_io_buffers()

Before this patch, there's no way for a user of the API to know whether
a requested buffers value is actually going to be accepted or not.

Change-Id: Id3d8413c119eb3d9b60aa068295a59561236938c
The file was modifiedsrc/core/osmo_io.c
Commit 76d6d82e910931661f5bd2218deff80e0cae904a by Pau Espin Pedrol
logging_file: Request up to 8 iofd write buffers if available

This should help in decreasing latency between submitting a logging line
and getting it written to file. It should, for the same reason, optimize
CPU use.

Change-Id: Ia88b27948922d278e0f72fc2aac4b4ae88465b4d
The file was modifiedsrc/core/logging_file.c