Skip to content
Failed

Changes

Summary

  1. contrib/jenkins: fix a typo (details)
  2. ccid_gen_notify_slot_status: add msgb_put cast (details)
  3. ccid_host: fix read_timeout defined but not used (details)
  4. ccid_host: remove unused _set_dtr (details)
  5. ccid_host: fix unused variable warnings (details)
  6. ccid_host/Makefile: tweak formatting (cosmetic) (details)
  7. ccid_hosts: add talloc cflags, libs, include (details)
Commit 8646a7a30af1ee684dcbda2fabefe3588133b916 by Oliver Smith
contrib/jenkins: fix a typo

Change-Id: Iaa8349e90d222ef918051c344e45ec51ae649884
The file was modifiedcontrib/jenkins.sh
Commit 55b2875e57e721c82dbebcea472d08c7046eb4be by Oliver Smith
ccid_gen_notify_slot_status: add msgb_put cast

Fix this error seen in master-osmo-ccid-firmware after switching to
debian trixie with 14.2:

../main.c:338:57: error: initialization of 'struct ccid_rdr_to_pc_notify_slot_change *' from incompatible pointer type 'unsigned char *' [-Wincompatible-pointer-types]
  338 |         struct ccid_rdr_to_pc_notify_slot_change *nsc = msgb_put(msg, sizeof(*nsc) + sizeof(statusbytes));

Change-Id: I5618297533246adc8adaacf49fd58ec1f0f97cfc
The file was modifiedsysmoOCTSIM/main.c
Commit 603eac1b2d61331483edb124e599b48dce7dca97 by Oliver Smith
ccid_host: fix read_timeout defined but not used

Comment out the read_timeout fuction, as it is only used in already
commented out code. Fix for:

cuart_driver_tty.c:90:12: warning: 'read_timeout' defined but not used [-Wunused-function]
   90 | static int read_timeout(int fd, uint8_t *out, size_t len, unsigned long timeout_ms)

Change-Id: I49fc59ebaa4abc3e9b8838e1b427f4455acdb390
The file was modifiedccid_host/cuart_driver_tty.c
Commit 057753e7f6d2b1ae5fe47835431ff0c86f2b3f2c by Oliver Smith
ccid_host: remove unused _set_dtr

Fix for:

cuart_driver_tty.c:62:13: warning: '_set_dtr' defined but not used [-Wunused-function]
   62 | static void _set_dtr(int fd, bool dtr)

Change-Id: I43b08a584891e94b9cfab095834e499dd5914b4f
The file was modifiedccid_host/cuart_driver_tty.c
Commit 82431d70b7b2fe1af8b9d07706ad1a9bf60c16f0 by Oliver Smith
ccid_host: fix unused variable warnings

Fix for:

hub_main_functionfs.c:232:13: warning: unused variable 'rc' [-Wunused-variable]
hub_main_functionfs.c:343:30: warning: unused variable 'uh' [-Wunused-variable]


Change-Id: Ib4c28e4ab3106175d450ea7ac78313866d35f600
The file was modifiedccid_host/hub_main_functionfs.c
The file was modifiedccid_host/cuart_fsm_test.c
Commit bc62c2490ae35100e3720dd9a2ed35f782f91107 by Oliver Smith
ccid_host/Makefile: tweak formatting (cosmetic)

Change-Id: Ic2e92f9364361af0989b447d3824e867c0cb23d4
The file was modifiedccid_host/Makefile
Commit b719f5249f85f8b7413cf519230a3f8dcafa2669 by Oliver Smith
ccid_hosts: add talloc cflags, libs, include

Fix for:

ccid_main_functionfs.c:534:17: error: implicit declaration of function 'talloc_report_full' [-Wimplicit-function-declaration]
  534 |                 talloc_report_full(g_tall_ctx, stderr);
The file was modifiedccid_host/ccid_main_functionfs.c
The file was modifiedccid_host/Makefile
The file was modifiedccid_host/cuart_fsm_test.c
The file was modifiedccid_host/hub_main_functionfs.c