Skip to content
Success

Changes

Summary

  1. dia/diameter_3ggp_ts32_299.dia: Inherit RFC4005 instead of RFC7155 (details)
  2. dia: restrict AVPs inherited from RFC4005 (details)
  3. Remove duplicate 3GPP-AAA-Server-Name definition and break 3-way (details)
Commit 5eab7d684e1d9098e7c9ac1a305b1e33fb6c03e0 by Pau Espin Pedrol
dia/diameter_3ggp_ts32_299.dia: Inherit RFC4005 instead of RFC7155

While it's true that RFC7155 obsolets RFC4005, latest release 18.0.1 of
3GPP TS 32.299 explicitly references RFC4005 and never RFC7155.
Since they are both incompatible, inherit the referenced RFC4005.

Same goes for 3GPP TS 29.273, but since we actually don't really use
it in the subset defined there, simply drop it.

As a result, nobody is using rfc7155.dia related stuff, so we can drop
it.

Change-Id: I7742d1523026e260b8501550977a41ebd3ad1b09
The file was removeddia/diameter_rfc7155.dia
The file was modifieddia/diameter_3gpp_ts32_299.dia
The file was modifieddia/diameter_3gpp_ts29_273_swx.dia
The file was removeddia/diameter_rfc7155_nasreq.dia
Commit e85f42d3c2e44f4e4cb67c1f084c8d284535dd0d by Pau Espin Pedrol
dia: restrict AVPs inherited from RFC4005

Otherwise the "Service-Type" AVP is inherited and then may cause third
modules indirectly inheriting to collide with their own "Service-Type"
AVP.

Change-Id: Ibc11180489db6d86819ab17a5e7e92636dfed95e
The file was modifieddia/diameter_rfc4072.dia
The file was modifieddia/diameter_3gpp_ts29_212.dia
The file was modifieddia/diameter_3gpp_ts29_229.dia
The file was modifieddia/diameter_3gpp_ts32_299.dia
Commit b1b6237452d8fe79b7c02f67315c7a107e072522 by Pau Espin Pedrol
Remove duplicate 3GPP-AAA-Server-Name definition and break 3-way circular dependency

3GPP-AAA-Server-Name is from TS 29.273, so avoid re-defining the type in
TS29.173. As a result, a 3-way dependency is created, and hence it is
broken by moving GMLC-Address to the break_circle.dia used for that
purpose.

The 3-way circular dependency:
* TS29.173 uses 3GPP-AAA-Server-Name from TS29.273
* TS29.273 uses Trace-Data from TS29.272
* TS29.272 uses GMLC-Address from  TS29.173

Change-Id: Idb1a7f7588b751c59788e4d99cd1d86f1fd2b573
The file was modifieddia/diameter_3gpp_ts29_173.dia
The file was modifieddia/diameter_3gpp_ts29_273.dia
The file was modifieddia/diameter_3gpp_break_circles.dia
The file was modifieddia/diameter_3gpp_ts29_272.dia