Skip to content
Success

Changes

Summary

  1. ts_51_011: Improve testing of EF_SMSP (details)
  2. pySim/ts_51_011: Properly re-compute ScAddr length (details)
  3. pySim.ts_51_011.EF_SMSP: Properly handle odd-length ScAddr / TpAddr (details)
Commit c058c6a34dd33cc718afad6417549faed2571536 by laforge
ts_51_011: Improve testing of EF_SMSP

* add another set of test data (from a real-world SIM card)
* switch from test_decode to test_de_encode as our encoder now works due
  to previous commits.

Change-Id: I8d16e195641bb59b2c26072008f88434692c0cab
The file was modifiedpySim/ts_51_011.py
Commit 5fe76bb680099bdee2ed12c5df520aed651f0f3e by laforge
pySim/ts_51_011: Properly re-compute ScAddr length

EF.SMSP contains up to two addresses: Both are stored in a fixed-length
field of 12 octets.  However, the actually used size depends on the
number of digits in the respective number.  Let's compute that length
field properly

Change-Id: Idef54a3545d1a5367a1efa2f0a6f7f0c1f860105
The file was modifiedpySim/utils.py
The file was modifiedpySim/ts_51_011.py
Commit 88aff4c577620b47e01d6cf137462792f0929bd5 by laforge
pySim.ts_51_011.EF_SMSP: Properly handle odd-length ScAddr / TpAddr

As the input phone number ("address") might be of an odd length of
digits, let's use PaddedBcdAdapter to fix two problems:

1) strip any potential trailing f in decoding
2) fix truncation of last digit during encoding

Change-Id: I1e9865e172bc29b8a31c281106d903934e81c686
Depends: pyosmocom Ib5afb5ab5c2bc9b519dc92818fc6974f7eecba16 (0.0.12
The file was modifiedrequirements.txt
The file was modifiedsetup.py
The file was modifiedpySim/ts_51_011.py
The file was modifiedtests/pySim-trace_test/pySim-trace_test_gsmtap.pcapng.ok