pySim.esim.saip.personalization: Support Milenage customization (details)
pyshark_gsmtap: Adjust display filter for some wireshark versions (details)
ts_51_011/EF.SMSP: Fix parsing of parameter_indicators (details)
unittest/test_files.TransparentEF_Test: Actually test encoder (details)
unittests/test_files: Pass to-be-encoded length to encoder functions (details)
Commit
ddbf91fc4aa8d033304b0cb1615ad9978c194357
by laforge
pySim.esim.saip.personalization: Support Milenage customization
Milenage offers the capability for operators to modify the r1-r5 rotation constants as well as the c1-c5 xor-ing constants; let's add ConfigurableParameters for that.
Commit
111f9da4f5b46c79b2fe0584a60ba52539c21503
by laforge
pyshark_gsmtap: Adjust display filter for some wireshark versions
On my debian unstable system with wireshark 4.6.2-3, the pyshark_gsmtap APDU source misses to report any ATRs, as those are not part of what's reported with the 'gsm_sim' display filter. This is due to wireshark.git commit bcd82e2370d18e20983b378d494964d89c191cef first part of the 4.6.0 release, which splits the ATR dissection into a separate sub-dissector.
We cannot use the seemingly logical 'gsmtap.type == 4' instead, as old wireshark simply bypasses any output for the gsmtap header if the SIM sub-dissector is used.
Hence, 'gsm_sim || iso7816.atr' is something compatible with older and newer wireshark versions.
Commit
82b57403c79de04934da264e0be363ba99f5b797
by laforge
unittest/test_files.TransparentEF_Test: Actually test encoder
In the test_encode_file() method, we should actually test the encoder, and not the decoder. I suppose this was a copy+paste mistake at some point? In the LinearFixedEF_Test.test_encoder_record we were already testing the encoder. Just TransparentEF_Test got it wrong...
Commit
9a23eab1634e8feb6c0cf4d4980a8a27c9b438bf
by laforge
unittests/test_files: Pass to-be-encoded length to encoder functions
Some of the encoders can only generate valid output if they are told the expected output size. This is due to variable-length fields that depend on the size of the total record (or file). Let's always pass the expected length to the encoder methods.