Skip to content
Success

Changes

Summary

  1. sccp: Allow marking UNIT-DATA.req Sequence Control param non-presence, (details)
  2. AS loadsharing: Log routing lookup logic (details)
  3. sccp_scrc: Improve logging of route lookup failure (details)
  4. ASP loadsharing: Normal ASP distribution regardless of active state (details)
  5. AS loadsharing: Normal route distribution regardless of active state (details)
  6. route: osmo_ss7_route_name(): Use osmo_ss7_pointcode_print_buf() (details)
  7. vty: Add cmd 'show cs7 instance <0-15> as name AS_NAME' (details)
Commit 0061e8d0bcba3b0ed5ea255588619627d0975380 by Pau Espin Pedrol
sccp: Allow marking UNIT-DATA.req Sequence Control param non-presence, set SLS

The public API for SCCP UNIT-DATA.req was missing a way to state whether
the "Sequence Control" Parameter was present or not in the primitive.

This was originated most probably by the fact that the field is always
present for SUA CLDT message generated and sent over the wire.

Still, the presence of such field during UNIT-DATA.req actually
indicates the Protocol Class to be used/set on the message.
Hence, it is important to provide it.

Once the Protocol Class to transmit the message is known, we can then
generate a proper SLS.

Change-Id: I834e91c1ec337713b0e684cf4fd7de854150bef6
The file was modifiedinclude/osmocom/sigtran/sccp_sap.h
The file was modifiedsrc/sccp_helpers.c
The file was modifiedsrc/sccp_sclc.c
Commit 526229c80a09bb83a9bdcda8786ce3f3bb122390 by Pau Espin Pedrol
AS loadsharing: Log routing lookup logic

Loggin very similar to what we already have for ASP loadsharing in
ss7_as_select_asp_loadshare().

Change-Id: I6b4983bc2cc8bd231a5d85f378be8c93c6f4fa27
The file was modifiedsrc/osmo_ss7_combined_linkset.c
The file was modifiedsrc/ss7_combined_linkset.h
Commit ed9fc6bfe29b0641bcb609d57247be8393bc2ad3 by Pau Espin Pedrol
sccp_scrc: Improve logging of route lookup failure

Change-Id: I54a59f8b95451b473204d625acdc22dcfc94b631
The file was modifiedsrc/sccp_scrc.c
Commit 6e4a7f4d278196687b17c2476e689de27c583619 by Pau Espin Pedrol
ASP loadsharing: Normal ASP distribution regardless of active state

Before this patch, the normal ASP for a given loadshare eSLS entry (seed)
would only be filled in with active ASPs.
That means that if eg. N ASPs are configured but only 1 is successfully
activated upon startup and a lot of traffic happens, the full eSLS will
be filled with that ASP, and as a result all traffic will be sent to
that ASP, with the exception during the time that ASP is inactive.

Instead, we want to populate the eSLS table with Normal ASP field
properly distributed over all ASPs. If a given ASP is not active at that
time, then simply pick an Alternative ASP during that time.

Change-Id: I2064fe89bac2d3bd86fee544a64ab21417e1c368
The file was modifiedsrc/osmo_ss7_as.c
The file was modifiedsrc/ss7_as.h
Commit b97ff1e65ea35befcce42b5eb0723b0f0b89f8f1 by Pau Espin Pedrol
AS loadsharing: Normal route distribution regardless of active state

Before this patch, the normal route for a given loadshare eSLS entry (seed)
would only be filled in with available routes.
That means that if eg. N routes are configured but only 1 is really
available upon startup and a lot of traffic happens, the full eSLS will
be filled with that route, and as a result all traffic on that combined
linkset will be sent through that route.

Instead, we want to populate the eSLS table with Normal Route field
properly distributed over all routes. If a given route is not active at
that time, then simply pick an Alternative Route during that time.

Change-Id: I6daf114416c69c84bdc3042efcaf2918f91c2e87
The file was modifiedsrc/ss7_combined_linkset.h
The file was modifiedsrc/osmo_ss7_combined_linkset.c
Commit e71db12e24ff3f0037e6c84959f60ae4586c3e29 by Pau Espin Pedrol
route: osmo_ss7_route_name(): Use osmo_ss7_pointcode_print_buf()

This allows callers to call osmo_ss7_route_name() together with
osmo_ss7_pointcode_print() and osmo_ss7_pointcode_print2() in the same
LOG line.

Change-Id: Iccbd83eeaa0e1c2a6078ece8d5c6d7af6fd9d71a
The file was modifiedsrc/osmo_ss7_route.c
Commit b58b343a37e762dddd625b27b60b64ee145764f0 by Pau Espin Pedrol
vty: Add cmd 'show cs7 instance <0-15> as name AS_NAME'

As also available in Cisco ITP.

Change-Id: I76be29aeacb60201ecb5bab2203f02e3cdfc0943
The file was modifiedsrc/osmo_ss7_vty.c
The file was modifiedtests/vty/osmo_stp_test.vty