Skip to content
[Jenkins]Jenkins
log insign up
Success

Changes

Summary

  1. vty: assert in optional param followed by optional-multi-choice param: (details)
  2. vty: assert in optional param followed by optional-multi-choice param: (details)
Commit aafa7c02edba4a215fec9d01c48d21c3a1addc1d by Pau Espin Pedrol
vty: assert in optional param followed by optional-multi-choice param: Reproduce [1/2]

The test added below makes cmd_make_descvec() assert in
"OSMO_ASSERT(multiple);" line, so it's expected to fail during CI.
Follow-up patch provides a fixes for it.

Change-Id: I6ad93a304ce498ba9d57fc7e2fd238e6c16e29e0
Related: b55f4d2df21b966c3953264d8961f259814f4650
Related: OS#6360
The file was modifiedtests/vty/vty_transcript_test.vty
The file was modifiedtests/vty/vty_transcript_test.c
Commit 2e41c4301ece14cbd9d22896a079619ba080200a by Pau Espin Pedrol
vty: assert in optional param followed by optional-multi-choice param: Fix [2/2]

in cmd_make_descr, cp during the asserting iteration looks like this:
(gdb) print cp
$18 = 0x555555c1939d ") [(one|two|three)"

As a result, first multiple is set to 0 and later on logic was missing
for this specific case.

Change-Id: I4c184db53bec28ab42bcd45e033733d850eea5d2
Fixes: b55f4d2df21b966c3953264d8961f259814f4650
Related: OS#6360
The file was modifiedsrc/vty/command.c