When running ttcn3-bts-test, parameters such as SETTA, FAKE_RSSI, FAKE_TOA, and others may persist across testcases if not explicitly reset, leading to unintended cross-test interference.
Reset all transceiver settings on CMD POWEROFF to ensure proper test isolation and predictable behavior between testcases.
trx_toolkit/burst_fwd: Use 'is' instead of '==' when checking if trx is src_trx
In python `a is b` is just a pointer comparison of locations of objects a and b, while `a == b` can involve doing arbitrary code invoking __eq__ and is generally slower even without __eq__ defined:
In [1]: class A: ...: pass ...:
In [2]: a = A() In [4]: b = A()
In [5]: a == a Out[5]: True
In [6]: a == b Out[6]: False
In [7]: a is a Out[7]: True
In [8]: a is b Out[8]: False
In [9]: %timeit a is a 84.2 ns ± 0.133 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each)
In [10]: %timeit a is b 87.5 ns ± 0.0736 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each)
In [11]: %timeit a == a 100 ns ± 0.659 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each)
In [12]: %timeit a == b 116 ns ± 0.399 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each)
BurstForwarder.forward_msg is one of the hottest places, as e.g. for every received packet from BTS it forwards it to multiple Ms receivers. It makes sense to be careful and save cycles here.
In Python it is enough to do `x = None` to release the object that was pointed to by x previously. So at Python level doing this extra del only spends more CPU time, but when we will switch to Cython, and e.g. Msg.burst will be a C-level attribute, the following will not work at all
del msg.burst msg.burst = None
because at runtime it will complain that
del msg.burst AttributeError: 'Msg' object has no attribute 'burst' and no __dict__ for setting new attributes
-> Remove unneeded del to save some time and avoid problems with upcoming switch to Cython.
trx_toolkit/udp_link: Factor code to describe remote into .desc_remote() function
And use that utility everywhere where remote of UDPLink is logged.
The reason we are doing this is that with upcoming switch to Cython the way remote address is stored will change to `struct sockaddr_in` and instead of updating all users, we will need to only change UDPLink.desc_remote() in one place.
trxcon/l1sched: pre-populate MR cache during lchan allocation
Instead of checking if the MR cache is populated in prim_compose_mr() and populating it there, let's do this during lchan allocation. Take a chance to move lchan allocation logic into its own function.
trxcon/fsm: handle_dch_est_req(): do not reset the scheduler
Calling l1sched_reset() results in resetting the UL SACCH cache, that may have been populated prior to sending L1CTL_DM_EST_REQ. Instead, do what the comment says - call l1sched_del_all_ts().
