Skip to content
Unstable

Changes

Summary

  1. deps/update.sh: split update cmds from Makefile (details)
  2. deps/update: don't fetch repos where COMMIT exists (details)
  3. deps: make output readable (details)
  4. deps/update: skip checkout if nothing to do (details)
  5. Makefile: avoid fetching deps if not needed (details)
Commit 5b3246910ea63dfc9abbafb2e1836484c3e9cd8a by Oliver Smith
deps/update.sh: split update cmds from Makefile

Move the inline shell commands from the Makefile to a separate script,
so they are easier to edit and maintain. Proper syntax highlighting, no
need for all the backslashes + &&, etc.

Change-Id: Ifab1158000ccb39f0b384bbd81841e417ed24f37
The file was modifieddeps/Makefile
The file was addeddeps/update.sh
Commit 68b83cd3f62619f764642f5aab491415d3065051 by Oliver Smith
deps/update: don't fetch repos where COMMIT exists

Instead of unconditionally fetching each git repository, check if the
commit we want to checkout already exists in the git repository. If that
is the case, then don't fetch it.

Related: OS#6572
Change-Id: I342957668892e7d29666fada82362cb4a6c7aac5
The file was modifieddeps/update.sh
Commit ebed76d72ac0e1467b1228146c44f0a1c8b34a29 by Oliver Smith
deps: make output readable

Instead of having a silent fetch and commits printed to stdout without
information about the repository they belong to, change the output to
have one line per git action and to include the repository name in each
of them.

Example output:

[titan.ProtocolEmulations.M3UA] Checking out b58f92046e48a7b1ed531e243a2319ebca53bf4c
[titan.ProtocolModules.IP] Checking out 1be86705f39ae38f3c04b2109806ee20d25e91d0
[titan.ProtocolModules.GTP_v13.5.0] Checking out 6b769f985eb91bf5a4332f29faa4a043b23ce62e
[titan.ProtocolModules.ICMP] Checking out e49d9fb9f7de637b4bf4803dc6b6e911a8661640
[osmo-uecups] Initial git clone
[titan.ProtocolModules.DIAMETER_ProtocolModule_Generator] Checking out ffd939595a08da1b8c8176aaa1f8578bfe02a912
[titan.ProtocolModules.L2TP] Checking out 17e76d3662bd0bb815158e8a9de1ec413f21b530
[titan.ProtocolModules.ICMPv6] Checking out 46f4d9b6e1e3c794294a92588401a81e4881dd27
[titan.ProtocolModules.LLC_v7.1.0] Checking out 09817f113255d7fb56f1d45d3dd629a093d9248d
[titan.ProtocolModules.M3UA] Checking out c496d298876fed55c2b730278b7ee77982555563
[titan.ProtocolModules.PFCP_v15.1.0] Checking out d550ad9ddb6f9c823c9a555254cd76cf0e738d18
[titan.ProtocolModules.MobileL3_v13.4.0] Checking out b6602eb357673f097ea1a1d22edd568ecd239da1
[titan.TestPorts.TELNETasp] Checking out 873fe539642542cd9a901c208f1ec11c6d2f5387
[titan.TestPorts.SIPmsg] Checking out 78bf0daf8c599d374089d97a054914d8439d133a
[titan.TestPorts.UDPasp] Checking out 54176e95850654e5e8b0ffa2f1b5f35c412b949c
[titan.ProtocolModules.BSSGP_v13.0.0] Checking out e97d92a8b66bec399babea52f593771b76cb175a
[titan.ProtocolModules.BSSMAP] Checking out 4acb6ab5f058477f0b90c2da182d52054e3614b0
[osmo-uecups] Updating URL to https://gerrit.osmocom.org/osmo-uecups
[osmo-uecups] Checking out 8362efef7c6fa341eb947a75786878e0685767b7

Change-Id: I0231488b02fdb5aa19b864e51864682ebbb3b0c6
The file was modifieddeps/update.sh
The file was modifieddeps/Makefile
Commit 3ebc0972e6a613dc78e72fdd95591d9b20cd8f6a by Oliver Smith
deps/update: skip checkout if nothing to do

Let the user see what changes when running "make deps" instead of
having unrelated lines for checking out the commits that are already
checked out.

Change-Id: I572ab11afd56e34d9d0d04cd1372af749caa7d48
The file was modifieddeps/update.sh
Commit c7e40d6a82ad2a004e5c82d46c5f82a9b7a99dc4 by Vadim Yanitskiy
Makefile: avoid fetching deps if not needed

Running `make deps` for the first time fetches all the dependencies.
Running `make deps` again currently results in unnecessary git-fetch
and get-checkout operations for each dependency.

This is not as bad as cloning dependencies from scratch every time,
but still takes time and triggers unnecessary requests to the servers.
It's also creating problems when building testsuites offline.

This patch makes the build system a bit smarter in a way that it would
only try to update dependencies if the 'deps/Makefile' was changed.

Change-Id: Iae98585f0a83b17596857eba8c2f51a785198580
Related: OS#6572
The file was modifiedMakefile