Skip to content
[Jenkins]Jenkins
log insign up
Success

Changes

Summary

  1. s1ap_proxy: Support replying errors (details)
  2. s1ap_proxy: handle E-RAB RELEASE INDICATION (details)
  3. Introduce initial metrics support (details)
  4. sctp_proxy: fix calling gauge_dec() on a counter (details)
  5. s1gw_metrics: more precise type hints (details)
  6. s1ap_proxy: move sctp_proxy:handle_pdu() to process_pdu_safe() (details)
Commit 851e9dca55ff3114b3815892ab1354f7c3e1591c by Vadim Yanitskiy
s1ap_proxy: Support replying errors

Sometimes it is needed not only to forward, but to transmit messages
initiated at the S1GW.  This is the case, for instance, if the MME
wants to initiate an E-RAB establishment, but the co-located UPF is
not available at the time or responds with an error.

This patch adds the generic infrastructure to be able to reply
(errors) and implements the above mentioned specific case for
the S1AP E-RAB SETUP REQUEST procedure.

Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4
The file was modifiedsrc/sctp_proxy.erl
The file was modifiedsrc/s1ap_proxy.erl
The file was modifiedtest/s1ap_proxy_test.erl
Commit e5d81cf935dd3c48a8c1bc8d19778398b4e38729 by Vadim Yanitskiy
s1ap_proxy: handle E-RAB RELEASE INDICATION

Change-Id: I13584620e28edf529325dc661c4b40d09acacc3f
The file was modifiedsrc/s1ap_proxy.erl
The file was modifiedtest/s1ap_proxy_test.erl
Commit 77baff42d19cc3d5724589d18346075a247b737f by Vadim Yanitskiy
Introduce initial metrics support

Metrics are implemented with the "exometer" library.
A reference config to export the metrics through statsd is provided.

Change-Id: I952e198238384dca4be94f91a01d7cfff0a1471f
Related: SYS#7065
The file was modifiedsrc/sctp_proxy.erl
The file was modifiedrebar.config
The file was modifiedsrc/osmo_s1gw.app.src
The file was addedsrc/s1gw_metrics.erl
The file was modifiedsrc/s1ap_proxy.erl
The file was modifiedconfig/sys.config
The file was addedtest/exometer_mock.erl
The file was modifiedsrc/pfcp_peer.erl
The file was modifiedtest/s1ap_proxy_test.erl
The file was addedinclude/s1gw_metrics.hrl
The file was modifiedsrc/osmo_s1gw_sup.erl
The file was modifiedsrc/sctp_server.erl
The file was modifiedrebar.lock
Commit 0f704fa0abe021855dbc9ebf3e270043f37a7ed2 by Vadim Yanitskiy
sctp_proxy: fix calling gauge_dec() on a counter

A follow-up commit will add type hints to prevent such errors.

Change-Id: Ic1e29061838e9c96cc4687308c6c56db7011ae9f
The file was modifiedsrc/sctp_proxy.erl
Commit 0521b9551477cfa4c3eacd5843c609774368af77 by Vadim Yanitskiy
s1gw_metrics: more precise type hints

This enables dialyzer to detect errors when:

* ctr_* API is used on an ?S1GW_GAUGE_* definition, and
* gauge_* API is used on an ?S1GW_CTR_* definition.

One of such errors has been fixed in a previous commit.

Change-Id: I36eaa5e04037e165e43eb960c541f967c394a2ea
The file was modifiedsrc/s1gw_metrics.erl
Commit 3491f72c607999961b7e1f3768da44aacf45689b by Vadim Yanitskiy
s1ap_proxy: move sctp_proxy:handle_pdu() to process_pdu_safe()

This way we can have more precise counting of PDUs forwarded as-is
due to exceptions, for which this patch also adds a counter.

Change-Id: I16d4cf279a930d35ca179bd9b49234d10180e5c5
The file was modifiedsrc/s1gw_metrics.erl
The file was modifiedsrc/s1ap_proxy.erl
The file was modifiedinclude/s1gw_metrics.hrl
The file was modifiedsrc/sctp_proxy.erl