Skip to content
Unstable

Changes

Summary

  1. sgsn: Validate TLI received in RAB Ass Req (details)
  2. sgsn: Test tx Rab Ass Resp with ITU X.213 IPv4 address format (details)
  3. sgsn: Introduce test TC_attach_pdp_act_user_addr_itu_x213_ipv4toolarge (details)
  4. sgsn: Improve validation of TLA encoded in RAB Ass Req (details)
  5. cosmetic: sgsn: Fix indenation whitespace (details)
  6. ggsn: README: document how to run with testenv (details)
  7. library/GTPv1C_Templates: Lots of improvements in template declarations (details)
  8. cosmetic: library/GTPv1C_Templates: remove extra indentation level (details)
  9. library/GTPv1C_Templates: Clean up PCO templates (details)
  10. mgw: Remove unneeded dep IPCP_Types.ttcn (details)
  11. s1gw: Remove unneeded dep IPCP_Types.ttcn (details)
  12. library: Move IPCP templates GTPv1C_Templates.ttcn -> (details)
  13. library/PCO_Types: Drop unused nonsense enum (details)
  14. library/PCO_Types.ttcn: Drop unsued IPCP_OPT enum (details)
  15. ggsn: Introduce test TC_pdp4(6)_act_deact_mtu (details)
  16. ggsn: Validate MTU sent during ICMPv6 RA (details)
  17. pcu: add testenv.cfg (details)
  18. bsc/osmo-bsc-sccplite.cfg: add trx1, trx2 (details)
  19. bsc/osmo-bsc{,-vamos}.cfg: add no missing-msc-text (details)
  20. bsc: add testenv.cfg (details)
  21. bts/run_fake_trx.sh: tweak cd logic (details)
  22. WIP: bts: add testenv.cfg (details)
  23. WIP: osmo-bsc.cfg: adjust logging (details)
  24. bsc/osmo-stp.cfg: sync with docker-playground (details)
  25. bsc/osmo-stp.cfg: adjust logging (details)
  26. add gsmtap logging (details)
  27. osmo-bsc: enable gsmtap logging (details)
  28. testenv: qemu: get coredump and show backtrace (details)
Commit a9c2ec6965909b7c2f443c1ecd6a582c5cca8cf2 by Pau Espin Pedrol
sgsn: Validate TLI received in RAB Ass Req

Related: OS#6508
Change-Id: I3a3699cea981caa89b30742c031d5f232418b0ee
The file was modifiedlibrary/ranap/RANAP_Templates.ttcn
The file was addedlibrary/ITU_X213_Types.ttcn
The file was modifiedsgsn/BSSGP_ConnHdlr.ttcn
The file was modifiedsgsn/gen_links.sh
Commit 1fb571d4fe7765d2e429a7125c9c2fa7990086d7 by Pau Espin Pedrol
sgsn: Test tx Rab Ass Resp with ITU X.213 IPv4 address format

Related: OS#6508
Related: SYS#7119
Change-Id: I38dd85f617600a974cbe8fd17597282eaf950a78
The file was modifiedsgsn/expected-results.xml
The file was modifiedsgsn/BSSGP_ConnHdlr.ttcn
The file was modifiedsgsn/SGSN_Tests_Iu.ttcn
The file was modifiedsgsn/SGSN_Tests.ttcn
Commit 7bdbd1d5264abf496795e0c2a74e96f07efd3e5f by Pau Espin Pedrol
sgsn: Introduce test TC_attach_pdp_act_user_addr_itu_x213_ipv4toolarge

Related: OS#6508
Related: SYS#7119
Change-Id: Id2501e38565db491a6248552e754f03f7b973997
The file was modifiedsgsn/expected-results.xml
The file was modifiedsgsn/SGSN_Tests_Iu.ttcn
The file was modifiedsgsn/BSSGP_ConnHdlr.ttcn
Commit e62b03c45dfbb94b8ba8cccf775979e7ef1e00fe by Pau Espin Pedrol
sgsn: Improve validation of TLA encoded in RAB Ass Req

Validate received TLA in RAB Ass Req according to confguration and test
expectancies.

Related: OS#6508
Related: SYS#7119
Change-Id: I725bf39c5564fb320954fc9e387ac569fc1a0136
The file was modifiedsgsn/SGSN_Tests_Iu.ttcn
The file was modifiedsgsn/BSSGP_ConnHdlr.ttcn
Commit f7ad820eb83bd92df4fb831ce438fe7287f1555c by Pau Espin Pedrol
cosmetic: sgsn: Fix indenation whitespace

Use tabs as done in all the file.

Change-Id: I8cb9283fee9d5a4ff5c34b9cde4d8fcce400343a
The file was modifiedsgsn/BSSGP_ConnHdlr.ttcn
Commit 6734ee53b419cfe30e85bceb7e30cf8bb853de41 by Oliver Smith
ggsn: README: document how to run with testenv

It is possible to run the GGSN testsuite in a lot of ways (as it was
ported from docker-playground, which had the same variations but with a
less consistent way of running them).

Document how it is typically run for development / in jenkins. This
should make it easier for users, in addition to testenv already telling
which configs are available if trying to run the ggsn testsuite without
the -c argument, and to the general help output in "./testenv.py run -h".

$ ./testenv.py run ggsn
[testenv] Using testsuite ggsn_tests (via alias ggsn)
[testenv] Found multiple testenv.cfg files:
[testenv]  * testenv_open5gs.cfg
[testenv]  * testenv_osmo_ggsn_all.cfg
[testenv]  * testenv_osmo_ggsn_v4_only.cfg
[testenv]  * testenv_osmo_ggsn_v4v6_only.cfg
[testenv]  * testenv_osmo_ggsn_v6_only.cfg
[testenv] Select a specific config (e.g. '-c open5gs') or all ('-c all')

Change-Id: I49421151b199fa6536da784b6c412b03f3fdbd05
The file was modifiedggsn_tests/README.md
Commit 6bba94c76d17cf541f70ea5c975b6402b0820978 by Pau Espin Pedrol
library/GTPv1C_Templates: Lots of improvements in template declarations

Also most the compiler warnings are fixed, only some which require
special more complex attention are left as is.

Change-Id: I38a4b1c5874fda173a7b89122c84cb83ac71a036
The file was modifiedmme/MME_Tests.ttcn
The file was modifiedlibrary/GTPv1C_Templates.ttcn
The file was modifiedsgsn/SGSN_Tests.ttcn
Commit 2c10e94d32d53a476fe13a70c6e6ac10e80987c0 by Pau Espin Pedrol
cosmetic: library/GTPv1C_Templates: remove extra indentation level

The extra first indentation level around 99% of the file just loses
space which makes it difficult to keep templates at an acceptable width.
Do similarly to what we already do in lots of other template files which
were added later than this one.

Change-Id: I87755ec0a9023e79fb5f7a40c6c1734dca44696b
The file was modifiedlibrary/GTPv1C_Templates.ttcn
Commit 4d0d30a59b5d02995d4ac6be2dddf3d18e6422aa by Pau Espin Pedrol
library/GTPv1C_Templates: Clean up PCO templates

* Define a generic ProtoElem template and use it everywhere.
* User superset instead of "*, tr_..., *" construct.

Change-Id: I005a6dea0606bcb677260f85b24396b55a150153
The file was modifiedlibrary/GTPv1C_Templates.ttcn
Commit 2f102a80f19ca72cc42a7066d7e9bd0a1de597ac by Pau Espin Pedrol
mgw: Remove unneeded dep IPCP_Types.ttcn

Change-Id: I318f4ba78adf778820e8d65d5932e454bc5da670
The file was modifiedmgw/gen_links.sh
The file was modifiedmgw/MGCP_Test.ttcn
Commit 436fc24ff1c55b4cec4d5b001c5980e9b6d9bc32 by Pau Espin Pedrol
s1gw: Remove unneeded dep IPCP_Types.ttcn

Change-Id: Iad81c8d76efa2618ca7e354d2b73617a54a8d5ee
The file was modifieds1gw/gen_links.sh
Commit cca9a92cd01610a390a33fb97e1286193a9963b8 by Pau Espin Pedrol
library: Move IPCP templates GTPv1C_Templates.ttcn -> IPCP_Templates.ttcn

We already have an IPCP_Types.ttcn, and the GTPv1C_Types from
ProtocolModules dep we use doesn't actually specify any record for IPCP,
so those are totally protocol independent.

Change-Id: I233292ea886e1b69a2f9aa1a159c816791b47136
The file was modifiedpgw/gen_links.sh
The file was modifiedgbproxy/gen_links.sh
The file was modifiedmme/gen_links.sh
The file was addedlibrary/IPCP_Templates.ttcn
The file was modifiedhnodeb/gen_links.sh
The file was modifiedlibrary/GTPv1C_Templates.ttcn
The file was modifiedggsn_tests/GGSN_Tests.ttcn
The file was modifiedsgsn/gen_links.sh
The file was modifiedggsn_tests/gen_links.sh
Commit 45c9f8f5c9285c275e882a143b11c022e0d948cf by Pau Espin Pedrol
library/PCO_Types: Drop unused nonsense enum

That enum is PAP related, plus it doesn't really match the section
describing, plus it's not used anywhere.
Looks like a development artifact which was not dropped during submit.

Change-Id: Ic791d20dd600b039daa2abef7fa25aaa6780a448
The file was modifiedlibrary/PCO_Types.ttcn
Commit 3f2ed83e7307746b881e3c0a7ac4e2cf727fe735 by Pau Espin Pedrol
library/PCO_Types.ttcn: Drop unsued IPCP_OPT enum

It is unused, plus IPCP_Types.ttcn already defines a more complete enum
in IpcpConfigOptCode.

Change-Id: I867ab36063db262b46fc4546c17a902699a6e37c
The file was modifiedlibrary/PCO_Types.ttcn
The file was modifiedlibrary/IPCP_Types.ttcn
Commit 54eb13f86a1db021eb018e6326766717f7142a48 by Pau Espin Pedrol
ggsn: Introduce test TC_pdp4(6)_act_deact_mtu

This tests so far only test retrieval of MTU over PCO, which is only
used for IPv4 APNs.
When IPv6 is in used, it is expected to be retrieved over IPv6 SLAAC RA.
Such tests will be done in a follow-up patch once the related procedure
is implemented in osmo-ggsn.

Related: OS#6298
Related: SYS#7122
Change-Id: I2ceb76a3a07b44f69937c9f5a040482320bca377
The file was modifiedggsn_tests/GGSN_Tests.ttcn
The file was modifiedlibrary/PCO_Types.ttcn
The file was modifiedggsn_tests/gen_links.sh
The file was modifiedlibrary/GTPv1C_Templates.ttcn
The file was modifiedggsn_tests/expected-results.xml
Commit 4c0cd581453b17e7eb7e3267583194417efb1147 by Pau Espin Pedrol
ggsn: Validate MTU sent during ICMPv6 RA

Related: OS#6298
Related: SYS#7122
Change-Id: Ia5bbc5f9e42b02d1b9bd6c4190a2bd439663deeb
The file was modifiedggsn_tests/GGSN_Tests.ttcn
The file was modifiedggsn_tests/expected-results.xml
The file was modifiedlibrary/ICMPv6_Templates.ttcn
Commit abac365b0c82fa8781ab63276ce49f4712830b93 by Oliver Smith
pcu: add testenv.cfg

Change-Id: I57956a0bb5d5e164c3f840815573164e52300459
The file was addedpcu/testenv_generic.cfg
The file was addedpcu/testenv_sns.cfg
Commit 3bc73ff6852ac9b507066e565594727480944915 by Oliver Smith
bsc/osmo-bsc-sccplite.cfg: add trx1, trx2

Synchronize with the config in docker-playground.

Change-Id: Ia959c725b9efee5ccf6a67e22e740a60b4fd28b9
The file was modifiedbsc/osmo-bsc-sccplite.cfg
Commit 1f1e9c59d1eabf8f7aaf8dd380ad955ffe3475ef by Oliver Smith
bsc/osmo-bsc{,-vamos}.cfg: add no missing-msc-text

Copy this option from the config in docker-playground to have less
cluttered output.

Change-Id: I0735e5bce207961ab960294c9f39404ab64a3fb1
The file was modifiedbsc/osmo-bsc-vamos.cfg
The file was modifiedbsc/osmo-bsc.cfg
Commit b8930f8b1c57db9a4f1fe3e0b086abc17002ce79 by Oliver Smith
bsc: add testenv.cfg

Change-Id: Ib2e92a9ebd78f5553161bcca433f39c7c39f3adf
The file was addedbsc/testenv_generic.cfg
The file was addedbsc/testenv_vamos.cfg
The file was addedbsc/osmo_bts_omldummy.sh
The file was addedbsc/testenv_sccplite.cfg
Commit 1bd98a3bc8944a76784325bfcb5a84df5de4656a by Oliver Smith
bts/run_fake_trx.sh: tweak cd logic

Don't test if FAKE_TRX_DIR is empty, because it is never empty at that
point. If it was empty, then the line above would assign a default
value.

Change-Id: I63f9720487b564de5c5609eb52a6bb9d5a8aa74f
The file was modifiedbts/run_fake_trx.sh
Commit 8470922c6fb7b0e3b77cea864bc5b2aaa7826602 by Oliver Smith
WIP: bts: add testenv.cfg

Change-Id: I5a1e23cab9d6b149f8a2b8f4c72d8ca2b9ed817b
The file was addedbts/BTS_Tests_OML.cfg
The file was modifiedbts/run_fake_trx.sh
The file was addedbts/testenv_oml.cfg
The file was addedbts/osmo-bts-oml.confmerge
The file was addedbts/testenv_virtphy.cfg
The file was addedbts/testenv_hopping.cfg
The file was addedbts/BTS_Tests_FH.cfg
The file was addedbts/osmo-bsc-fh.confmerge
The file was addedbts/testenv_generic.cfg
Commit d662c8126b828b6be8b5586c26de684e4d30011c by Oliver Smith
WIP: osmo-bsc.cfg: adjust logging

Change-Id: I8d0c68c1e5da8b7f833ea6ed38605a8cedd97480
The file was modifiedbsc/osmo-bsc.cfg
Commit a1babb32cd7c75d2d7630e2cec44d1d9da15d02c by Oliver Smith
bsc/osmo-stp.cfg: sync with docker-playground

Change-Id: I32fc1374d92405d642027e0c61fdd6a297cd7807
The file was modifiedbsc/osmo-stp.cfg
Commit 8305d39d765d1c0724b6d0e0acd47d4f811927ff by Oliver Smith
bsc/osmo-stp.cfg: adjust logging

Change-Id: I68a6dfaad3a19edf775b1fd81a6f5f694b61602a
The file was modifiedbsc/osmo-stp.cfg
Commit a29984eb30b42770ecbd9ff1e57d3f2832ecb6aa by Oliver Smith
add gsmtap logging

Change-Id: Iebdf4e19849970252145f9ccbd694eeb2c16aa8b
The file was modifiedbsc/osmo-stp.cfg
Commit 9fd51e48bf62dfd09f93008f9c7424b8a77fc709 by Oliver Smith
osmo-bsc: enable gsmtap logging

Change-Id: I2d54430cb32b2f77da17ff54b2a2f01209409a6a
The file was modifiedbsc/osmo-bsc.cfg
Commit 64a8fcb6904150ce6c9416861732444d4cb50d76 by Oliver Smith
testenv: qemu: get coredump and show backtrace

Change-Id: Ia08ac58c43388b5ea4d3712c5ef83f54b538b10a
The file was modified_testenv/data/scripts/qemu/qemu_init.sh
The file was modified_testenv/data/scripts/qemu/qemu_functions.sh