Skip to content
Success

Changes

Summary

  1. Use default_layer_manager for all ASPs in SCTP-mode=client & (details)
  2. m3ua: Log Tx NOTIFY msg (details)
  3. xua_rkm: Make sure existing AS gets added in list to receive (details)
  4. Make sure to NOTIFY current state to peer after ASP UP ACK / REG RESP (details)
  5. Improve format of logline prefix in LOGAS(P) macro (details)
  6. asp: Add debug log when transmitting on ASP (details)
Commit ce63d3b2027cefb8412179497100d14ed3fee0dd by Pau Espin Pedrol
Use default_layer_manager for all ASPs in SCTP-mode=client & m3ua-mode=ASP

With previous behavior, only first ASP configured as SCTPmode=client and
m3ua-mode=ASP in osmo_sccp_simple_client_on_ss7_id() would be applied
the default_layer_manager.
AS a result, if a client app (eg. osmo-bsc) would manually configure 1 AS
with 2 ASPs (and leave it to dynamic RKM to setup everything at osmo-stp),
it would fail, since the default LM FSM (in charge of waiting for NTFY and
then sending REQ_REG) would only be
applied to the first ASP.
So one would see 1st ASP doing ASPUP+REG_REQ+ASPAC correctly, but the
second one would do ASPUP+ASPAC directly, which would be refused by
osmo-stp since it had no routing context configured for that ASP/AS.

Change-Id: I50f9a088c55ad103cc23758192773fc855747e12
The file was modifiedsrc/osmo_ss7_vty.c
The file was modifiedsrc/osmo_ss7_asp.c
The file was modifiedsrc/ss7_asp.h
The file was modifiedsrc/sccp_user.c
The file was modifiedsrc/xua_default_lm_fsm.c
Commit f90d702e068956123a71019f9b62f51c4c30c033 by Pau Espin Pedrol
m3ua: Log Tx NOTIFY msg

Change-Id: Iae3f0922bd924e1472d551c8a3144b203da21f79
The file was modifiedsrc/m3ua.c
The file was modifiedsrc/xua_as_fsm.c
The file was modifiedsrc/xua_internal.h
Commit 1baf6bcd371303c3e541fb5b7e7e427efeec5c5a by Pau Espin Pedrol
xua_rkm: Make sure existing AS gets added in list to receive ASP-INACTIVE.ind event

Eg. if a 2nd ASP tries to register against a given AS (RFC 4666 5.1.3),
it should still update the AS to tell it the ASP is in ASP-INACTIVE
state. This way depending on traffic mode, the AS state may change as
well.

Change-Id: I85948ab98623a8a53521eb2d2e84244011b39a93
The file was modifiedsrc/xua_rkm.c
Commit f2e324e2f82efc93fd2a1124fa216d680659ed40 by Pau Espin Pedrol
Make sure to NOTIFY current state to peer after ASP UP ACK / REG RESP

As per  RFC4666 4.3.4.5:
"""
When an ASP moves from ASP-DOWN to ASP-INACTIVE within a particular AS,
a Notify message SHOULD be sent, by the ASP-UP receptor, after sending
the ASP-UP-ACK, in order to inform the ASP of the current AS state."""

It also needs to be done for REG RESP in order to support dynamic
ASPs/ASs, since in that case if dynamic ASP sends to SG an ASP-UP msg,
it contains no RCTX/AS reference, and hence the ASP will only be
assigned to an AS after the REG-REQ is sent, at which point we can send
the AS status to it.

Change-Id: I3dffa2e9c554f03c7c721b757ff33a89961665b5
The file was modifiedsrc/xua_asp_fsm.c
The file was modifiedsrc/xua_as_fsm.c
The file was modifiedsrc/xua_as_fsm.h
The file was modifiedsrc/xua_rkm.c
Commit 9bed29a034ecca266a188a246c7ab29aa11148aa by Pau Espin Pedrol
Improve format of logline prefix in LOGAS(P) macro

Adding "as-" and "asp" is totally misleading, because it's usual that we
name ASs "as-XYZ" and ASPs "asp-XYZ".
Intead, better use a usual prefix formatting to indicate the context.

Change-Id: Ib7b6652f2a96bf5c2a2233043755e0c639d41544
The file was modifiedsrc/ss7_asp.h
The file was modifiedsrc/ss7_as.h
Commit a141e2dbf8185e6615878999a71b38779c9e04bb by Pau Espin Pedrol
asp: Add debug log when transmitting on ASP

Change-Id: I8095ea02fdb063f9928035a20f257dd6bf0e6420
The file was modifiedsrc/osmo_ss7_asp.c