xua_rkm: Make sure existing AS gets added in list to receive (details)
Make sure to NOTIFY current state to peer after ASP UP ACK / REG RESP (details)
Improve format of logline prefix in LOGAS(P) macro (details)
asp: Add debug log when transmitting on ASP (details)
Commit
ce63d3b2027cefb8412179497100d14ed3fee0dd
by Pau Espin Pedrol
Use default_layer_manager for all ASPs in SCTP-mode=client & m3ua-mode=ASP
With previous behavior, only first ASP configured as SCTPmode=client and m3ua-mode=ASP in osmo_sccp_simple_client_on_ss7_id() would be applied the default_layer_manager. AS a result, if a client app (eg. osmo-bsc) would manually configure 1 AS with 2 ASPs (and leave it to dynamic RKM to setup everything at osmo-stp), it would fail, since the default LM FSM (in charge of waiting for NTFY and then sending REQ_REG) would only be applied to the first ASP. So one would see 1st ASP doing ASPUP+REG_REQ+ASPAC correctly, but the second one would do ASPUP+ASPAC directly, which would be refused by osmo-stp since it had no routing context configured for that ASP/AS.
Commit
1baf6bcd371303c3e541fb5b7e7e427efeec5c5a
by Pau Espin Pedrol
xua_rkm: Make sure existing AS gets added in list to receive ASP-INACTIVE.ind event
Eg. if a 2nd ASP tries to register against a given AS (RFC 4666 5.1.3), it should still update the AS to tell it the ASP is in ASP-INACTIVE state. This way depending on traffic mode, the AS state may change as well.
Commit
f2e324e2f82efc93fd2a1124fa216d680659ed40
by Pau Espin Pedrol
Make sure to NOTIFY current state to peer after ASP UP ACK / REG RESP
As per RFC4666 4.3.4.5: """ When an ASP moves from ASP-DOWN to ASP-INACTIVE within a particular AS, a Notify message SHOULD be sent, by the ASP-UP receptor, after sending the ASP-UP-ACK, in order to inform the ASP of the current AS state."""
It also needs to be done for REG RESP in order to support dynamic ASPs/ASs, since in that case if dynamic ASP sends to SG an ASP-UP msg, it contains no RCTX/AS reference, and hence the ASP will only be assigned to an AS after the REG-REQ is sent, at which point we can send the AS status to it.
Commit
9bed29a034ecca266a188a246c7ab29aa11148aa
by Pau Espin Pedrol
Improve format of logline prefix in LOGAS(P) macro
Adding "as-" and "asp" is totally misleading, because it's usual that we name ASs "as-XYZ" and ASPs "asp-XYZ". Intead, better use a usual prefix formatting to indicate the context.