Skip to content
Success

Changes

Summary

  1. mgw: Validate CallID before updating endp->x_osmo_ign (details)
  2. mgw: Delay osmux trunk setup to point where it is really needed (details)
  3. mgw: Store Command as enum in struct mgcp_request_data (details)
  4. mgw: Move struct mgcp_request_data definition to header file (details)
  5. mgw: Move cfg pointer from pdata to rq (details)
  6. mgw: Add backpointer from pdata to req to have context available (details)
  7. mgw: Use tall_mgw_ctx to allocate struct mgcp_config (details)
  8. mgw: Allocate req and pdata with talloc (details)
Commit 6f4cd1b7e19c631cd67d59d34933574cd8b8e8f7 by Pau Espin Pedrol
mgw: Validate CallID before updating endp->x_osmo_ign

This allows already starting to mark a clear line in CRCX handling
function between *read-only parsing + validation* and *read-write
allocation and update* of objects.

This in turn will allow further clean up on the second mentioned step.

Change-Id: Ia41f7383171bb24f48297456935c633536aa7b05
The file was modifiedsrc/libosmo-mgcp/mgcp_msg.c
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
Commit 533cf424e79200e9632e76e10461318c5c35ffcc by Pau Espin Pedrol
mgw: Delay osmux trunk setup to point where it is really needed

This way code is simplified by putting all osmux code together.

Change-Id: I27f7355ee99f1781fc2034a23c7cca756fb203d2
The file was modifiedsrc/libosmo-mgcp/mgcp_osmux.c
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
Commit 8d9d1d5e72bac51ec71f8888d0f834c9456967de by Pau Espin Pedrol
mgw: Store Command as enum in struct mgcp_request_data

This simplifies code further, and will simpify more code since we'll
have some easy way to check for the command we are in during a request.

Change-Id: I2d4b5ddb93376b59413b34c9668c41157ab05497
The file was modifiedinclude/osmocom/mgcp/mgcp_protocol.h
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
The file was modifiedinclude/osmocom/mgcp/mgcp.h
Commit 60eaa0d9095509318e69816c923c4cf435264e1d by Pau Espin Pedrol
mgw: Move struct mgcp_request_data definition to header file

All the related handling structs are placed in the header file, let's
move them there. This will also allow accessing the rq object
information in other files.

Change-Id: I1b2831874c1aaad054ad19bf87646062ba9d4da4
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
The file was modifiedinclude/osmocom/mgcp/mgcp_protocol.h
Commit 741d0ece374cd5ffbb58f43a6091c7f8c2c5ea63 by Pau Espin Pedrol
mgw: Move cfg pointer from pdata to rq

The externa object context is held in rq object, not in pdata object,
which holds parsed msg state only.

Change-Id: Ie64fb6250cc84f1e7737b5c1cf5cca314c7020ed
The file was modifiedinclude/osmocom/mgcp/mgcp_protocol.h
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
Commit f63ef75d9f1adf6c53adb7989692bac78210e021 by Pau Espin Pedrol
mgw: Add backpointer from pdata to req to have context available

This will also allow eg. parsing/validating differently based on the
command being parsed, or incrementing rate counters per cmd group.

Change-Id: I464258ca1a8817d58ae5c5426dfc3b7cee6763d3
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
The file was modifiedinclude/osmocom/mgcp/mgcp_protocol.h
The file was modifiedsrc/libosmo-mgcp/mgcp_msg.c
Commit 5ec1c132215f9fe057d7e12bf1a6f828c7dfab80 by Pau Espin Pedrol
mgw: Use tall_mgw_ctx to allocate struct mgcp_config

Change-Id: Ib51f1066bb73da4472bd8967cc1b1c44e964e9e5
The file was modifiedtests/mgcp/mgcp_test.c
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
The file was modifiedinclude/osmocom/mgcp/mgcp.h
Commit 6d629768c74900cba55ad43d9141fbc955c4fd29 by Pau Espin Pedrol
mgw: Allocate req and pdata with talloc

This will allow allocating parsed objects as child of the request and
make sure they are freed after handling the request finishes.
Change-Id: I2b971d0c8268f4c0a30b84b54a2e5f16ada4ecdb
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c