Skip to content
Success

Changes

Summary

  1. erab_fsm: add all-state event handler (details)
  2. erab_fsm: add fetch_info/1 for state introspection (details)
  3. sctp_server: add type hints (details)
  4. sctp_server: cosmetic: use ?FUNCTION_NAME in send_data/2 (details)
  5. sctp_server: pass MME addr/port to sctp_proxy as opaque data (details)
  6. sctp_server: cosmetic: rename State -> S (details)
  7. sctp_server: cosmetic: make #server_state last argument (details)
  8. sctp_server: pass #server_state to client_{add,del}() (details)
  9. sctp_server: make it abstract from sctp_proxy logic (details)
  10. sctp_server: add fetch_conn_list/0 for state introspection (details)
  11. sctp_proxy: add all-state event handler (details)
  12. sctp_proxy: add fetch_info/1 for state introspection (details)
Commit c859964affaf0d02aa3baa8f62d96799f407160b by Vadim Yanitskiy
erab_fsm: add all-state event handler

This patch prepares for a follow-up commit adding a request
(fetch_info) that must be handled in any state.

Change-Id: I2673f18ddee0f1eee27bb0ed71ca9073d6dea3f2
The file was modifiedsrc/erab_fsm.erl
Commit 6c4230d0e786bc6d0cf8ec26c7dd93940162b725 by Vadim Yanitskiy
erab_fsm: add fetch_info/1 for state introspection

This API will be used by the upcoming interactive VTY interface.

Change-Id: I02d5d043d6eda67c5bf2a6cf6ec1b863030a05a9
Related: SYS#7066
The file was modifiedsrc/erab_fsm.erl
The file was modifiedtest/erab_fsm_test.erl
Commit 378a7410dc2dc3355b0b8e124220dc25bdf3407d by Vadim Yanitskiy
sctp_server: add type hints

Change-Id: I0ddeccb81c52f1769fa0754c5628b53b1c9feb81
The file was modifiedsrc/sctp_server.erl
Commit b192da77f3ee0217d3cf01e3aa72c044f1258240 by Vadim Yanitskiy
sctp_server: cosmetic: use ?FUNCTION_NAME in send_data/2

Change-Id: Ifd646ba1383840f656df5a798299a5ed116731ae
The file was modifiedsrc/sctp_server.erl
Commit f7ac9167826ec1a2de87440533e3bfaf99bb0137 by Vadim Yanitskiy
sctp_server: pass MME addr/port to sctp_proxy as opaque data

This is the first step towards the goal of making the sctp_server
module more generic and abstract from the client module's API.

Change-Id: I1bd5f17d940173c4ec2d8d7a1d48778098008c84
The file was modifiedsrc/sctp_proxy.erl
The file was modifiedsrc/sctp_server.erl
Commit dae6981645fc4a693f63944c6fb3b3d6817c3e19 by Vadim Yanitskiy
sctp_server: cosmetic: rename State -> S

Using a shorter name makes the code more compact and beings it
in consistency with other modules.

Change-Id: I8dde744ac8b8798cdeed5d4eac47d4f650fe03f9
The file was modifiedsrc/sctp_server.erl
Commit ce212605cecc8e54285210d43d579da991faffb6 by Vadim Yanitskiy
sctp_server: cosmetic: make #server_state last argument

Make it consistent with the gen_server and gen_statem API.

Change-Id: I34bcdb818f58ccfa045d9fe17743523480e785f2
The file was modifiedsrc/sctp_server.erl
Commit 0d0b020a3568f812adad4699e3f901dd7653bd28 by Vadim Yanitskiy
sctp_server: pass #server_state to client_{add,del}()

Prepare for a follow-up patch, in which functions client_{add,del}()
will need to access more fields from the #server_state.

Change-Id: I5f784617745a9ecec2cfa998dc70e176311d24b1
The file was modifiedsrc/sctp_server.erl
Commit 8d2578441dc3869ed25d1952448785836096a8cd by Vadim Yanitskiy
sctp_server: make it abstract from sctp_proxy logic

Instead of using the sctp_proxy API directly, let the caller pass
a module name (handler), which implements the sctp_client behavior.

This makes the interaction between modules cleaner, allows to reuse
the sctp_server module in other places, and makes testing easier.

Change-Id: Iee4202dd4d4e9762fe74ead985aa43343ebdc524
The file was modifiedsrc/sctp_proxy.erl
The file was modifiedsrc/osmo_s1gw_sup.erl
The file was modifiedsrc/sctp_server.erl
The file was modifiedsrc/sctp_client.erl
Commit ccc0934790fc768fed636651ff14f1a76df4ca5b by Vadim Yanitskiy
sctp_server: add fetch_conn_list/0 for state introspection

This API will be used by the upcoming interactive VTY interface.

Change-Id: Ia673d6d57bbc3decf2c8038c1ee9573937702520
The file was modifiedsrc/sctp_server.erl
Commit 7c64fa49b8c5d9801ddffc9166374c4a7b6689f5 by Vadim Yanitskiy
sctp_proxy: add all-state event handler

This patch prepares for a follow-up commit adding a request
(fetch_info) that must be handled in any state.

Change-Id: I7b6acba7dd367fa28db8922a38ac10c00bd479fe
The file was modifiedsrc/sctp_proxy.erl
Commit d6c76c5858bfa0b9c945f58c2a2600a1cf5f0db9 by Vadim Yanitskiy
sctp_proxy: add fetch_info/1 for state introspection

This API will be used by the upcoming interactive VTY interface.

Change-Id: Ifd495c3b5e6f036fca1fbb2a06330f06ddfbbe61
The file was modifiedsrc/sctp_proxy.erl