Skip to content
Success

Changes

Summary

  1. mtp: Improve mtp_sap/ss7_user APIs (details)
  2. mtp: Introduce mtp_prim_* API helpers (details)
  3. mtp: Submit MTP-RESUME/PAUSE.ind up over MTP SAP (details)
  4. mtp: Submit MTP-STATUS.ind up over MTP SAP (details)
Commit 0adde5bdba523060d83f4ed5d63d36f100d57264 by Pau Espin Pedrol
mtp: Improve mtp_sap/ss7_user APIs

* The ss7_user API was so far never used externally, and internally only
  by SCCP and a unit test. It has several bad practices like first
  passing a inst parent ptr to allocate it, and then require a inst
  pointer again to operate on it (eg. register/unregister, send a
  primitive, etc.). This only makes the API more complex than needed and
  creates potential problems where a isnt differnet than the one ss7_user
  was allocated on is passed. Instead, the ss7_user is pinned to its
  parent inst during alloction, and all MTP-SAP always happens uniquely
  through the ss7_user. This follows much more closely the already
  sanitized and much more used sccp_sap/sccp_user APIs.

* Move more primitive/SAP related code to mtp_sap.c, to make it easier to
  spot where the inter-layer communication happens. This way we also have
  the same disposition as with sccp_sap/sccp_user.

* Clean up some primitive related APIs to unify naming with other usual
  SAP/primitive osmocom code.

Change-Id: If320db2bcec7ccbbc2cdac0cbf018fd8be7bde22
The file was modifiedsrc/ss7_instance.h
The file was modifiedTODO-RELEASE
The file was modifiedtests/ss7/ss7_test.c
The file was modifiedsrc/mtp_sap.c
The file was modifiedinclude/osmocom/sigtran/osmo_ss7.h
The file was modifiedsrc/xua_internal.h
The file was modifiedsrc/ss7_user.c
The file was modifiedsrc/sccp_scrc.c
The file was modifiedsrc/sccp_instance.c
The file was modifiedsrc/ss7_hmrt.c
The file was modifiedsrc/ss7_user.h
Commit 311d12212834a0fc5c6e7cfd5e5124c009a78926 by Pau Espin Pedrol
mtp: Introduce mtp_prim_* API helpers

This allows keeping more API related packing inside mtp_sap.c, as well
as provide public API to be able to submit a MTP-TRANSFER.req from
outside of the library (which will be used by osmo-bsc to submit
MGCP/CTRL over IPA in SCCPLite).

Change-Id: I4af154a65b8c23b9e8647845337ad1b5aa3901aa
The file was modifiedTODO-RELEASE
The file was modifiedsrc/ss7_hmrt.c
The file was modifiedinclude/osmocom/sigtran/mtp_sap.h
The file was modifiedsrc/mtp_sap.c
The file was modifiedsrc/sccp_scrc.c
The file was modifiedsrc/ss7_user.h
Commit 456beb11599a05a868d318473d157be897a03ed0 by Pau Espin Pedrol
mtp: Submit MTP-RESUME/PAUSE.ind up over MTP SAP

This allows supporting MTP users other than existing internal SCCP
stack.

Change-Id: If4360f07aa199e84c57820957ddde4259d1c92ce
The file was modifiedsrc/xua_snm.c
The file was modifiedsrc/ss7_user.h
The file was modifiedsrc/mtp_sap.c
The file was modifiedsrc/sccp_instance.c
Commit fd10986d6e7c48ff03d8b31e4cf833e1bfe241d4 by Pau Espin Pedrol
mtp: Submit MTP-STATUS.ind up over MTP SAP

This allows supporting MTP users other than existing internal SCCP
stack.

Change-Id: I5e810451481e50f2942b3a1bf88212326b8d124e
The file was modifiedsrc/mtp_sap.c
The file was modifiedsrc/ss7_user.h
The file was modifiedinclude/osmocom/sigtran/mtp_sap.h
The file was modifiedsrc/sccp_instance.c
The file was modifiedsrc/xua_snm.c