Skip to content
Success

Changes

Summary

  1. pySim-shell_test/utils: delete log files in general (details)
  2. pySim-shell_test/utils: enumerate pySim-shell logs (details)
  3. pySim-shell_test/utils: display pySim-shell logfile content (details)
  4. global_platform: ensure ArgumentParser gets a list for choices (details)
Commit dedc03d0f337dcd82ded8fef8c70acb8455adaea by pmaier@sysmocom.de
pySim-shell_test/utils: delete log files in general

When we get rid of temporary files, we delete those using a wildcard,
but for the logs from pySim-shell we explicitly memorize the name
of the pySim-shell logfile and delete it later by this explicit
name. This is not necessary, let's just delete all log files present
using a wildcard.

Related: OS#6601
Change-Id: I09dc7e59d1a3dcb68f54e3a8dccb86a1bc6c9ee6
The file was modifiedtests/pySim-shell_test/utils.py
Commit 1a47e1f08f560e9566ba5cf7a3fbf5e4b70e1d82 by pmaier@sysmocom.de
pySim-shell_test/utils: enumerate pySim-shell logs

When pySim-shell is called by a testcase, a logfile is createted. The logfile
filename contains the testcase name. However, a testcase may run pySim-shell
multiple times. In this case we overwrite the log from previous run. Let's use a
counter to generate unique file names for each run, so that we won't lose logs
from previous runs.

Related: OS#6601
Change-Id: Ib2195d9b2231f74d0a6c4fb28f4889b6c45efb1e
The file was modifiedtests/pySim-shell_test/utils.py
Commit cf8b4dbbd54056eec75f0df615d48a863eb74902 by pmaier@sysmocom.de
pySim-shell_test/utils: display pySim-shell logfile content

When we configure the tests to display file content, we only display files that
we compare, let's also display log file contents from pySim-shell. This will
be useful in situations where we only have log output from the tests, but no
access to the file system of the test host.

Related: OS#6601
Change-Id: Ibf6f78d7e71c213c7ca1caaf21c4c890e892261e
The file was modifiedtests/pySim-shell_test/utils.py
Commit 3d815859830197b9c55e0a49a1bd2532f71285e1 by pmaier@sysmocom.de
global_platform: ensure ArgumentParser gets a list for choices

When we use the argument parser with choices, we sometimes use a
list that we derive from a dictionary. However if we do that we
still must ensure that we really put a list and not a dict_values
or dict_keys class as parameter because this won't work any longer
with cmd2 version 2.5.0

Related: OS#6601
Change-Id: I165fefd8feb0d96cedc15d036fb32da381f711b3
The file was modifiedpySim/global_platform/__init__.py