Skip to content
Success

Changes

Summary

  1. mgw: CRCX: Split mgcp header pars parsing into a previous step (details)
  2. mgw: MDCX: Split mgcp header pars parsing into a previous step (details)
  3. mgw: DLCX: Split mgcp header pars parsing into a previous step (details)
  4. mgw: Decouple SDP parsing step from conn obj update (details)
  5. mgw: Remove wrong TODO comment (details)
  6. mgw: MDCX: Simplify early return code paths (details)
Commit 206be49c699b9f0f3d00c497b3d4eeb9bd1cafce by Neels Hofmeyr
mgw: CRCX: Split mgcp header pars parsing into a previous step

Do most of the initial parsing and verification in a prior step, filling
in a "parsed" struct which simplifies logic coming after for different
message types.
This commit only modifies stuff enough to work for CRCX.
Further work (commits) will follow for MDCX and DLCX.

Change-Id: I3ee5158c254213203830fe9c38de11c15b4b19c1
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
The file was modifiedinclude/osmocom/mgcp/mgcp_protocol.h
The file was modifiedsrc/libosmo-mgcp/mgcp_msg.c
The file was modifiedinclude/osmocom/mgcp/mgcp_msg.h
Commit 90ae9ed0a2e5a77a90920555001f63e9744b2f5e by Neels Hofmeyr
mgw: MDCX: Split mgcp header pars parsing into a previous step

Do most of the initial parsing and verification in a prior step, filling
in a "parsed" struct which simplifies logic coming after for different
message types.
This commit only modifies stuff enough to work for MDCX.
Further work (commits) will follow for DLCX.

Change-Id: I6ecb41fc2cc737c3a161b6bc98bd08ae01909655
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
The file was modifiedinclude/osmocom/mgcp/mgcp_protocol.h
The file was modifiedsrc/libosmo-mgcp/mgcp_msg.c
Commit 6747b60a9563c38ff3229b1c1612c458c7d19285 by Neels Hofmeyr
mgw: DLCX: Split mgcp header pars parsing into a previous step

Do most of the initial parsing and verification in a prior step, filling
in a "parsed" struct which simplifies logic coming after for different
message types.

Change-Id: I557a3a257ddefedc479a4aff974a74c4e4e2c85d
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
Commit 732cadd2c86927ca9e4dfe7ab22a22cdab369cad by Neels Hofmeyr
mgw: Decouple SDP parsing step from conn obj update

This allows delaying modification of the conn before full parsing
succeeds.

Change-Id: I4a2aecb542886672c1f586c6607714e0356abe35
The file was modifiedsrc/libosmo-mgcp/mgcp_sdp.c
The file was modifiedinclude/osmocom/mgcp/mgcp_sdp.h
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
The file was modifiedinclude/osmocom/mgcp/mgcp_protocol.h
Commit de4090d920500b6092c55370e038b116cc214e7c by Neels Hofmeyr
mgw: Remove wrong TODO comment

The TODO was written because the author had in mind the ptr where the
codec was stored was a MGCP endpoint object, but it is actually an
rtp_end which is an object under conn_rtp, so that's fine already with
current code.

Change-Id: I99d2211e81443883c45cc3fdda10e39a8c152063
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
Commit 78ee99adcf84b9455398be536b08f3c3f0fd9052 by Neels Hofmeyr
mgw: MDCX: Simplify early return code paths

Change-Id: Icb03a95e34e0c7d9396fefc2e37ee33ab09daa89
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c