Changes

s1gw: generalize f_TC_e_rab_setup_failure() for N E-RABs

The existing TC only tested PFCP Session Establishment failure with a
single E-RAB.  Generalize f_TC_e_rab_setup_failure() to use g_pars.erabs
throughout, so it works for any num_erabs: E-RAB 0 still triggers the
only PFCP Session Establishment Request (S1GW processes sequentially),
while all E-RABs in the request are expected to appear in the failure
response.

Add TC_e_rab_setup3_failure() which re-uses the same body with
num_erabs := 3, verifying that the S1GW lists all three E-RABs as
failed rather than just the first one.  Also make f_tr_E_RABList()
non-private so it is accessible from S1GW_Tests.ttcn.

Change-Id: I8a5dc338d28013dc85e1ce4b3bdac92cb3b35304
Related: osmo-s1gw.git I7933fceb0edcdfdc95ace35416297b11c83f0bc9

5gc: Introduce test TC_pdu_sess_est_always_on

This feature is right now not implemented in open5gs and hence the test
is expected to fail, since it returns no AlwaysOn Indication in PDU
Session Establishment Accept.

Change-Id: I282e0c8072172fa633bf82ed6b9492b0bb4362cc

5gc: Remove arleady tested TODO

PDU Sess Est Req with emeregency services is already tested in test
TC_normal_reg_emergency_services.

Change-Id: I5e2d202ffd019b22a006637534922e0ba1d09ca0

5gc: Introduce test TC_pdu_sess_est_pco_pcscf

Our deps/nas fork is modified to fix multiple incorrect definitions
around ProtocolContainer record.

Change-Id: Ic7b22ad647bcac944551ac1c29080f895ca72cf8

GTPv2_Templates: Add enum for PDN Type and use it in pgw testsuite

Change-Id: I9833e998522a09a15b93c8fed0e18a5e8159d760

GTPv1U_Emulation: Rename s/f_gtp1u_ping4/f_gtp1u_ping/

The function can also be (and is) used to ping IPv6 hosts.

Change-Id: I195cb048176aefddcb477083ddc949b86ec592fa

GTPv1U_Emulation: Clear entries from PidTable upon rx CUPS program_term_ind

Otherwise it will evnetually run out of entries if enough commands are
called sequentially.

Change-Id: I7be2639761726c09e4ea6f75c57d8414c5dbf128

5gc: Introduce tests TC_ng_register_ping6(_256)

Change-Id: Iedf3697265b91bdda85e8d32402345ea8d58dc9f

5gc: Introduce tests TC_ng_register_ping46(_256)

Depends: osmo-uecups.git Change-Id Ic2da7a761a8df7e006fc02ca6557a48f371e4151
Change-Id: I9cb250f07ac356b7345a570ed71590f041168ed2

General_types.ttcn: Introduce type OCT4_20n

This is useful to store EUAs of type v4,v6 or v4v6.

Change-Id: I00a35c444e3fb498712fbb4b9c310375c527052f

GTPv1U_Emulation: Support IPv6 SLAAC with osmo-uecups

Depends: osmo-uecups.git Change-Id I917b5c70f143d48b55b4e270e24594d1a36f71aa
Change-Id: Ic368383ea65161297e57a298a12c7b4adc927142

library/HTTP_Adapter: clarify response template restriction

Change-Id: I1a5ee842c30de9ec22d9e375f6b1b24b3eaee1e0

library/HTTP_Adapter: bail out early on failure

Replace `self.stop` with `Misc_Helpers.f_shutdown()`, and add it after
existing `setverdict(fail, ...)` calls that previously fell through.

In all these cases there is no meaningful way to continue: the caller
of these functions usually expects a valid value to be returned, and
continuing (not stopping) oftentimes results in confusing DTEs.

Change-Id: I229028d551d5cf9651e6e65314cd40f414bfe235

s1gw: f_REST_*(): use tr_HTTP_RespBody(decmatch T:?)

Pass `exp := tr_HTTP_RespBody(decmatch T:?)` to f_http_transact() in
every REST helper that decodes the response body.  This ensures both
a 2xx status code and a decodable body are required before any decode
attempt is made, producing an informative "Unexpected HTTP response"
verdict (rather than a confusing DTE) when e.g. an older osmo-s1gw
returns HTTP 404 with an empty body for an unsupported endpoint.

Change-Id: I6997dae5314d4a4588386183832426ab5b8d0843

eIM_Tests: align RSP version number in HTTP header

The RSP version number in the x-admin-protocol header string should
be set to v.2.1.0 (gsma/rsp/v2.1.0), even though the ASN.1 spec we
currently use is at version 2.5.

This is to maintain compatibility with older IPAd versions and also
stated explicitly in GSMA SGP.32 V2.1, section 6.1.

Change-Id: I125c3b13697c71d35788e54b7d88a9f943bb7a71
Related: SYS#7945

5gc: Update mobility procedure status

There's no procedure to do direct mobility between GERAN/UTRAN and 5GS
according to spec, and IP preservation is not supported either through
indirect mobility GERAN/UTRAN<->EUTRAN<->5GS.

Regarding 3GPP TS 23.502 Annex G, open5gs-smfd supports Gn interface but
only when working against a 4G MME, not through 5GS (PCF and AMF).

Related specs:
*3GPP TS 23.501:
** 5.17.2.4 Mobility between 5GS and GERAN/UTRAN
** Annex L (normative): Support of GERAN/UTRAN access
* 3GPP TS 23.502 4.11.5 Impacts to 5GC Procedures
* 3GPP TS 23.632 5.3 5GC-EPC Mobility Scenarios

Change-Id: I6bb8672fbd553a1a2a51b97a8360658afa0fddff

5gc: f_pdu_sess_establish(): Pass pdu sess type as param

Change-Id: I86680b0a2f5ddb27ecbebd5639199d2f77d397f6

SCCP_Adapter: Fix typo in setverdict string

Change-Id: I8924bf646b5c45e71746d3e76cf6aa3aa3fb674c

s1gw: initial testcases for MME pooling

Three test cases covering the MME pool selection logic in OsmoS1GW:

* TC_mme_pool_reject_fallback: S1GW falls back to the next pool entry
  when the first MME rejects S1SetupReq with S1SetupFailure.
* TC_mme_pool_timeout_fallback: S1GW falls back when the first MME
  does not respond to S1SetupReq within the timeout.
* TC_mme_pool_all_reject: all pool entries reject S1SetupReq; S1GW
  must send S1SetupFailure to the eNB and tear down the connection.

Infrastructure added to support these tests:

* S1AP_Server.ttcn: S1AP_ServerList type; directed register/unregister
  helpers (f_ConnHdlr_s1ap_register_to / _unregister_from) for use
  when multiple S1AP_Server_CT instances are active simultaneously.
* S1GW_ConnHdlr.ttcn: f_ConnHdlr_s1ap_setup_pool() drives the pool
  setup sequence: pre-registers with all servers, sends S1SetupReq once
  (S1GW re-transmits it per-MME), then iterates through the expected
  behaviors (ACCEPT / REJECT / TIMEOUT) waiting for each server in turn.
* S1GW_Tests.ttcn: f_init_s1ap_srv(N) starts N MME emulators on
  consecutive IP addresses; f_TC_exec_pool() orchestrates pool tests.
* osmo-s1gw.config: a 'mme_pool' section with three entries is added
  alongside the existing sctp_client section.  Older OsmoS1GW (without
  pooling support) will use sctp_client to connect to a single MME and
  the pool test cases will simply fail, as expected.  Newer OsmoS1GW
  will use mme_pool and all three test cases will pass.

Change-Id: Ib8fd62e4352e3055971a669b8b363078bcd95d8d
Related: SYS#7052

s1gw: add testcases for impatient eNB during MME pool selection

Two new test cases covering scenarios where the eNB disconnects before
S1 setup completes, targeting specific states of the enb_proxy FSM:

* TC_mme_pool_enb_disc_wait_s1setup_req: eNB connects but disconnects
  before sending S1SetupReq (enb_proxy in wait_s1setup_req).  No MME
  connection is ever attempted; S1GW must handle the disconnect cleanly.

* TC_mme_pool_enb_disc_wait_s1setup_rsp: eNB sends S1SetupReq, S1GW
  forwards it to the first pool MME (enb_proxy in wait_s1setup_rsp),
  then eNB disconnects before the response arrives.  S1GW must detect
  the eNB disconnect and close the open MME connection in response.

A new helper S1GW_ConnHdlr.f_ConnHdlr_s1ap_close() is added for these
tests: unlike f_ConnHdlr_s1ap_disconnect(), it closes the eNB-side
socket without waiting for an S1APSRV_EVENT_CONN_DOWN from a pool
server (since in these scenarios either no MME connection exists
yet, or the CONN_DOWN is captured by the test body directly).

Change-Id: I5d27cdafcb9f595a2d3db59beff17cd55de2539e
Related: SYS#7052

s1gw: add tests for MME registry REST procedures

Add three test cases exercising the S1GW REST interface for MME pool
management.  The REST TCs are gated on the mp_rest_enable module
parameter in the control block.

TC_rest_mme_list: query the MME pool list via REST and verify it
matches the three static entries from the 'mme_pool' section in
osmo-s1gw.config (mme0/mme1/mme2 with their respective addresses).

TC_rest_mme_add_del: add a new MME entry at runtime via REST, verify
it appears in both the list and individual GET responses, then delete
it and confirm it is gone.

TC_rest_mme_del_fallback: delete mme0 from the pool at runtime and
verify that a connecting eNB is routed directly to mme1, skipping the
deleted entry.  The pool is restored to its original state afterwards
via f_REST_mme_pool_restore().

Also add:
* {ts,tr}_MmeItem templates to S1GW_REST_Types.ttcn
* f_REST_mme_find(): returns the integer index of a named entry in a
  MmeList, or -1 if not found; used for both presence and absence checks
* f_REST_mme_pool_restore(): deletes all current entries and re-adds
  mme0/mme1/mme2 in original order to keep pool state predictable
  across test cases

Change-Id: I260bc987ab8ae0ecb547d0b69b261fd97c5c9c23
Related: SYS#7052

s1gw: enable the REST interface, fix wrong REST port

REST had been disabled because only nightly builds supported it.
The latest stable release (v0.4.0) also supports the REST interface,
so let's enable it unconditionally by removing the mp_rest_enable.

Also fix the REST port: mp_rest_port was incorrectly set
to 8125 (the StatsD port) instead of the actual REST port 8080.

Change-Id: I012749076c652ab541e569026eb01c696ad5adc8
Related: SYS#7052, SYS#7066

s1gw: use REST interface to check PFCP assoc state

It's quicker to query the IUT using the REST interface rather than
waiting for StatsD metric "gauge.pfcp.associated.value" to be received.
As a bonus, we "learn" the local/remote RTS from the S1GW, which can
be used in new PFCP related testcases.

Change-Id: Iec7594e79f533b08ee93b443a39cb9c8ff03da43

s1gw: add README.md

Change-Id: Ib5c1326c4260bf552b561a42f7ff9d3f28f89579

5gc: Introduce test TC_normal_reg_emergency_services_fallback

Change-Id: I17f15d901a10791ae0ad208b7d6ea9a333b93dad

5gc: Document 'SMS over NAS' procedures as not implemented by open5gs

Change-Id: I7e69fc8076b3177b8d5513170aecdc1f3f92cd8d

5gc: Document Location Services as not implemented by open5gs

Change-Id: I784ecc13018456278d228120cb22b786be6532ac

5gc: Remove conditional check for nightly repo in TC_pdu_sess_modification

open5gs 2.7.7 was recently released, so there's no need to guard for
nightly repo, since latest repo should contain now 2.7.7 with the needed
fix.

Change-Id: Ie37fb0e895710fdc7a4d497812cc2585b00996f8

5gc: Document multiple inter RAT procedures not implemented

Change-Id: I71cee40c79d7266ca46fa9757df18605646b320f

5gc: Introduce test TC_secondary_rat_data_usage_report

Change-Id: I8a82b1a8bcea948356d819af5c4919ae3829e549

NGAP_Templates: Fix wrong IE id in n2_PDUSessionResourceModifyConfirm

Change-Id: Iddcf4e3081d47f91e3b6ec52186116bf93e28c90

5gc: Introduce test TC_ran_initiated_qos_flow_mobility

Change-Id: I1a1df29fa254496990d3d9099b3072433468ecb1

bts: f_vgcs_talker_detect(): check received req. reference

Change-Id: Ie988408a4c13af72d93e2d29137c9e1ae9a0d408

bts: pre-compute RACH RA using oct2int() early

Change-Id: I03e8748cf56fa1aa9b598d237d325989d91ca372

bsc: f_TC_fh_params_gen_tr_ma(): simplify ma_mask calculation

Commented out code did not work back in 2020, but recent TITAN
versions (we use 11.1.0) have no problems compiling/running it.

Change-Id: I1892366af13b80844bcda3f84d18578284c35e08

bsc: fix copy-paste in TC_lcls_gcr_bway_codec_mismatch

The comment says that:

* first call leg uses FR,
* second call leg uses HR,

however the code actually modifies the first call leg to use HR.

The test still exercises a codec mismatch, so LCLS non-activation
is still triggered, but the leg roles are swapped relative to the
stated intent.  Fix this to avoid confusion.

Change-Id: Ie795516a447976ffe7b94ff8efcc649af0e37790

bts: fix ts_RslChanNr_CBCH4 used in SDCCH/8 TCs

Change-Id: I505346a5b29b1fa31b7207947f908eafb49c2724

library/GSM_RR_Types: add send/receive variants for t_RrL3Header

Change-Id: I35e5897470154f0a868fead4800a46849585a201

s1gw: fix TC_uemux_e_rab_release_ind: pass release_ind := true

TC_uemux_e_rab_release_ind never actually tests the release indication
because release_ind is false instead of true.  The test body becomes
identical to TC_uemux_e_rab_setup - no release indication is ever sent.

Change-Id: Ieed5d8a2bf4f696efc1071569090facc7b731f96
Fixes: cdc149a6 ("s1gw: add UEMux TCs for E-RAB SETUP and RELEASE")

s1gw: fix TC_e_rab_setup_failure: expect a specific S1AP PDU

setup_rsp is carefully constructed, but is not actually used.
The f_ConnHdlr_rx_s1ap_from_enb() call falls through to the ? default,
so the test accepts any S1AP PDU and never validates that the S1GW
actually populated the failed-items list correctly.

Change-Id: I6dbe272af4302c83ac26db9b7da5a7f7bc96daa7
Fixes: 47544443 ("s1gw: add TC_e_rab_setup_failure")

s1gw: fix f_ConnHdlr_erab_release_cmd_(): do not discard cause

Change-Id: I8c75e08dd041ce805aa232984445ba1e2bde40fa
Fixes: 64db5053 ("s1gw: ConnHdlr: allow passing {MME,ENB}-UE-S1AP-ID")

s1gw: f_ConnHdlr_rx_handover_cmd(): fix missing semicolon

Change-Id: I5db5fc01308f6834545b4be57631d77f1d2a3746

s1gw: f_ConnHdlr_conn_track_disable(): set conn_track := null

After deactivate, conn_track still holds the now-dead reference.
A second call (which can happen if any test explicitly calls this
before f_ConnHdlr_s1ap_disconnect()) will attempt to deactivate an
already-inactive default, which is a TTCN-3 runtime error.

Change-Id: I0b71b543fc7c4e87a86381cc3be23728e75cb59b
Fixes: adc942a94 ("s1gw: track eNB connection, fail immediately on loss")

s1gw: f_ConnHdlr_handover_rqd(): drop unused ERabList

Change-Id: If471e9f8daba918d1de90725db34e1930fd2e4d5
Fixes: 8eba9aada ("S1GW tests: Add test cases for S1 handover procedure")

s1gw: S1GW_UEMux.f_trx_s1ap_pdu(): fix setverdict() message param

On timeout pdu was never assigned (it's an out parameter), so TITAN
logs <unbound>.  The useful diagnostic is the expected template,
not the received value.

Change-Id: Idceefa82ec1b5fc71228b3847c7a22f419c9675e
Fixes: 325d07697 ("s1gw: add TC_uemux_uldl_nas_release")

s1gw: f_ConnHdlr_s1ap_setup(): make SupportedTAs configurable

Change-Id: Iade1889a702ef75859c5f847961ee4ca2398d4e1
Related: SYS#7052

s1gw: remove unused mp_s1gw_mme_ip

We don't really care what address the S1GW is using when connecting
to our virtual MME.  This is why this parameter is not used anywhere.

Change-Id: I4fff3954c005ac3df34d00c3b0312300ba4f49a1

s1gw: make S1AP_Server.f_conn_add() return nothing

The index of a new entry is not used anywhere, so do not return it.

Change-Id: I8df3985a665ae919849559ea8cf0fd33b5b22df8

s1gw: improve conn established/closed logging

Change-Id: Iacda25ac9b34fc55217e2681e434c68eef2d3445

library/ngap: do not link against libfftranscode

TITAN has built-in ASN.1 PER codec since version 10.0.0.
We're already using it for NGAP, so libfftranscode is no longer needed.

Change-Id: I7ea63993278a5e0ca22fc4217c2c3c5f8f9dc0a6
Related: OS#6490

testenv: do not install/check-for libfftranscode

All testsuites have been migrated to TITAN's own ASN.1 PER codec,
so installing libfftranscode is no longer required.

Change-Id: I410deedd1d4671496a8a784690bf630f2bdf6b53
Related: OS#6490

5gc: Introduce TC_handover_inter_ngran_n2

Change-Id: I90c7cc6c92864732a36556163aed692b2a1531b0

5gc: Introduce TC_handover_inter_ngran_n2_cancel

Change-Id: I1137c9a82478cca0372678d3c3299e9eebc79bd5

5gc: parametrize RequestType in f_pdu_sess_establish()

Change-Id: I69d6be5e581565720a21c719b0f982eb31ec2adf

5gc: Introduce tests for emergency services

These tests are expected to fail since open5gs has no specific logic for
emergency services in open5gs-amfd, and announces no Emergency Support
in Registration Accept.

Change-Id: Ie853b184da7ac8026bb0c360baabba762a7942e0

NGAP_Templates: Fix missing SourceToTarget_TransparentContainer IE not appended

Change-Id: I40cff63f3d662fa168b57abe4ef95f347ab74435

NGAP_Templates: Fix wrong id in HandoverReq template IE

Change-Id: I160a319543c32187bc4f2f3f4cf0baa667758f79

NGAP_Templates: Expect optional IEs in HandoverRequest templates

Change-Id: I227d67a589127ccfc5f44950daa3c0d95e425437

NGAP_Templates: Add missing IE TargetToSource_TransparentContainer to HandoverRequestAcknowledge

Change-Id: I19b0b718021326a64fe3bf1b3508a769a453557d

NGAP_Templates: Add missing IE TargetToSource_TransparentContainer to HandoverCommand

That IE is mandatory in HandoverCommand.

Change-Id: I59be738e8143ca1b9fee91c1bb377970e741efc5

hlr: pyhss: run the pyhss_hss service

Database preparations used to be done in PyHSS by all services if they
noticed that this was needed. The time between checking and creating the
tables caused a race condition where two services attempting to create
tables at the same time will result at one of them failing, we have seen
this in our ttcn3-hlr-test-pyhss jobs sometimes:

  [Database] [DEBUG] Table apn already exists
  [Database] [DEBUG] Table auc already exists
  [Database] [DEBUG] Table subscriber already exists
  …
  [testenv][pyhss] pyhss_gsup: setup script failed

I have fixed this upstream by letting only the main service (pyhss_hss)
prepare the database:
https://github.com/nickvsnetworking/pyhss/commit/8b8a2202c345fbb7262c9d07d03003cd2fdb819f

This means that we now need to run the pyhss_hss service in the HLR
tests, so pyhss_gsup doesn't fail with:

  [Database] [INFO] Waiting for the main service to prepare the database
  ERROR: 127.0.0.1:4222 did not become available within 5s!
  [testenv][pyhss] pyhss_gsup: setup script failed

Change-Id: I4fe689c8d8617432175ba403b45021c0f646970b

{hlr,hss}/pyhss/config: remove unused options

PyHSS had several unused config options. They have been removed
upstream, remove them from the osmo-ttcn3-hacks configs as well.

Related: https://github.com/nickvsnetworking/pyhss/pull/284
Change-Id: I87cf01e00fe0a3b32be9eaa4cf4c1ddf02cddc0b

ggsn: TC_pdp(4)6_clients_interact: Expect UEs can interact using global IPv6 address

The link-local IPv6 address is only meant to be used privately between
the UE and the GGSN, but the UEs should be in general able to reach each
other using their global IPv6 address (unless some operator policy
explicitly forbids it).

Since open5gs.git 6cc627c4855703a17c92352660078325c6ce63cc, open5gs-upfd supports
proper routing of IPv6 packets between UEs.

osmo-ggsn apparently doesn't implement that internal routing logic yet,
so these tests will start failing now, but it's actually legit to have
it not passing the test anymore.

Related: OS#6967
Change-Id: I0267a9c3bb85736a2aeb4f7dd91f44dbce626958

Print load before and after each test

Make it easier to figure out why tests are failing sporadically by
printing the load before and after each test. For example:

  ------ MGCP_Test.TC_crcx_sdp ------
  (14:24:42) load average: 0,41, 0,44, 0,54

Change-Id: If7d82c3c8105b3f3ca3470ba8f525ae8468dbeae

NGAP_Emulation: Use specific record types for AMF/RAN IDs

Change-Id: Ibd85be865a3a61c97d312df76ab3d1ae7ae32a6a

5gc: Introduce test TC_handover_inter_ngran_xn

Change-Id: I4de3f0a02ddbccc85988754a4cd83fe67b1453dc

hnbgw: Fix regression in hnbgw-test-latest

Fix unintended if condition removal in recent commit when
in the -latest case. That commit expected to leave the -latest path
untouched but ended up removing the line. Re-add it.

Fixes: 92f92923418c9803a0eb26fae97e56eed47a612d
Change-Id: I0abefedc9f9193b9665c3529a0f0e841db63401d

mgw: Fix sporadic failure in TC_one_crcx_loopback_rtp

Change-Id: I29d8d376e343975e3dfeb018bdfda8350bdfc58a

mgw: Improve failure message in f_TC_one_crcx_loopback_rtp()

Change-Id: I51c656371c330e4689738321d0739e280cab530d

bsc: TC_stat_msc_sctp_disconnected Fix sporadic failure

Since we recently increased a bit the timeout to assume the BSSAP_LE
peer (SMLC) is implicitly up, the function
f_bssap_le_wait_sccp_peer_available() may still be onging when we drop
the sctp connection at the STP in the test, which will generate an
explicit DUNA towards BSSAP_LE and hence fail the test because it never
comes back available before it times out.

Since we don't need nor test SMLC in this test, simply disable starting
the SMLC here to avoid this race condition and simplify the test.

Change-Id: Ib063a481d9039cbcd462609404dbae14922c7510

hnbgw: introduce test TC_pfcp_heartbeat_timeout

Related: SYS#7294
Change-Id: I1e0b50bc19e1fa1240274baea1e7fedd1265ffcb

hnbgw: Introduce test TC_pfcp_heartbeat_recovery_timestamp

Related: SYS#7294
Change-Id: I3f8098d7a34666961437fecc5100422a5e7436a4

hnbgw: Fix race conditions during PFCP Association

Since osmo-hnbgw now sends Heartbeat Requests, we need to take that into
account.
Furthermore, since it also now supports retriggering association when
detecting peer restarted upon rx of Heartbeat Req, use that to trigger
an association to clean up state and have a deterministic way to
synchronize at that point regarding state.

Change-Id: If62bd6c6e4d6cf73791029172d3d8880629f36a8

5gc: Split f_start_handler_with_pars() into multiple helpers

This allows initializing multiple ConnHldr and then connecting them and
starting them later. This is similar to what is is done eg. in
MSC_Tests.

Change-Id: Ic60009c5f7fcdc43f6e13f9ea469bfaddc639c33

RAN_Emulation: Support Tx RESET retries in RANAP

As already done in BSSAP in the same module.

Change-Id: I84553ae7aee19efa007bae060d7f7ca218a5f306

BSSAP_LE_Emulation: Support Tx RESET retries

Have same code as we use in RAN_Emulation.ttcnpp.

Change-Id: I475f93ff0b8cbfa5aa4900d02ddcb2e97fa5ca6a

BSSAP(_LE)/RANAP: Proper counting of RESET retries

N retries means N+1 attempts.

Since M3UA_Emulation (in deps/, not in library) doesn't support pushing
DUNA/DAVA as primitive up the stack, we cannot implement the related
SCCP primitives which should end up sending in turn other primitives to
our BSSAP(_LE)/RANAP emulations.
This means we currently have no way  to figure out the status of the
underlying SCCP/MTP link, and our only way is implement a poor man's
solution: retransmit RESET until we get an answer.

Since before bssap_reset_retries was set to 1 everywhere and we were
only attempting once, it could happen that the other end (the IUT) was
not yet connected to the STP when we send the RESET, and hence it is
discarded the STP. In that scenario, we'd time out and fail the test.
Instead, now that we do N+1 attempts, we retry after 5 seconds, which
should be enough time for the peer to reconnect to the STP.

Change-Id: If02e424672ff6270aed323c3bb236e822d8a39a4

bts: properly set BTS_Tests.mp_trx_pars for hopping cfg

The pchan assignment is *different* for the hopping and non-hopping
configurations, so let's override it in the BTS_Tests_FH.cfg.

Change-Id: Ib8861c3eee5157436fb213da212f22477639883f

bts: fix pchan config in default mp_trx_pars[]

The timeslot 3 of transceiver 2 is configured to PDCH in osmo-bsc.cfg,
so the pchan config must be GSM_PCHAN_PDCH, not GSM_PCHAN_TCHF.

Change-Id: I7de4e2796ca91e90f9261be8355e97e60a9cc13f
Fixes: 42d8bd501 ("BTS_Tests: re-organize configuration of TRX/TS params")

bts: document the default FDMA/TDMA configuration

Change-Id: I988f783c1e91c916982609c0f30088b00d00674e